Skip to contentSkip to conversation

mx6cuboxi: Fix boot of hummingboard dual-lite

PATCH New Fabio Estevam 4 participants 4 messages May 29, 2015 – Jun 15, 2015

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 mx6cuboxi: Fix boot of hummingboard dual-lite

Hummingboard dual-lite is picking the incorrect calibration structure.

Fix it so that it can boot.

While at it, also fix p1_mpdgctrl1 register to match Solid-run's setting.

Reported-by Andrei Gherzan <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>

---
I do not have access to a hummingboard dual-lite.

If anyone could test it, please provide a Tested-by, thanks

 board/solidrun/mx6cuboxi/mx6cuboxi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
board/solidrun/mx6cuboxi/mx6cuboxi.c +2 -2
index d15c726..9b1ecf0 100644
@@ -536,7 +536,7 @@ static const struct mx6_mmdc_calibration mx6dl_1g_mmcd_calib = {
 	.p0_mpdgctrl0 =    0x023C0224,
 	.p0_mpdgctrl1 =    0x02000220,
 	.p1_mpdgctrl0 =    0x02200220,
-	.p1_mpdgctrl1 =    0x02000220,
+	.p1_mpdgctrl1 =    0x02040208,
 	.p0_mprddlctl =    0x44444846,
 	.p1_mprddlctl =    0x4042463C,
 	.p0_mpwrdlctl =    0x32343032,

@@ -627,7 +627,7 @@ static void spl_dram_init(int width)
 	else if (is_cpu_type(MXC_CPU_MX6Q))
 		mx6_dram_cfg(&sysinfo, &mx6q_2g_mmcd_calib, &mem_ddr_4g);
 	else if (is_cpu_type(MXC_CPU_MX6DL))
-		mx6_dram_cfg(&sysinfo, &mx6q_1g_mmcd_calib, &mem_ddr_2g);
+		mx6_dram_cfg(&sysinfo, &mx6dl_1g_mmcd_calib, &mem_ddr_2g);
 	else if (is_cpu_type(MXC_CPU_MX6SOLO))
 		mx6_dram_cfg(&sysinfo, &mx6dl_512m_mmcd_calib, &mem_ddr_2g);
 }
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 mx6cuboxi: Fix boot of hummingboard dual-lite

Hi,

Quoted 9 lines · Fabio Estevam

Hummingboard dual-lite is picking the incorrect calibration structure.

Fix it so that it can boot.

While at it, also fix p1_mpdgctrl1 register to match Solid-run's setting.

Reported-by Andrei Gherzan <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
Tested-by Andrei Gherzan <[email protected]>
Signature · 3 lines
Andrei Gherzan
e: andrei at gherzan.ro
w: www.gherzan.ro
#2 lore raw

PATCH 1/1 mx6cuboxi: Fix boot of hummingboard dual-lite

Hi Stefano,

Quoted 8 lines · Andrei Gherzan

Hi,

Quoted 4 lines · Fabio Estevam

Hummingboard dual-lite is picking the incorrect calibration structure.

Fix it so that it can boot.

Quoted 7 lines
Quoted 5 lines

While at it, also fix p1_mpdgctrl1 register to match Solid-run's setting.

Reported-by Andrei Gherzan <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
Tested-by Andrei Gherzan <[email protected]>

Can this one be applied, please?

It fixes the boot on Hummingboard dual-lite model.

Thanks

#3 lore raw

PATCH 1/1 mx6cuboxi: Fix boot of hummingboard dual-lite

Hi Fabio,

Quoted 14 lines · Fabio Estevam

Hi Stefano,

Quoted 11 lines · Andrei Gherzan

Hi,

Quoted 7 lines · Fabio Estevam

Hummingboard dual-lite is picking the incorrect calibration structure.

Fix it so that it can boot.

While at it, also fix p1_mpdgctrl1 register to match Solid-run's setting.

Quoted 9 lines
Quoted 4 lines
Quoted 2 lines
Reported-by Andrei Gherzan <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
Tested-by Andrei Gherzan <[email protected]>

Can this one be applied, please?

It fixes the boot on Hummingboard dual-lite model.

Patch disappeared in patchwork (it was errouneosly set to "Changes requested") and missed my last PR.

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================