serial: stm32-usart: use of undefined SERIAL_STM32_USART_CONSOLE
Hi Maxime,
your commit 48a6092fb41f ("serial: stm32-usart: Add STM32 USART Driver") was merged into linux-next today (i.e., next-20150615), and contains the following piece of code:
[...]
#if defined(CONFIG_SERIAL_STM32_USART_CONSOLE) &&defined(CONFIG_MAGIC_SYSRQ)
#define SUPPORT_SYSRQ
#endif
[...]
The #if block can never be enabled as no symbol named SERIAL_STM32_USART_CONSOLE is defined in Kconfig. Did you maybe mean SERIAL_STM32_CONSOLE which you introduce in the same commit?
I detected the issue by running undertaker-checkpatch from the Undertaker tool suite (https://undertaker.cs.fau.de). There is also a tool in the Linux tree itself that can detect such issues (scripts/checkkconfigsymbols.py).
Regards,
Andreas
Hi Andreas,
2015-06-15 14:45 GMT+02:00 Andreas Ruprecht <[email protected]>:
Quoted 13 lines
Hi Maxime,
your commit
48a6092fb41f("serial: stm32-usart: Add STM32 USART Driver") was merged into linux-next today (i.e., next-20150615), and contains the following piece of code:[...]
#ifdefined(CONFIG_SERIAL_STM32_USART_CONSOLE)&&defined(CONFIG_MAGIC_SYSRQ)
#defineSUPPORT_SYSRQ
#endif
[...]
Quoted 3 lines
The #if block can never be enabled as no symbol named
SERIAL_STM32_USART_CONSOLEis defined inKconfig. Did you maybe meanSERIAL_STM32_CONSOLEwhich you introduce in the same commit?
Yes, you a right, I meant SERIAL_STM32_CONSOLE.
I will prepare a fix.
Quoted 5 lines
I detected the issue by running undertaker-checkpatch from the Undertaker tool suite (https://undertaker.cs.fau.de). There is also a tool in the Linux tree itself that can detect such issues (
scripts/checkkconfigsymbols.py).
Ok thanks for the pointer! I didn't know these tools.
Regards,
Maxime