Skip to contentSkip to conversation

sfc: mark state UNINIT after unregister

PATCH Applied Edward Cree 2 participants 2 messages Jun 15, 2015 – Jun 16, 2015

Subsystems (3)
Networking Network drivers Sfc network driver
lore
Share & tools
lore

Edward Cree

author
#0 lore raw

PATCH 1/1 sfc: mark state UNINIT after unregister

Without this change, modprobe -r sfc hits the BUG_ON() in efx_pci_remove_main().

Fixes e7fef9b45ae1 ("sfc: add sysfs entry to control MCDI tracing")
Reported-by Jarod Wilson <[email protected]>
Reviewed-by Jarod Wilson <[email protected]>
Signed-off-by Edward Cree <[email protected]>
---
 drivers/net/ethernet/sfc/efx.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/sfc/efx.c +1 -0
index 0c42ed9..67bdaf3 100644
@@ -2920,6 +2920,7 @@ static void efx_pci_remove(struct pci_dev *pci_dev)
 	efx_dissociate(efx);
 	dev_close(efx->net_dev);
 	efx_disable_interrupts(efx);
+	efx->state = STATE_UNINIT;
 	rtnl_unlock();
 
 	if (efx->type->sriov_fini)