Skip to contentSkip to conversation

acme.c: Fix IPv6 address handling in inet_any_pton

PATCH In review Hal Rosenstock 2 participants 3 messages Jun 16, 2015 – Jun 17, 2015 2 messages not in the archive InfiniBand

lore
Share & tools
lore

Hal Rosenstock

author
#0 lore raw

PATCH 1/1 acme.c: Fix IPv6 address handling in inet_any_pton

From: Ilya Nelkenbaum <ilyan-VPRAkNaXOzVWk0Htik3J/[email protected]>

In inet_any_pton() routine, src_addr was used by mistake instead of addr argument.

Signed-off-by Ilya Nelkenbaum <ilyan-VPRAkNaXOzVWk0Htik3J/[email protected]>
Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>
---
 acm/src/acme.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
acm/src/acme.c +1 -1
index 9bf7557..d54c8b9 100644
@@ -787,7 +787,7 @@ static int inet_any_pton(char *addr, struct sockaddr *sa)
 	if (ret <= 0) {
 		sin6 = (struct sockaddr_in6 *) sa;
 		sa->sa_family = AF_INET6;
-		ret = inet_pton(AF_INET6, src_addr, &sin6->sin6_addr);
+		ret = inet_pton(AF_INET6, addr, &sin6->sin6_addr);
 	}
 
 	return ret;
Signature · 6 lines
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 558026A4.3090907-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org

#2 lore raw

Thanks - applied manually

Quoted 1 line
 acm/src/acme.c |    2 +-

Path?

acm/src/acme.c static int inet_any_pton(char *addr, struct sockaddr

Quoted 5 lines
acm/src/acme.c +0 -0
index 9bf7557..d54c8b9 100644
@@ -787,7 +787,7 @@ static int inet_any_pton(char *addr, struct sockaddr

This was off by a couple hundred lines. Can you check your branch?

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 1828884A29C6694DAF28B7E6B8A82373A8FF64BF-P5GAC/[email protected]

author
#4 lore raw
Quoted 1 line · Sean

Thanks - applied manually

Thanks.

Quoted 11 lines
Quoted 1 line
 acm/src/acme.c |    2 +-

Path?

acm/src/acme.c static int inet_any_pton(char *addr, struct sockaddr

Quoted 5 lines
acm/src/acme.c +0 -0
index 9bf7557..d54c8b9 100644
@@ -787,7 +787,7 @@ static int inet_any_pton(char *addr, struct sockaddr

This was off by a couple hundred lines. Can you check your branch?

My bad; patch I sent was against SSA ACM. I only compared code to see it was needed upstream and forgot to port it against upstream tree. --
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html