clk: mvebu: flag the crypto clk as CLK_IGNORE_UNUSED
Subsystems (3)
PATCH v2 1/1 clk: mvebu: flag the crypto clk as CLK_IGNORE_UNUSED
The crypto SRAM, used by the armada 370 cpuidle code to workaround a bug in the BootROM code, requires the crypto clk to be up and running. Flag the crypto clk as IGNORE_UNUSED until we add the proper infrastructure to define the crypto SRAM in the DT and reference the crypto clk in this SRAM node.
missing CESA gate clk").
Cc: <[email protected]> #4.1
---
Changes since v1:
- add the Reported-by tag
- add the missing trailing ','
drivers/clk/mvebu/armada-370.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/mvebu/armada-370.c +1 -1
@@ -163,7 +163,7 @@ static const struct clk_gating_soc_desc a370_gating_desc[] __initconst = { { "pex1", "pex1_en", 9, 0 }, { "sata0", NULL, 15, 0 }, { "sdio", NULL, 17, 0 }, - { "crypto", NULL, 23, 0 }, + { "crypto", NULL, 23, CLK_IGNORE_UNUSED }, { "tdm", NULL, 25, 0 }, { "ddr", NULL, 28, CLK_IGNORE_UNUSED }, { "sata1", NULL, 30, 0 },
Signature · 1 line
1.9.1
PATCH v2 1/1 clk: mvebu: flag the crypto clk as CLK_IGNORE_UNUSED
Hi Mike, Stephen,
Quoted 6 lines · Boris Brezillon
The crypto SRAM, used by the armada 370 cpuidle code to workaround a bug in the BootROM code, requires the crypto clk to be up and running. Flag the crypto clk as
IGNORE_UNUSEDuntil we add the proper infrastructure to define the crypto SRAM in the DT and reference the crypto clk in this SRAM node.
Quoted 6 lines
Reported-by Kevin Hilman <[email protected]>Signed-off-by Boris Brezillon <[email protected]>Tested-by Kevin Hilman <[email protected]>Fixes 29e623475c50267ee3aaa49ebb6cbe107bce8d2a ("clk: mvebu: addmissing CESA gate clk").
Cc: <[email protected]> #4.1
Would it possible to apply this fix on 4.1-rc8 ?
Thanks,
Gregory
Quoted 22 lines
---
Changes since v1:
- add the Reported-by tag
- add the missing trailing ','drivers/clk/mvebu/armada-370.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/clk/mvebu/armada-370.c +1
-1@@ -163,7 +163,7 @@ static const struct clk_gating_soc_desc a370_gating_desc[] __initconst = { { "pex1", "pex1_en", 9, 0 }, { "sata0", NULL, 15, 0 }, { "sdio", NULL, 17, 0 }, - { "crypto", NULL, 23, 0 }, + { "crypto", NULL, 23, CLK_IGNORE_UNUSED }, { "tdm", NULL, 25, 0 }, { "ddr", NULL, 28, CLK_IGNORE_UNUSED }, { "sata1", NULL, 30, 0 },
Signature · 4 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH v2 1/1 clk: mvebu: flag the crypto clk as CLK_IGNORE_UNUSED
Quoting Gregory CLEMENT (2015-06-17 04:57:08)
Quoted 16 lines
Hi Mike, Stephen,
Quoted 6 lines · Boris Brezillon
The crypto SRAM, used by the armada 370 cpuidle code to workaround a bug in the BootROM code, requires the crypto clk to be up and running. Flag the crypto clk as
IGNORE_UNUSEDuntil we add the proper infrastructure to define the crypto SRAM in the DT and reference the crypto clk in this SRAM node.Quoted 6 lines
Reported-by Kevin Hilman <[email protected]>Signed-off-by Boris Brezillon <[email protected]>Tested-by Kevin Hilman <[email protected]>Fixes 29e623475c50267ee3aaa49ebb6cbe107bce8d2a ("clk: mvebu: addmissing CESA gate clk").
Cc: <[email protected]> #4.1
Quoted 3 lines
Acked-by Gregory CLEMENT <[email protected]>Would it possible to apply this fix on 4.1-rc8 ?
Hi Gregory,
I'm a bit confused by this. This patch fixes "clk: mvebu: add missing CESA gate clk", right? That patch lives in clk-next. It was not pushed to Linus' tree yet via a -fixes branch.
Thus I can just apply this patch to clk-next and the problem should be resolved in clk-next, no?
Furthermore, I do not have 29e623475c50267ee3aaa49ebb6cbe107bce8d2a anywhere in my tree. I'm not sure where this sha1 hash came from.
Regards,
Mike
Quoted 39 lines
Thanks,
Gregory
Quoted 22 lines
---
Changes since v1:
- add the Reported-by tag
- add the missing trailing ','drivers/clk/mvebu/armada-370.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/clk/mvebu/armada-370.c +1
-1@@ -163,7 +163,7 @@ static const struct clk_gating_soc_desc a370_gating_desc[] __initconst = { { "pex1", "pex1_en", 9, 0 }, { "sata0", NULL, 15, 0 }, { "sdio", NULL, 17, 0 }, - { "crypto", NULL, 23, 0 }, + { "crypto", NULL, 23, CLK_IGNORE_UNUSED }, { "tdm", NULL, 25, 0 }, { "ddr", NULL, 28, CLK_IGNORE_UNUSED }, { "sata1", NULL, 30, 0 },Signature · 9 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v2 1/1 clk: mvebu: flag the crypto clk as CLK_IGNORE_UNUSED
Hi Mike,
Quoted 21 lines · Michael Turquette
Quoting Gregory CLEMENT (2015-06-17 04:57:08)
Quoted 16 lines
Hi Mike, Stephen,
Quoted 6 lines · Boris Brezillon
The crypto SRAM, used by the armada 370 cpuidle code to workaround a bug in the BootROM code, requires the crypto clk to be up and running. Flag the crypto clk as
IGNORE_UNUSEDuntil we add the proper infrastructure to define the crypto SRAM in the DT and reference the crypto clk in this SRAM node.Quoted 6 lines
Reported-by Kevin Hilman <[email protected]>Signed-off-by Boris Brezillon <[email protected]>Tested-by Kevin Hilman <[email protected]>Fixes 29e623475c50267ee3aaa49ebb6cbe107bce8d2a ("clk: mvebu: addmissing CESA gate clk").
Cc: <[email protected]> #4.1Quoted 3 lines
Acked-by Gregory CLEMENT <[email protected]>Would it possible to apply this fix on 4.1-rc8 ?
Quoted 8 lines
Hi Gregory,
I'm a bit confused by this. This patch fixes "clk: mvebu: add missing CESA gate clk", right? That patch lives in clk-next. It was not pushed to Linus' tree yet via a -fixes branch.
Thus I can just apply this patch to clk-next and the problem should be resolved in clk-next, no?
You're right I was confused by the "<[email protected]> #4.1" tag, and I thought it was already part of 4.1. So indeed you just have to apply it in clk-next. You can remove the Fixes: and CC: line. And even better you can squashed it into 4d52b2acefdf "clk: mvebu: add missing CESA gate clk", if your clk-next branch is not immutable.
Quoted 3 lines
Furthermore, I do not have
29e623475c50267ee3aaa49ebb6cbe107bce8d2aanywhere in my tree. I'm not sure where this sha1 hash came from.
Me neither :)
Thanks,
Gregory
Quoted 35 lines
Quoted 35 lines
Quoted 23 lines
---
Changes since v1:
- add the Reported-by tag
- add the missing trailing ','drivers/clk/mvebu/armada-370.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/clk/mvebu/armada-370.c +1
-1@@ -163,7 +163,7 @@ static const struct clk_gating_soc_desc a370_gating_desc[] __initconst = { { "pex1", "pex1_en", 9, 0 }, { "sata0", NULL, 15, 0 }, { "sdio", NULL, 17, 0 }, - { "crypto", NULL, 23, 0 }, + { "crypto", NULL, 23, CLK_IGNORE_UNUSED }, { "tdm", NULL, 25, 0 }, { "ddr", NULL, 28, CLK_IGNORE_UNUSED }, { "sata1", NULL, 30, 0 },Signature · 9 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 4 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH v2 1/1 clk: mvebu: flag the crypto clk as CLK_IGNORE_UNUSED
In reply to Michael TurquetteHi Mike,
Quoted 21 lines · On Thu, 18 Jun 2015 11:36:54 -0700 Michael Turquette <[email protected]>…
Quoting Gregory CLEMENT (2015-06-17 04:57:08)
Quoted 16 lines
Hi Mike, Stephen,
Quoted 6 lines · Boris Brezillon
The crypto SRAM, used by the armada 370 cpuidle code to workaround a bug in the BootROM code, requires the crypto clk to be up and running. Flag the crypto clk as
IGNORE_UNUSEDuntil we add the proper infrastructure to define the crypto SRAM in the DT and reference the crypto clk in this SRAM node.Quoted 6 lines
Reported-by Kevin Hilman <[email protected]>Signed-off-by Boris Brezillon <[email protected]>Tested-by Kevin Hilman <[email protected]>Fixes 29e623475c50267ee3aaa49ebb6cbe107bce8d2a ("clk: mvebu: addmissing CESA gate clk").
Cc: <[email protected]> #4.1Quoted 3 lines
Acked-by Gregory CLEMENT <[email protected]>Would it possible to apply this fix on 4.1-rc8 ?
Quoted 8 lines
Hi Gregory,
I'm a bit confused by this. This patch fixes "clk: mvebu: add missing CESA gate clk", right? That patch lives in clk-next. It was not pushed to Linus' tree yet via a -fixes branch.
Thus I can just apply this patch to clk-next and the problem should be resolved in clk-next, no?
Yes. I've tagged this patch as applicable on stable 4.1 in case it didn't make it in the next -rc (which should be the last one before 4.1 is released).
I don't know if it's a good practice, but I've had several fixes which missed the targeted release in the past, and tagging them as stable helps in getting the patches applied afterwards.
Quoted 3 lines
Furthermore, I do not have
29e623475c50267ee3aaa49ebb6cbe107bce8d2aanywhere in my tree. I'm not sure where this sha1 hash came from.
Oops, I mixed the commit hash in my local branch and the one in clk-next (4d52b2acefdfceae0e47ed08324a96f511dc80b1).
Best Regards,
Boris
Signature · 3 lines
Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Michael Turquette
AppliedPATCH v2 1/1 clk: mvebu: flag the crypto clk as CLK_IGNORE_UNUSED
Quoting Boris Brezillon (2015-06-18 12:47:29)
Quoted 32 lines
Hi Mike,
Quoted 27 lines · On Thu, 18 Jun 2015 11:36:54 -0700 Michael Turquette <[email protected]>…
Quoting Gregory CLEMENT (2015-06-17 04:57:08)
Quoted 16 lines
Hi Mike, Stephen,
Quoted 6 lines · Boris Brezillon
The crypto SRAM, used by the armada 370 cpuidle code to workaround a bug in the BootROM code, requires the crypto clk to be up and running. Flag the crypto clk as
IGNORE_UNUSEDuntil we add the proper infrastructure to define the crypto SRAM in the DT and reference the crypto clk in this SRAM node.Quoted 6 lines
Reported-by Kevin Hilman <[email protected]>Signed-off-by Boris Brezillon <[email protected]>Tested-by Kevin Hilman <[email protected]>Fixes 29e623475c50267ee3aaa49ebb6cbe107bce8d2a ("clk: mvebu: addmissing CESA gate clk").
Cc: <[email protected]> #4.1Quoted 3 lines
Acked-by Gregory CLEMENT <[email protected]>Would it possible to apply this fix on 4.1-rc8 ?
Hi Gregory,
I'm a bit confused by this. This patch fixes "clk: mvebu: add missing CESA gate clk", right? That patch lives in clk-next. It was not pushed to Linus' tree yet via a -fixes branch.
Quoted 6 lines
Quoted 2 lines
Thus I can just apply this patch to clk-next and the problem should be resolved in clk-next, no?
Yes. I've tagged this patch as applicable on stable 4.1 in case it didn't make it in the next -rc (which should be the last one before 4.1 is released).
Applied to clk-next.
Regards,
Mike
Quoted 19 lines
I don't know if it's a good practice, but I've had several fixes which missed the targeted release in the past, and tagging them as stable helps in getting the patches applied afterwards.
Quoted 3 lines
Furthermore, I do not have
29e623475c50267ee3aaa49ebb6cbe107bce8d2aanywhere in my tree. I'm not sure where this sha1 hash came from.Oops, I mixed the commit hash in my local branch and the one in clk-next (
4d52b2acefdfceae0e47ed08324a96f511dc80b1).Best Regards,
Boris
Signature · 3 lines
Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com