Skip to contentSkip to conversation

NVMe: Remove the redundant sg_mar_end()

PATCH New Yijing Wang 2 participants 3 messages Jun 18, 2015 – Jun 19, 2015

Subsystems (2)
Block layer NVMe
lore
Share & tools
lore

Yijing Wang

author
#0 lore raw

PATCH 1/1 NVMe: Remove the redundant sg_mar_end()

sg_init_table() already called sg_mark_end(),
remove the redundant one.

Signed-off-by Yijing Wang <wangyijing at huawei.com>
---
 drivers/block/nvme-core.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/block/nvme-core.c +0 -1
index 683dff2..f099275 100644
@@ -1708,7 +1708,6 @@ struct nvme_iod *nvme_map_user_pages(struct nvme_dev *dev, int write,
 		length -= (PAGE_SIZE - offset);
 		offset = 0;
 	}
-	sg_mark_end(&sg[i - 1]);
 	iod->nents = count;
 
 	nents = dma_map_sg(&dev->pci_dev->dev, sg, count,
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 NVMe: Remove the redundant sg_mar_end()

Quoted 2 lines · Yijing Wang

sg_init_table() already called sg_mark_end(),
remove the redundant one.

Your repository must be pointing to an older branch. This function doesn't exist in the most current driver staged in the linux-block/for-next tree.

Quoted 8 lines
drivers/block/nvme-core.c +0 -1
@@ -1708,7 +1708,6 @@ struct nvme_iod *nvme_map_user_pages(struct nvme_dev *dev, int write,
 		length -= (PAGE_SIZE - offset);
 		offset = 0;
 	}
-	sg_mark_end(&sg[i - 1]);
 	iod->nents = count;
 
 	nents = dma_map_sg(&dev->pci_dev->dev, sg, count,
author
#2 lore raw

PATCH 1/1 NVMe: Remove the redundant sg_mar_end()

Quoted 6 lines · Keith Busch
Quoted 2 lines · Yijing Wang

sg_init_table() already called sg_mark_end(),
remove the redundant one.

Your repository must be pointing to an older branch. This function doesn't exist in the most current driver staged in the linux-block/for-next tree.

Sorry, my repository is linus's master branch, this code has been removed in latest nvme-core.c, please drop this patch.

Thanks!
Yijing.

Quoted 11 lines
Quoted 9 lines
drivers/block/nvme-core.c +0 -1
@@ -1708,7 +1708,6 @@ struct nvme_iod *nvme_map_user_pages(struct nvme_dev *dev, int write,
        length -= (PAGE_SIZE - offset);
        offset = 0;
    }
-    sg_mark_end(&sg[i - 1]);
    iod->nents = count;
 
    nents = dma_map_sg(&dev->pci_dev->dev, sg, count,
Signature · 2 lines
Thanks!
Yijing