0pf-j2 (sh2-compatible open hardware) FPGA board support.

New files for Open Processor Foundation j2 (superh sh2 compatible open hardware) FPGA board, with enough drivers to boot initramfs to a shell prompt on serial console. See http://0pf.org for details.

arch/sh/kernel/cpu/sh2/setup-0pf.c 2015-06-17 21:20:05.825356382 -0500 renamed from dev/null 2015-06-06 04:15:40.702718005 -0500 +7 -0

@@ -0,0 +1,82 @@
 
+#if defined(CONFIG_SERIAL_UARTLITE_0PF)
+static struct resource shj_uartlite_resources[] = {
+       [0] = DEFINE_RES_MEM(0xABCD0100, 16),
+       [1] = DEFINE_RES_IRQ(0x12),
+
+       [2] = DEFINE_RES_MEM(0xABCD0300, 16),
+       [3] = DEFINE_RES_IRQ(0x17),

Changes to existing files to add 0pf j2 board support.

Quoted 2 lines · Rob Landley

Changes to existing files to add 0pf j2 board support.

That's the second worse commit message and subject: line I've read today.

And there's no signed off by line.

And there was no 1/2 patch sent.

And, most importantly:

arch/sh/Kconfig

Quoted 1 line

arch/sh/Kconfig +0 -0

I don't care about arch/sh/ stuff, why are you sending this to me?

You have a bit of work to do here...

greg k-h

Quoted 2 lines · Rob Landley

Changes to existing files to add 0pf j2 board support.

That's the second worse commit message and subject: line I've read today.

And there's no signed off by line.

And there was no 1/2 patch sent.

And, most importantly:

arch/sh/Kconfig

Quoted 1 line

arch/sh/Kconfig +0 -0

I don't care about arch/sh/ stuff, why are you sending this to me?

You have a bit of work to do here...

greg k-h
.

Quoted 8 lines · Greg Kroah-Hartman

Quoted 2 lines · Rob Landley

Changes to existing files to add 0pf j2 board support.

That's the second worse commit message and subject: line I've read today.

And there's no signed off by line.

My bad. I've always sucked at filling out paperwork, and I didn't expect this to go in as is. But for the sake of following the official procedures (well, step 11 of of SubmittingPatches, it's not mentioned in any of the 26 steps of SubmitChecklist), here's the requested certification:

Signed-off-by Rob Landley <[email protected]>

Reviewed-by D. Jeff Dionne <[email protected]>

Quoted 1 line

And there was no 1/2 patch sent.

I sent one, which made it to the archive...

http://lkml.iu.edu/hypermail/linux/kernel/1506.2/02539.html

Quoted 5 lines

And, most importantly:

arch/sh/Kconfig

Quoted 1 line

arch/sh/Kconfig +0 -0

I don't care about arch/sh/ stuff, why are you sending this to me?

$ scripts/get_maintainer.pl j2-oldfiles.patch | grep Greg
Greg Kroah-Hartman <[email protected]> (maintainer:SERIAL DRIVERS)

Sorry, my bad, I was trying to follow the documented procedure. Personally I'd have trimmed the cc: list but filling things out in triplicate seems to be all the rage these days.

Quoted 1 line

You have a bit of work to do here...

As I mentioned in 0/2, yes. But "release early, release often" and all that.

(Or did we stop doing that now the Linux Foundation's in charge?

I'm still stuck in the hobbyist era from back before we had a foundation with committees and a hierarchy where you need to go through proper channels and three dozen patch submission steps in two different files and all that. I'm trying to keep up, but I've always been really bad at bureaucracy...)

Quoted 15 lines · Rob Landley

Quoted 8 lines · Greg Kroah-Hartman

Quoted 2 lines · Rob Landley

Changes to existing files to add 0pf j2 board support.

That's the second worse commit message and subject: line I've read today.

And there's no signed off by line.

My bad. I've always sucked at filling out paperwork, and I didn't expect this to go in as is. But for the sake of following the official procedures (well, step 11 of of SubmittingPatches, it's not mentioned in any of the 26 steps of SubmitChecklist), here's the requested certification:

Quoted 2 lines

Signed-off-by Rob Landley <[email protected]>

Reviewed-by D. Jeff Dionne <[email protected]>

You didn't do the 26 steps of SubmitChecklist, as step 5 would have caught almost all of these issues.

Quoted 5 lines

Quoted 1 line

And there was no 1/2 patch sent.

I sent one, which made it to the archive...

http://lkml.iu.edu/hypermail/linux/kernel/1506.2/02539.html

But you didn't cc: me on that, how am I supposed to know?

Quoted 9 lines

Quoted 5 lines

And, most importantly:

arch/sh/Kconfig

Quoted 1 line

arch/sh/Kconfig +0 -0

I don't care about arch/sh/ stuff, why are you sending this to me?

$ scripts/get_maintainer.pl j2-oldfiles.patch | grep Greg
Greg Kroah-Hartman <[email protected]> (maintainer:SERIAL DRIVERS)

Quoted 3 lines

Sorry, my bad, I was trying to follow the documented procedure. Personally I'd have trimmed the cc: list but filling things out in triplicate seems to be all the rage these days.

No, you need to break your patch up properly, a single patch hitting all of these files has never been ok.

Quoted 5 lines

Quoted 1 line

You have a bit of work to do here...

As I mentioned in 0/2, yes. But "release early, release often" and all that.

(Or did we stop doing that now the Linux Foundation's in charge?

Seriously? It's one thing to cc: a ton of people with a patch that for 90% of it, isn't relevant to them, and isn't even something they can do anything with.

It's another thing to rant against those who try to point out how to solve your issues.

Quoted 5 lines

I'm still stuck in the hobbyist era from back before we had a foundation with committees and a hierarchy where you need to go through proper channels and three dozen patch submission steps in two different files and all that. I'm trying to keep up, but I've always been really bad at bureaucracy...)

There is no such thing here, you know better than that,

stop trying to troll, it's not very becoming.

greg k-h

Changes to existing files to add 0pf j2 board support.

arch/sh/kernel/irq.c +6 -0

+
 atomic_t irq_err_count;
 
 /*

@@ -175,11 +177,24 @@ void do_softirq_own_stack(void)
        );
 }
 #else
+#define noinline __attribute__((noinline))
+static noinline void handle_irq_UART0(unsigned int irq) { generic_handle_irq(irq); }
+static noinline void handle_irq_UART1(unsigned int irq) { generic_handle_irq(irq); }
+static noinline void handle_irq_GPS(unsigned int irq) { generic_handle_irq(irq); }
+static noinline void handle_irq_EMAC(unsigned int irq) { generic_handle_irq(irq); }
 static inline void handle_one_irq(unsigned int irq)
 {

Hi Rob,

Quoted 1 line · Rob Landley

Changes to existing files to add 0pf j2 board support.

Thanks for your patch!

Like Greg already said, splitting it up in logical parts and providing useful patch descriptions would be highly appreciated.

Quoted 4 lines

arch/sh/Makefile +0 -0

index bf5b3f5..e609157 100644

arch/sh/Makefile isa-y := $(isa-y)-up · line 36

Quoted 5 lines

arch/sh/Makefile +1 -0

@@ -31,6 +33,7 @@ isa-y                                 := $(isa-y)-up
 endif
 
 cflags-$(CONFIG_CPU_SH2)               := $(call cc-option,-m2,)
+cflags-$(CONFIG_CPU_SH2J)              := $(call cc-option,-m2,)

This is superfluous, as CPU_SH2J selects CPU_SH2.

arch/sh/kernel/irq.c line 23

Quoted 9 lines

arch/sh/kernel/irq.c +1 -0

index eb10ff8..7de9bcb 100644
@@ -20,6 +20,8 @@
 #include <asm/thread_info.h>
 #include <cpu/mmu_context.h>
 
+#include <asm/board-0pf.h>

Board-specific inclusion in generic sh source file?

Quoted 19 lines

arch/sh/kernel/irq.c +9 -1

+
 atomic_t irq_err_count;
 
 /*

@@ -175,11 +177,24 @@ void do_softirq_own_stack(void)
        );
 }
 #else
+#define noinline __attribute__((noinline))
+static noinline void handle_irq_UART0(unsigned int irq) { generic_handle_irq(irq); }
+static noinline void handle_irq_UART1(unsigned int irq) { generic_handle_irq(irq); }
+static noinline void handle_irq_GPS(unsigned int irq) { generic_handle_irq(irq); }
+static noinline void handle_irq_EMAC(unsigned int irq) { generic_handle_irq(irq); }
 static inline void handle_one_irq(unsigned int irq)
 {
-       generic_handle_irq(irq);
+       switch(irq) {
+       case Irq_UART0: handle_irq_UART0(irq); break;
+       case Irq_UART1: handle_irq_UART1(irq); break;

arch/sh/kernel/irq.c void do_softirq_own_stack(void) · line 195

Quoted 6 lines

arch/sh/kernel/irq.c +6 -0

+       case Irq_GPS:   handle_irq_GPS(irq); break;
+       case Irq_EMAC:  handle_irq_EMAC(irq); break;
+       default:
+               generic_handle_irq(irq);
+               break;
+       }

What's the purpose of this change?

arch/sh/kernel/irq.c void do_softirq_own_stack(void) · line 197

Quoted 3 lines

arch/sh/kernel/irq.c +1 -1

 }
-#endif
+#endif // CONFIG_IRQSTACKS

Please no C++-style comments (scripts/checkpatch.pl?)

Quoted 7 lines · Geert Uytterhoeven

Quoted 1 line · Rob Landley

Changes to existing files to add 0pf j2 board support.

Thanks for your patch!

Like Greg already said, splitting it up in logical parts and providing useful patch descriptions would be highly appreciated.

I actually don't know how to split it up further. The initial port was done by a series of contractors (in Russia, I think), and then I inherited it to try to get something releasable. This is the smallest chunk I could get to actually boot.

I suppose I could send you the serial driver by itself, and _then_ the board, but it wouldn't compile if nothing uses it. (Similarly you can't boot the board without a serial console...)

(Now the reason _I_ thought you'd reject it had more to do with not having converted it to device tree yet, and things on that level. But I

wanted to get it out there so people outside $DAYJOB can test the hardware. We did a linuxcon japan presentation which lwn.net covered, and we're getting pokes about "where can I download this", so...)

Hi Rob,

Quoted 9 lines · Rob Landley

Quoted 7 lines · Geert Uytterhoeven

Quoted 1 line · Rob Landley

Changes to existing files to add 0pf j2 board support.

Thanks for your patch!

Like Greg already said, splitting it up in logical parts and providing useful patch descriptions would be highly appreciated.

Quoted 8 lines

I actually don't know how to split it up further. The initial port was done by a series of contractors (in Russia, I think), and then I inherited it to try to get something releasable. This is the smallest chunk I could get to actually boot.

I suppose I could send you the serial driver by itself, and _then_ the board, but it wouldn't compile if nothing uses it. (Similarly you can't boot the board without a serial console...)

You don't have to send in a big initial patch that actually boots. For new architecture/SoC/board support, just split it in logical hunks, and submit it in some logical order that always builds.

E.g.:
- SoC core support (arch/sh/),
- Board support (arch/sh/),
- Drivers.

The first two should go in through akpm (sh is orphaned), the rest through the individual subsystem maintainers.

Quoted 2 lines

(Now the reason _I_ thought you'd reject it had more to do with not having converted it to device tree yet, and things on that level. But I

Sh is an existing supported architecture, so DT is not a hard requirement.

If you would have waited until after the removal of sh, it would be much harder :-) (cfr. h8300, but Sato-san did a great job there, with DT, CCF, ...)

Quoted 3 lines

wanted to get it out there so people outside $DAYJOB can test the hardware. We did a linuxcon japan presentation which lwn.net covered, and we're getting pokes about "where can I download this", so...)

It's great to hear there's so much interest in this! Let's hope this will attract more actual contributors...

Quoted 4 lines

Quoted 2 lines

(Now the reason _I_ thought you'd reject it had more to do with not having converted it to device tree yet, and things on that level. But I

Sh is an existing supported architecture, so DT is not a hard requirement.

Yeah, but new board... And it's the right thing to do.

Quoted 25 lines · Geert Uytterhoeven

Hi Rob,

Quoted 9 lines · Rob Landley

Quoted 7 lines · Geert Uytterhoeven

Quoted 1 line · Rob Landley

Changes to existing files to add 0pf j2 board support.

Thanks for your patch!

Like Greg already said, splitting it up in logical parts and providing useful patch descriptions would be highly appreciated.

Quoted 8 lines

I actually don't know how to split it up further. The initial port was done by a series of contractors (in Russia, I think), and then I inherited it to try to get something releasable. This is the smallest chunk I could get to actually boot.

I suppose I could send you the serial driver by itself, and _then_ the board, but it wouldn't compile if nothing uses it. (Similarly you can't boot the board without a serial console...)

You don't have to send in a big initial patch that actually boots. For new architecture/SoC/board support, just split it in logical hunks, and submit it in some logical order that always builds.

Quoted 7 lines

E.g.:
- SoC core support (arch/sh/),
- Board support (arch/sh/),
- Drivers.

The first two should go in through akpm (sh is orphaned), the rest through the individual subsystem maintainers.

I'm aware sh is orphaned
(http://www.openwall.com/lists/musl/2014/02/17/3). I'm trying to do something about that.

I'm not up to maintaining an architecture myself (after the kernel.org/doc thing I walked away from kernel stuff for most of a year, as you can see I'm a bit out of practice), but I spoke to Yoshinori Sato (who used to maintain sh2, and only dropped it when renesas discontinued the hardware) and he said he might be interested in returning as a co-maintainer.

(I note that I've been regression testing and fixing sh4 in my aboriginal linux project for several years now, although it's been quiescent enough on the kernel side the majority of my posts about it seem to be qemu issues, from
https://lists.gnu.org/archive/html/qemu-devel/2010-03/msg00976.html to
http://comments.gmane.org/gmane.comp.emulators.qemu/294066 . Dealing with sh2 is new to me, but it's also my day job these days. :)

Quoted 4 lines

Quoted 2 lines

(Now the reason _I_ thought you'd reject it had more to do with not having converted it to device tree yet, and things on that level. But I

Sh is an existing supported architecture, so DT is not a hard requirement.

Yeah, but new board... And it's the right thing to do.

Quoted 2 lines

If you would have waited until after the removal of sh, it would be much harder :-) (cfr. h8300, but Sato-san did a great job there, with DT, CCF, ...)

Indeed he did. We had lunch with him when I was in Japan a couple weeks ago.

I've got the references I need to do this, just... lots of shoveling on a lot of fronts to do right now. (And I mentioned like 3 other things I already know I need to fix in the 0/2 message.)

Quoted 6 lines

Quoted 3 lines

wanted to get it out there so people outside $DAYJOB can test the hardware. We did a linuxcon japan presentation which lwn.net covered, and we're getting pokes about "where can I download this", so...)

It's great to hear there's so much interest in this! Let's hope this will attract more actual contributors...

The "where can I download this" is now the developer tab of 0pf.org by the way. And the mailing lists are on lists.nommu.org.

I'll try to submit an updated patch set in the next couple days.

Thanks,

Rob