VFIO: platform: enable ARM64 build

PATCH In review Eric Auger 3 participants 6 messages Jun 15, 2015 – Jun 23, 2015

Subsystems (2)

VFIO driver VFIO platform driver

lore

Share & tools

lore

Eric Auger

author

2015-06-15 09:13 UTC #0 lore raw

PATCH 1/1 VFIO: platform: enable ARM64 build

This patch enables building VFIO platform and derivatives on ARM64.

Signed-off-by Eric Auger <[email protected]>

---
 drivers/vfio/platform/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/vfio/platform/Kconfig +1 -1

index 1df7477..bb30128 100644
@@ -1,6 +1,6 @@
 config VFIO_PLATFORM
 	tristate "VFIO support for platform devices"
-	depends on VFIO && EVENTFD && ARM
+	depends on VFIO && EVENTFD && (ARM || ARM64)
 	select VFIO_VIRQFD
 	help
 	  Support for platform devices with VFIO. This is required to make

Signature · 1 line

1.9.1

Eric Auger

author

2015-06-22 15:56 UTC #2 lore raw

PATCH 1/1 VFIO: platform: enable ARM64 build

Hi Baptiste,

No unfortunately I don't have any HW to test this currently. I just test-compiled this. Up to you to decide whether you prefer waiting for a functional test for this. I sent that patch since I expect ARM64 to be the main platform where the VFIO platform drivermight be used for virtualization use case.

Best Regards

Eric

Quoted 28 lines · Baptiste Reynal

Acked-by Baptiste Reynal <[email protected]>
Tested-by Baptiste Reynal <[email protected]>
Out of curiosity, have you get VFIO running on ARM64 without any problems ?
Quoted 22 lines · Eric Auger
This patch enables building VFIO platform and derivatives on ARM64.
Signed-off-by Eric Auger <[email protected]>
---
 drivers/vfio/platform/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/vfio/platform/Kconfig +1 -2
index 1df7477..bb30128 100644
@@ -1,6 +1,6 @@
 config VFIO_PLATFORM
        tristate "VFIO support for platform devices"
-       depends on VFIO && EVENTFD && ARM
+       depends on VFIO && EVENTFD && (ARM || ARM64)
        select VFIO_VIRQFD
        help
          Support for platform devices with VFIO. This is required to make
--
1.9.1

Alex Williamson

2015-06-22 16:26 UTC #3 lore raw

Quoted 7 lines · Eric Auger

Hi Baptiste,
No unfortunately I don't have any HW to test this currently. I just test-compiled this. Up to you to decide whether you prefer waiting for a functional test for this. I sent that patch since I expect ARM64 to be the main platform where the VFIO platform drivermight be used for virtualization use case.

FWIW, I've been occasionally removing the arch condition entirely to build test on x86 as well. The Intel VT-d code certainly allows for devices described by ACPI, which I assume would fall under the platform category, but I don't know of any systems that do this, let alone any x86 platform devices that we'd actually want to expose to the user. Eventually we might want to consider decoupling this from an arch-based Kconfig option, but we could just as easily let the first non-ARM user think about that problem. Thanks,

Alex

Quoted 30 lines · Baptiste Reynal

Quoted 28 lines
Acked-by Baptiste Reynal <[email protected]>
Tested-by Baptiste Reynal <[email protected]>
Out of curiosity, have you get VFIO running on ARM64 without any problems ?
Quoted 22 lines · Eric Auger
This patch enables building VFIO platform and derivatives on ARM64.
Signed-off-by Eric Auger <[email protected]>
---
 drivers/vfio/platform/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/vfio/platform/Kconfig +1 -2
index 1df7477..bb30128 100644
@@ -1,6 +1,6 @@
 config VFIO_PLATFORM
        tristate "VFIO support for platform devices"
-       depends on VFIO && EVENTFD && ARM
+       depends on VFIO && EVENTFD && (ARM || ARM64)
        select VFIO_VIRQFD
        help
          Support for platform devices with VFIO. This is required to make
--
1.9.1

Baptiste Reynal

2015-06-23 06:56 UTC #4 lore raw

Quoted 8 lines · Alex Williamson

Quoted 7 lines · Eric Auger
Hi Baptiste,
No unfortunately I don't have any HW to test this currently. I just test-compiled this. Up to you to decide whether you prefer waiting for a functional test for this. I sent that patch since I expect ARM64 to be the main platform where the VFIO platform drivermight be used for virtualization use case.

On my side, VFIO has been tested on ARM64 using Fastmodels without problems, we can go ahead with the patch.

Quoted 10 lines

FWIW, I've been occasionally removing the arch condition entirely to build test on x86 as well. The Intel VT-d code certainly allows for devices described by ACPI, which I assume would fall under the platform category, but I don't know of any systems that do this, let alone any x86 platform devices that we'd actually want to expose to the user. Eventually we might want to consider decoupling this from an arch-based Kconfig option, but we could just as easily let the first non-ARM user think about that problem. Thanks,

Quoted 2 lines

Alex

Indeed, I'd rather wait for someone to show up with some use cases and tests before removing this condition.

Regards,
Baptiste

Quoted 33 lines

Quoted 30 lines · Baptiste Reynal
Quoted 28 lines
Acked-by Baptiste Reynal <[email protected]>
Tested-by Baptiste Reynal <[email protected]>
Out of curiosity, have you get VFIO running on ARM64 without any problems ?
Quoted 22 lines · Eric Auger
This patch enables building VFIO platform and derivatives on ARM64.
Signed-off-by Eric Auger <[email protected]>
---
 drivers/vfio/platform/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/vfio/platform/Kconfig +1 -2
index 1df7477..bb30128 100644
@@ -1,6 +1,6 @@
 config VFIO_PLATFORM
        tristate "VFIO support for platform devices"
-       depends on VFIO && EVENTFD && ARM
+       depends on VFIO && EVENTFD && (ARM || ARM64)
        select VFIO_VIRQFD
        help
          Support for platform devices with VFIO. This is required to make
--
1.9.1

Eric Auger

author

2015-06-23 07:06 UTC #5 lore raw

Hi Baptiste, Alex,

Quoted 12 lines · Baptiste Reynal

Quoted 8 lines · Alex Williamson
Quoted 7 lines · Eric Auger
Hi Baptiste,
No unfortunately I don't have any HW to test this currently. I just test-compiled this. Up to you to decide whether you prefer waiting for a functional test for this. I sent that patch since I expect ARM64 to be the main platform where the VFIO platform drivermight be used for virtualization use case.

Quoted 2 lines

On my side, VFIO has been tested on ARM64 using Fastmodels without problems, we can go ahead with the patch.

OK great

Quoted 11 lines

Quoted 11 lines
FWIW, I've been occasionally removing the arch condition entirely to build test on x86 as well. The Intel VT-d code certainly allows for devices described by ACPI, which I assume would fall under the platform category, but I don't know of any systems that do this, let alone any x86 platform devices that we'd actually want to expose to the user. Eventually we might want to consider decoupling this from an arch-based Kconfig option, but we could just as easily let the first non-ARM user think about that problem. Thanks,

Quoted 5 lines

Quoted 2 lines
Alex
Indeed, I'd rather wait for someone to show up with some use cases and tests before removing this condition.

Eric

Quoted 37 lines

Regards,
Baptiste
Quoted 33 lines
Quoted 30 lines · Baptiste Reynal
Quoted 28 lines
Acked-by Baptiste Reynal <[email protected]>
Tested-by Baptiste Reynal <[email protected]>
Out of curiosity, have you get VFIO running on ARM64 without any problems ?
Quoted 22 lines · Eric Auger
This patch enables building VFIO platform and derivatives on ARM64.
Signed-off-by Eric Auger <[email protected]>
---
 drivers/vfio/platform/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/vfio/platform/Kconfig +1 -2
index 1df7477..bb30128 100644
@@ -1,6 +1,6 @@
 config VFIO_PLATFORM
        tristate "VFIO support for platform devices"
-       depends on VFIO && EVENTFD && ARM
+       depends on VFIO && EVENTFD && (ARM || ARM64)
        select VFIO_VIRQFD
        help
          Support for platform devices with VFIO. This is required to make
--
1.9.1