Skip to contentSkip to conversation

Compiler warning from drivers/media/usb/au0828/au0828-video.c: In function ‘queue_setup’

DISCUSSION Shuah Khan 1 participant 2 messages Jun 24, 2015 – Jul 14, 2015 Media (V4L/DVB)

lore
Share & tools
lore

Shuah Khan

author
#0 lore raw

Hi Mauro,

I am seeing the following warning from au0828 - linux_media media_controller branch:

drivers/media/usb/au0828/au0828-video.c: In function ‘queue_setup’:
drivers/media/usb/au0828/au0828-video.c:679:6: warning: ‘entity’ may be used uninitialized in this function [-Wmaybe-uninitialized]
if (sink == entity)

      ^
drivers/media/usb/au0828/au0828-video.c:644:24: note: ‘entity’ was
declared here
  struct media_entity  *entity, *source;
                        ^

This looks real to me, but don't know what entity should have been initialized to.

thanks,
-- Shuah

Signature · 5 lines
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
[email protected] | (970) 217-8978
author
#1 lore raw
Quoted 9 lines · Shuah Khan

Hi Mauro,

I am seeing the following warning from au0828 - linux_media media_controller branch:

drivers/media/usb/au0828/au0828-video.c: In function ‘queue_setup’:
drivers/media/usb/au0828/au0828-video.c:679:6: warning: ‘entity’ may be used uninitialized in this function [-Wmaybe-uninitialized]
if (sink == entity)

Quoted 9 lines
      ^
drivers/media/usb/au0828/au0828-video.c:644:24: note: ‘entity’ was
declared here
  struct media_entity  *entity, *source;
                        ^

This looks real to me, but don't know what entity should have been initialized to.

Hi Mauro,

I don't your patch that fixes this issue in the media-controller branch. Are you planning to get that in?

thanks,
-- Shuah

Signature · 5 lines
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
[email protected] | (970) 217-8978