Skip to contentSkip to conversation

spi: zynq: missing break statement

PATCH In review Dan Carpenter 3 participants 3 messages Jun 24, 2015 – Jul 7, 2015

Subsystems (3)
Kernel janitors SPI Arm/Zynq architecture
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 spi: zynq: missing break statement

There is a missing break statement here so selecting both only selects upper.

Fixes dfe11a11d523 ('spi: Add support for Zynq Ultrascale+ MPSoC GQSPI controller')
Signed-off-by Dan Carpenter <[email protected]>
drivers/spi/spi-zynqmp-gqspi.c +1 -0
index 87b20a5..f23f36e 100644
@@ -214,6 +214,7 @@ static void zynqmp_gqspi_selectslave(struct zynqmp_qspi *instanceptr,
 	case GQSPI_SELECT_FLASH_CS_BOTH:
 		instanceptr->genfifocs = GQSPI_GENFIFO_CS_LOWER |
 			GQSPI_GENFIFO_CS_UPPER;
+		break;
 	case GQSPI_SELECT_FLASH_CS_UPPER:
 		instanceptr->genfifocs = GQSPI_GENFIFO_CS_UPPER;
 		break;
Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Dan Carpenter

There is a missing break statement here so selecting both only selects upper.

Fixes dfe11a11d523 ('spi: Add support for Zynq Ultrascale+ MPSoC GQSPI controller')
Signed-off-by Dan Carpenter <[email protected]>
drivers/spi/spi-zynqmp-gqspi.c +0 -0
index 87b20a5..f23f36e 100644

drivers/spi/spi-zynqmp-gqspi.c static void zynqmp_gqspi_selectslave(struct zynqmp_qspi *instanceptr, · line 220

Quoted 7 lines
drivers/spi/spi-zynqmp-gqspi.c +1 -0
@@ -214,6 +214,7 @@ static void zynqmp_gqspi_selectslave(struct zynqmp_qspi *instanceptr,
 	case GQSPI_SELECT_FLASH_CS_BOTH:
 		instanceptr->genfifocs = GQSPI_GENFIFO_CS_LOWER |
 			GQSPI_GENFIFO_CS_UPPER;
+		break;
 	case GQSPI_SELECT_FLASH_CS_UPPER:
 		instanceptr->genfifocs = GQSPI_GENFIFO_CS_UPPER;
 		break;
Acked-by Michal Simek <[email protected]>

Thanks,
Michal

#2 lore raw

Applied "spi: zynq: missing break statement" to the spi tree

In reply to Dan Carpenter

The patch

spi: zynq: missing break statement

has been applied to the spi tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 861a481c5ede75bf31bc118f1f7f6d1f420182b5 Mon Sep 17 00:00:00 2001

From: Dan Carpenter <[email protected]>
Date: Wed, 24 Jun 2015 17:31:33 +0300
Subject: [PATCH] spi: zynq: missing break statement

There is a missing break statement here so selecting both only selects upper.

Fixes dfe11a11d523 ('spi: Add support for Zynq Ultrascale+ MPSoC GQSPI controller')
Signed-off-by Dan Carpenter <[email protected]>
Acked-by Michal Simek <[email protected]>
Signed-off-by Mark Brown <[email protected]>
---
 drivers/spi/spi-zynqmp-gqspi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/spi/spi-zynqmp-gqspi.c +1 -0
index 87b20a511a6b..f23f36ebaf3d 100644
@@ -214,6 +214,7 @@ static void zynqmp_gqspi_selectslave(struct zynqmp_qspi *instanceptr,
 	case GQSPI_SELECT_FLASH_CS_BOTH:
 		instanceptr->genfifocs = GQSPI_GENFIFO_CS_LOWER |
 			GQSPI_GENFIFO_CS_UPPER;
+		break;
 	case GQSPI_SELECT_FLASH_CS_UPPER:
 		instanceptr->genfifocs = GQSPI_GENFIFO_CS_UPPER;
 		break;
Signature · 6 lines
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html