leds: fix aat1290 build errors
PATCH 1/1 leds: fix aat1290 build errors
From: Randy Dunlap <[email protected]>
Fix build errors when LEDS_AAT1290=y and V4L2_FLASH_LED_CLASS=m by restricting LEDS_AAT1290 to =m if V4L2_FLASH_LED_CLASS=m.
drivers/built-in.o: In function `aat1290_led_remove':
leds-aat1290.c:(.text+0xe5d77): undefined reference to v4l2_flash_release' drivers/built-in.o: In function aat1290_led_probe':
leds-aat1290.c:(.text+0xe6494): undefined reference to `v4l2_flash_init'
--- drivers/leds/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/leds/Kconfig +1 -0
@@ -42,6 +42,7 @@ config LEDS_88PM860X config LEDS_AAT1290 tristate "LED support for the AAT1290" depends on LEDS_CLASS_FLASH + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS depends on GPIOLIB depends on OF depends on PINCTRL
Hi Randy,
Thanks for the patch.
Quoted 22 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
Fix build errors when LEDS_AAT1290=y and V4L2_FLASH_LED_CLASS=m by restricting
LEDS_AAT1290to =m if V4L2_FLASH_LED_CLASS=m.
drivers/built-in.o: In function `aat1290_led_remove':
leds-aat1290.c:(.text+0xe5d77): undefined reference tov4l2_flash_release' drivers/built-in.o: In functionaat1290_led_probe':
leds-aat1290.c:(.text+0xe6494): undefined reference to `v4l2_flash_init'Signed-off-by Randy Dunlap <[email protected]>Cc Jacek Anaszewski <[email protected]>Cc Bryan Wu <[email protected]>Cc Richard Purdie <[email protected]>--- drivers/leds/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/leds/Kconfig config LEDS_88PM860X · line 48
Quoted 7 lines
drivers/leds/Kconfig +1
-0@@ -42,6 +42,7 @@ config LEDS_88PM860X config LEDS_AAT1290 tristate "LED support for the AAT1290" depends on LEDS_CLASS_FLASH + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS depends on GPIOLIB depends on OF depends on PINCTRL
Signature · 2 lines
Best Regards, Jacek Anaszewski
Quoted 26 lines · Jacek Anaszewski
Hi Randy,
Thanks for the patch.
Quoted 20 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
Fix build errors when LEDS_AAT1290=y and V4L2_FLASH_LED_CLASS=m by restricting
LEDS_AAT1290to =m if V4L2_FLASH_LED_CLASS=m.
drivers/built-in.o: In function `aat1290_led_remove':
leds-aat1290.c:(.text+0xe5d77): undefined reference to `v4l2_flash_release'drivers/built-in.o: In function `aat1290_led_probe':
leds-aat1290.c:(.text+0xe6494): undefined reference to `v4l2_flash_init'Signed-off-by Randy Dunlap <[email protected]>Cc Jacek Anaszewski <[email protected]>Cc Bryan Wu <[email protected]>Cc Richard Purdie <[email protected]>--- drivers/leds/Kconfig | 1 + 1 file changed, 1 insertion(+)
Quoted 14 lines
drivers/leds/Kconfig config LEDS_88PM860X · line 48
Quoted 11 lines
drivers/leds/Kconfig +1
-0@@ -42,6 +42,7 @@ config LEDS_88PM860X config LEDS_AAT1290 tristate "LED support for the AAT1290" depends on LEDS_CLASS_FLASH + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS depends on GPIOLIB depends on OF depends on PINCTRLAcked-by Jacek Anaszewski <[email protected]>
Good fix. thanks.
I merged into my tree.
-Bryan