remove now unnecessary gc from libxl__async_exec_start calls
PATCH v2 1/1 remove now unnecessary gc from libxl__async_exec_start calls
These were removed in commit f5f8400f.
--- tools/libxl/libxl_netbuffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/libxl/libxl_netbuffer.c +2 -2
@@ -310,7 +310,7 @@ static void nic_setup(libxl__egc *egc, libxl__remus_device *dev) }setup_async_exec (dev,"setup" ); - rc =libxl__async_exec_start (gc, &dev->aodev.aes); + rc =libxl__async_exec_start (&dev->aodev.aes);if (rc) goto out;
@@ -402,7 +402,7 @@ static void nic_teardown(libxl__egc *egc, libxl__remus_device *dev)setup_async_exec (dev,"teardown" ); - rc =libxl__async_exec_start (gc, &dev->aodev.aes); + rc =libxl__async_exec_start (&dev->aodev.aes);if (rc) goto out;
Signature · 1 line
2.4.3
Wen Congyang writes ("[PATCH v2] remove now unnecessary gc from libxl__async_exec_start calls"):
Quoted 1 line
These were removed in commit
f5f8400f.
And I have committed it (with `libxl:' added to the front of the Subject).
Thanks,
Ian.
Quoted 21 lines · Wen Congyang
These were removed in commit
f5f8400f.Signed-off-by Wen Congyang <[email protected]>--- tools/libxl/libxl_netbuffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/libxl/libxl_netbuffer.c +1
-1@@ -310,7 +310,7 @@ static void nic_setup(libxl__egc *egc, libxl__remus_device *dev) }setup_async_exec (dev,"setup" ); - rc =libxl__async_exec_start (gc, &dev->aodev.aes); + rc =libxl__async_exec_start (&dev->aodev.aes);if (rc) goto out;
tools/libxl/libxl_netbuffer.c static void nic_teardown(libxl__egc *egc, libxl__remus_device *dev) · line 408
Quoted 8 lines
tools/libxl/libxl_netbuffer.c +1
-1@@ -402,7 +402,7 @@ static void nic_teardown(libxl__egc *egc, libxl__remus_device *dev)setup_async_exec (dev,"teardown" ); - rc =libxl__async_exec_start (gc, &dev->aodev.aes); + rc =libxl__async_exec_start (&dev->aodev.aes);if (rc) goto out;
Can OSS test be updated to build the remus bits of libxl? This failure should not have been able to pass the push gate.
~Andrew
Andrew Cooper writes ("Re: [Xen-devel] [PATCH v2] remove now unnecessary gc from libxl__async_exec_start calls"):
Quoted 2 lines · Wen Congyang
Quoted 1 line
These were removed in commit
f5f8400f.
...
Quoted 5 lines
Review
Quoted 2 lines
(quoted diff) +1
-1- rc = libxl__async_exec_start(gc, &dev->aodev.aes); + rc = libxl__async_exec_start(&dev->aodev.aes);Can OSS test be updated to build the remus bits of libxl? This failure should not have been able to pass the push gate.
I haven't investigated why this is disabled in osstest's builds. Did you check one of its build logs ? They contain the `configure' output.
Ian.
Quoted 11 lines · Ian Jackson
Andrew Cooper writes ("Re: [Xen-devel] [PATCH v2] remove now unnecessary gc from
libxl__async_exec_startcalls"):Quoted 2 lines · Wen Congyang
Quoted 1 line
These were removed in commit
f5f8400f....
Quoted 5 lines
Review
Quoted 2 lines
(quoted diff) +1
-1- rc = libxl__async_exec_start(gc, &dev->aodev.aes); + rc = libxl__async_exec_start(&dev->aodev.aes);Can OSS test be updated to build the remus bits of libxl? This failure should not have been able to pass the push gate.
I haven't investigated why this is disabled in osstest's builds.
Roger was jsut asking about libnl-dev and ts-xen-build-prep on IRC. I suspect he may be investigating...
Quoted 2 lines
Did you check one of its build logs ? They contain the `configure' output.
Roger pointed at
http://logs.test-lab.xenproject.org/osstest/logs/58974/build-amd64/5.ts-xen-build.log
Which has:
Checking for LIBNL3... no
configure: WARNING: Disabling support for Remus network buffering.
Please install libnl3 libraries, command line tools and devel headers - version 3.2.8 or higher
But Wheezy has libnl-dev 1.1-7, which I think it might just be too old. It also has libnl-3-dev which is 3.2.7 in Wheezy, i.e. still not quite new enough.
Jessie has 3.2.24 which will be more than sufficient.
I think the upshot is that it is pointless installing libnl-dev on Wheezy, at least for current Xen maybe older branches worked with older libnl, I didn't check...
Ian.