drm/rockchip: fixes and new features

GIT PULL Mark yao 3 participants 10 messages Jun 30, 2015 – Jul 1, 2015 Arm Rockchip

lore

Share & tools

lore

Mark yao

author

2015-06-30 06:50 UTC #0 lore raw

Hi Dave.

Some fixes and some new features. I'd like you can pull them.

The following changes since commit c5fd936e992dd2829167d2adc63e151675ca6898:

drm/nouveau: Pause between setting gpu to D3hot and cutting the power
(2015-06-26 10:26:37 +1000)

are available in the git repository at:

https://github.com/markyzq/kernel-drm-rockchip.git
drm-rockchip-2015-06-30

for you to fetch changes up to 5295c05eb30d743987172853179333c80b8242bc:

drm/rockchip: default enable win2/3 area0 bit (2015-06-30 14:24:10 +0800)

----------------------------------------------------------------
Heiko Stübner (1):
drm/rockchip: only call drm_fb_helper_hotplug_event if fb_helper
present

Mark Yao (6):
drm/rockchip: import dma_buf to gem drm/rockchip: vop: optimize virtual stride calculate drm/rockchip: vop: fix yuv plane support drm/rockchip: vop: support plane scale drm/rockchip: vop: switch cursor plane to window 3 drm/rockchip: default enable win2/3 area0 bit

Tomasz Figa (1):
drm/rockchip: Add BGR formats to VOP

 drivers/gpu/drm/rockchip/rockchip_drm_drv.c |    1 +
 drivers/gpu/drm/rockchip/rockchip_drm_fb.c  |    3 +-
 drivers/gpu/drm/rockchip/rockchip_drm_gem.c |   40 ++-
 drivers/gpu/drm/rockchip/rockchip_drm_gem.h |    5 +-
 drivers/gpu/drm/rockchip/rockchip_drm_vop.c |  500 
++++++++++++++++++++++++++-
 drivers/gpu/drm/rockchip/rockchip_drm_vop.h |   96 +++++
 6 files changed, 628 insertions(+), 17 deletions(-)

Signature · 7 lines

Ｍark


_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Tomasz Figa

2015-07-01 08:03 UTC #1 lore raw

Hi Mark,

Quoted 21 lines · Mark yao

Hi Dave.
Some fixes and some new features. I'd like you can pull them.
The following changes since commit c5fd936e992dd2829167d2adc63e151675ca6898:
drm/nouveau: Pause between setting gpu to D3hot and cutting the power (2015-06-26 10:26:37 +1000)
are available in the git repository at:
https://github.com/markyzq/kernel-drm-rockchip.git drm-rockchip-2015-06-30
for you to fetch changes up to 5295c05eb30d743987172853179333c80b8242bc:
drm/rockchip: default enable win2/3 area0 bit (2015-06-30 14:24:10 +0800)
----------------------------------------------------------------
Heiko Stübner (1):
drm/rockchip: only call drm_fb_helper_hotplug_event if fb_helper present

Quoted 7 lines

Mark Yao (6):
drm/rockchip: import dma_buf to gem drm/rockchip: vop: optimize virtual stride calculate drm/rockchip: vop: fix yuv plane support drm/rockchip: vop: support plane scale drm/rockchip: vop: switch cursor plane to window 3 drm/rockchip: default enable win2/3 area0 bit

Has this series been reviewed properly? I can see that at least "drm/rockchip: vop: support plane scale" is kind of "controversial".

By the way, if we're using window 3 for cursor plane, because the cursor window needs special handling, is it okay to expose the cusor window as an overlay plane to userspace, as we do currently?

Best regards,
Tomasz
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Daniel Vetter

2015-07-01 08:18 UTC #2 lore raw

Quoted 32 lines · Tomasz Figa

Hi Mark,
Quoted 21 lines · Mark yao
Hi Dave.
Some fixes and some new features. I'd like you can pull them.
The following changes since commit c5fd936e992dd2829167d2adc63e151675ca6898:
drm/nouveau: Pause between setting gpu to D3hot and cutting the power (2015-06-26 10:26:37 +1000)
are available in the git repository at:
https://github.com/markyzq/kernel-drm-rockchip.git drm-rockchip-2015-06-30
for you to fetch changes up to 5295c05eb30d743987172853179333c80b8242bc:
drm/rockchip: default enable win2/3 area0 bit (2015-06-30 14:24:10 +0800)
----------------------------------------------------------------
Heiko Stübner (1):
drm/rockchip: only call drm_fb_helper_hotplug_event if fb_helper present
Quoted 7 lines
Mark Yao (6):
drm/rockchip: import dma_buf to gem drm/rockchip: vop: optimize virtual stride calculate drm/rockchip: vop: fix yuv plane support drm/rockchip: vop: support plane scale drm/rockchip: vop: switch cursor plane to window 3 drm/rockchip: default enable win2/3 area0 bit

Quoted 2 lines

Has this series been reviewed properly? I can see that at least "drm/rockchip: vop: support plane scale" is kind of "controversial".

I don't see any discussion of this patch at all on dri-devel, where's this controversy?
-Daniel

Signature · 7 lines

Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Tomasz Figa

2015-07-01 08:32 UTC #3 lore raw

Quoted 33 lines · Daniel Vetter

Quoted 32 lines · Tomasz Figa
Hi Mark,
Quoted 28 lines · Mark yao
Hi Dave.
Some fixes and some new features. I'd like you can pull them.
The following changes since commit c5fd936e992dd2829167d2adc63e151675ca6898:
drm/nouveau: Pause between setting gpu to D3hot and cutting the power (2015-06-26 10:26:37 +1000)
are available in the git repository at:
https://github.com/markyzq/kernel-drm-rockchip.git drm-rockchip-2015-06-30
for you to fetch changes up to 5295c05eb30d743987172853179333c80b8242bc:
drm/rockchip: default enable win2/3 area0 bit (2015-06-30 14:24:10 +0800)
----------------------------------------------------------------
Heiko Stübner (1):
drm/rockchip: only call drm_fb_helper_hotplug_event if fb_helper present
Mark Yao (6):
drm/rockchip: import dma_buf to gem drm/rockchip: vop: optimize virtual stride calculate drm/rockchip: vop: fix yuv plane support drm/rockchip: vop: support plane scale drm/rockchip: vop: switch cursor plane to window 3 drm/rockchip: default enable win2/3 area0 bit

Quoted 5 lines

Quoted 2 lines
Has this series been reviewed properly? I can see that at least "drm/rockchip: vop: support plane scale" is kind of "controversial".
I don't see any discussion of this patch at all on dri-devel, where's this controversy?

Well, it adds a lot of seemingly complex, hard to read code with obvious style issues. I'll review the series later this week.

Best regards,
Tomasz
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Mark yao

author

2015-07-01 08:56 UTC #4 lore raw

Quoted 34 lines · Tomasz Figa

Quoted 33 lines · Daniel Vetter
Quoted 32 lines · Tomasz Figa
Hi Mark,
Quoted 20 lines · Mark yao
Hi Dave.
Some fixes and some new features. I'd like you can pull them.
The following changes since commit c5fd936e992dd2829167d2adc63e151675ca6898:
drm/nouveau: Pause between setting gpu to D3hot and cutting the power (2015-06-26 10:26:37 +1000)
are available in the git repository at:
   https://github.com/markyzq/kernel-drm-rockchip.git drm-rockchip-2015-06-30
for you to fetch changes up to 5295c05eb30d743987172853179333c80b8242bc:
   drm/rockchip: default enable win2/3 area0 bit (2015-06-30 14:24:10 +0800)
----------------------------------------------------------------
Heiko Stübner (1):
drm/rockchip: only call drm_fb_helper_hotplug_event if fb_helper present
Quoted 7 lines
Mark Yao (6):
drm/rockchip: import dma_buf to gem drm/rockchip: vop: optimize virtual stride calculate drm/rockchip: vop: fix yuv plane support drm/rockchip: vop: support plane scale drm/rockchip: vop: switch cursor plane to window 3 drm/rockchip: default enable win2/3 area0 bit
Has this series been reviewed properly? I can see that at least "drm/rockchip: vop: support plane scale" is kind of "controversial".

Quoted 9 lines

Quoted 2 lines
I don't see any discussion of this patch at all on dri-devel, where's this controversy?
Well, it adds a lot of seemingly complex, hard to read code with obvious style issues. I'll review the series later this week.
Best regards,
Tomasz

Hi Tomasz

    Thanks, those compute code you can found from RK3288 TRM->"27.3.3

Win Scaling", too complex.
I had do some clean for the code, but for full function and little bug, hard to cleanup.

Best regards,

Signature · 7 lines

Ｍark


_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Mark yao

author

2015-07-01 08:32 UTC #5 lore raw

In reply to Tomasz Figa

Quoted 30 lines · Tomasz Figa

Hi Mark,
Quoted 20 lines · Mark yao
Hi Dave.
Some fixes and some new features. I'd like you can pull them.
The following changes since commit c5fd936e992dd2829167d2adc63e151675ca6898:
drm/nouveau: Pause between setting gpu to D3hot and cutting the power (2015-06-26 10:26:37 +1000)
are available in the git repository at:
   https://github.com/markyzq/kernel-drm-rockchip.git drm-rockchip-2015-06-30
for you to fetch changes up to 5295c05eb30d743987172853179333c80b8242bc:
   drm/rockchip: default enable win2/3 area0 bit (2015-06-30 14:24:10 +0800)
----------------------------------------------------------------
Heiko Stübner (1):
drm/rockchip: only call drm_fb_helper_hotplug_event if fb_helper present
Quoted 7 lines
Mark Yao (6):
drm/rockchip: import dma_buf to gem drm/rockchip: vop: optimize virtual stride calculate drm/rockchip: vop: fix yuv plane support drm/rockchip: vop: support plane scale drm/rockchip: vop: switch cursor plane to window 3 drm/rockchip: default enable win2/3 area0 bit

Quoted 2 lines

Has this series been reviewed properly? I can see that at least "drm/rockchip: vop: support plane scale" is kind of "controversial".

Sorry for that, can you review those patches, and give me some advices?

https://lkml.org/lkml/2015/6/18/77
v2: https://lkml.org/lkml/2015/6/26/192

Quoted 3 lines

By the way, if we're using window 3 for cursor plane, because the cursor window needs special handling, is it okay to expose the cusor window as an overlay plane to userspace, as we do currently?

special handling? what means? "switch cursor plane to window 3" patch only switch cursor
windows from win1 to win3. tag window 3 as DRM_PLANE_TYPE_CURSOR,
userspace only
can found window 3 is a cursor plane.

Quoted 6 lines

Best regards,
Tomasz

Best regards,
Ｍark

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Tomasz Figa

2015-07-01 08:42 UTC #6 lore raw

Quoted 39 lines · Mark yao

Quoted 38 lines · Tomasz Figa
Hi Mark,
Quoted 33 lines · Mark yao
Hi Dave.
Some fixes and some new features. I'd like you can pull them.
The following changes since commit
c5fd936e992dd2829167d2adc63e151675ca6898:
drm/nouveau: Pause between setting gpu to D3hot and cutting the power
(2015-06-26 10:26:37 +1000)
are available in the git repository at:
https://github.com/markyzq/kernel-drm-rockchip.git
drm-rockchip-2015-06-30
for you to fetch changes up to 5295c05eb30d743987172853179333c80b8242bc:
   drm/rockchip: default enable win2/3 area0 bit (2015-06-30 14:24:10
+0800)
----------------------------------------------------------------
Heiko Stübner (1):
drm/rockchip: only call drm_fb_helper_hotplug_event if fb_helper
present
Mark Yao (6):
drm/rockchip: import dma_buf to gem drm/rockchip: vop: optimize virtual stride calculate drm/rockchip: vop: fix yuv plane support drm/rockchip: vop: support plane scale drm/rockchip: vop: switch cursor plane to window 3 drm/rockchip: default enable win2/3 area0 bit

Quoted 9 lines

Quoted 2 lines
Has this series been reviewed properly? I can see that at least "drm/rockchip: vop: support plane scale" is kind of "controversial".
Sorry for that, can you review those patches, and give me some advices?
https://lkml.org/lkml/2015/6/18/77
v2: https://lkml.org/lkml/2015/6/26/192

Yes, will do that.

By the way, please feel free to ping patches on the lists if they idle without any comments or tags for while.

Quoted 11 lines

Quoted 3 lines
By the way, if we're using window 3 for cursor plane, because the cursor window needs special handling, is it okay to expose the cusor window as an overlay plane to userspace, as we do currently?
special handling? what means? "switch cursor plane to window 3" patch only switch cursor
windows from win1 to win3. tag window 3 as DRM_PLANE_TYPE_CURSOR, userspace
only
can found window 3 is a cursor plane.

Ah, this was a question slightly unrelated to that patch, but I just noticed in that patch that the hardware cursor window is still exposed to the userspace as overlay plane, even if it's not quite suitable for being such.

Best regards,
Tomasz
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Mark yao

author

2015-07-01 09:13 UTC #7 lore raw

Quoted 60 lines · Tomasz Figa

Quoted 36 lines · Mark yao
Quoted 35 lines · Tomasz Figa
Hi Mark,
Quoted 32 lines · Mark yao
Hi Dave.
Some fixes and some new features. I'd like you can pull them.
The following changes since commit
c5fd936e992dd2829167d2adc63e151675ca6898:
drm/nouveau: Pause between setting gpu to D3hot and cutting the power
(2015-06-26 10:26:37 +1000)
are available in the git repository at:
https://github.com/markyzq/kernel-drm-rockchip.git
drm-rockchip-2015-06-30
for you to fetch changes up to 5295c05eb30d743987172853179333c80b8242bc:
    drm/rockchip: default enable win2/3 area0 bit (2015-06-30 14:24:10
+0800)
----------------------------------------------------------------
Heiko Stübner (1):
drm/rockchip: only call drm_fb_helper_hotplug_event if fb_helper
present
Mark Yao (6):
drm/rockchip: import dma_buf to gem drm/rockchip: vop: optimize virtual stride calculate drm/rockchip: vop: fix yuv plane support drm/rockchip: vop: support plane scale drm/rockchip: vop: switch cursor plane to window 3 drm/rockchip: default enable win2/3 area0 bit
Quoted 8 lines
Quoted 2 lines
Has this series been reviewed properly? I can see that at least "drm/rockchip: vop: support plane scale" is kind of "controversial".
Sorry for that, can you review those patches, and give me some advices?
https://lkml.org/lkml/2015/6/18/77
v2: https://lkml.org/lkml/2015/6/26/192
Yes, will do that.
By the way, please feel free to ping patches on the lists if they idle without any comments or tags for while.
Quoted 10 lines
Quoted 3 lines
By the way, if we're using window 3 for cursor plane, because the cursor window needs special handling, is it okay to expose the cusor window as an overlay plane to userspace, as we do currently?
special handling? what means? "switch cursor plane to window 3" patch only switch cursor
windows from win1 to win3. tag window 3 as DRM_PLANE_TYPE_CURSOR, userspace
only
can found window 3 is a cursor plane.

Quoted 4 lines

Ah, this was a question slightly unrelated to that patch, but I just noticed in that patch that the hardware cursor window is still exposed to the userspace as overlay plane, even if it's not quite suitable for being such.

Oh, I know your mean, you mean that code:

        { .base = 0x00, .phy = &cursor_data, .type =

DRM_PLANE_TYPE_OVERLAY },

right?

That is I plan to do.

hardware cursor window have a problem that hard to resolved. the window can't support width virtual and can't move out of left top top. But linux desktop or chromiumos should move cursor out of left or top.

I'm considering remove it or find a another way to reuse it.

Quoted 5 lines

Best regards,
Tomasz

Signature · 7 lines

Ｍark


_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Tomasz Figa

2015-07-01 09:17 UTC #8 lore raw

Quoted 25 lines · Mark yao

Quoted 13 lines
Quoted 5 lines
Quoted 3 lines
By the way, if we're using window 3 for cursor plane, because the cursor window needs special handling, is it okay to expose the cusor window as an overlay plane to userspace, as we do currently?
Quoted 8 lines
special handling? what means? "switch cursor plane to window 3" patch only
switch cursor
windows from win1 to win3. tag window 3 as DRM_PLANE_TYPE_CURSOR,
userspace
only
can found window 3 is a cursor plane.
Quoted 4 lines
Ah, this was a question slightly unrelated to that patch, but I just noticed in that patch that the hardware cursor window is still exposed to the userspace as overlay plane, even if it's not quite suitable for being such.
Oh, I know your mean, you mean that code:
        { .base = 0x00, .phy = &cursor_data, .type = DRM_PLANE_TYPE_OVERLAY
},
right?

Quoted 7 lines

That is I plan to do.
hardware cursor window have a problem that hard to resolved. the window can't support width virtual and can't move out of left top top. But linux desktop or chromiumos should move cursor out of left or top.
I'm considering remove it or find a another way to reuse it.

I think we should remove it for now, because I believe this breaks applications that enumerate all available planes and use them for hardware compose. Otherwise they will try to use the hardware cursor window and will fail, because hardware cursor window has quite strict requirements.

Best regards,
Tomasz
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Mark yao

author

2015-07-01 08:43 UTC #9 lore raw

In reply to Mark yao

Quoted 43 lines · Mark yao

Quoted 34 lines · Tomasz Figa
Hi Mark,
Quoted 24 lines · Mark yao
Hi Dave.
Some fixes and some new features. I'd like you can pull them.
The following changes since commit c5fd936e992dd2829167d2adc63e151675ca6898:
drm/nouveau: Pause between setting gpu to D3hot and cutting the
power (2015-06-26 10:26:37 +1000)
are available in the git repository at:
https://github.com/markyzq/kernel-drm-rockchip.git
drm-rockchip-2015-06-30
for you to fetch changes up to 5295c05eb30d743987172853179333c80b8242bc:
   drm/rockchip: default enable win2/3 area0 bit (2015-06-30 
14:24:10 +0800)
----------------------------------------------------------------
Heiko Stübner (1):
drm/rockchip: only call drm_fb_helper_hotplug_event if
fb_helper present
Quoted 7 lines
Mark Yao (6):
drm/rockchip: import dma_buf to gem drm/rockchip: vop: optimize virtual stride calculate drm/rockchip: vop: fix yuv plane support drm/rockchip: vop: support plane scale drm/rockchip: vop: switch cursor plane to window 3 drm/rockchip: default enable win2/3 area0 bit
Quoted 2 lines
Has this series been reviewed properly? I can see that at least "drm/rockchip: vop: support plane scale" is kind of "controversial".
Sorry for that, can you review those patches, and give me some advices?
https://lkml.org/lkml/2015/6/18/77
v2: https://lkml.org/lkml/2015/6/26/192

Quoted 8 lines

Quoted 3 lines
By the way, if we're using window 3 for cursor plane, because the cursor window needs special handling, is it okay to expose the cusor window as an overlay plane to userspace, as we do currently?
special handling? what means? "switch cursor plane to window 3" patch only switch cursor
windows from win1 to win3. tag window 3 as DRM_PLANE_TYPE_CURSOR,
userspace only
can found window 3 is a cursor plane.

switch cursor win1 to win3 because we want to use win1 as a overlay for yuv image, win3 not support yuv format. not for special handling.

By the way, win3 power power consume less than win1, cursor use win3 would save power.

Quoted 15 lines

Quoted 7 lines
Best regards,
Tomasz
Best regards,
Ｍark
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Signature · 7 lines

Ｍark


_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel