Staging: android: fix coding style and TODO file
PATCH 1/1 Staging: android: fix coding style and TODO file
- removed non-existant issue from TODO filekuid_t or uid_t not present in staging/android
- fixed 80 char limit exceeding line
- a newline after decelartions as per checkpatch.pl
- fixed an unnecessary typedef as reported by checkpatch.pl
--- drivers/staging/android/TODO | 7 ------- drivers/staging/android/ion/ion.c | 1 + drivers/staging/android/ion/ion_chunk_heap.c | 4 ++-- drivers/staging/android/uapi/ion.h | 7 +++---- 4 files changed, 6 insertions(+), 13 deletions(-)
drivers/staging/android/TODO +0 -7
@@ -5,13 +5,6 @@ TODO: - make sure things build as modules properly - add proper arch dependencies as needed - audit userspace interfaces to make sure they are sane - - kuid_t should never be exposed to user space as it is - kernel internal type. Data structure for this kuid_t is: - typedef struct { - uid_t val; - } kuid_t; - - This bug is introduced by Xiong Zhou in the patch bd471258f2e09 - - ("staging: android: logger: use kuid_t instead of uid_t") Please send patches to Greg Kroah-Hartman <[email protected]> and Cc: Brian Swetland <[email protected]>
drivers/staging/android/ion/ion.c +1 -0
@@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,struct ion_buffer *buffer;struct dma_buf *dmabuf;bool valid_handle; +DEFINE_DMA_BUF_EXPORT_INFO (exp_info);mutex_lock (&client->lock);
drivers/staging/android/ion/ion_chunk_heap.c +2 -2
@@ -173,8 +173,8 @@ struct ion_heap *ion_chunk_heap_create(struct ion_platform_heap *heap_data) chunk_heap->heap.ops = &chunk_heap_ops; chunk_heap->heap.type =ION_HEAP_TYPE_CHUNK ; chunk_heap->heap.flags =ION_HEAP_FLAG_DEFER_FREE ; -pr_debug ("%s: base %lu size %zu align %ld\n" , __func__, chunk_heap->base, - heap_data->size, heap_data->align); +pr_debug ("%s: base %lu size %zu align %ld\n" , __func__, + chunk_heap->base, heap_data->size, heap_data->align);return &chunk_heap->heap;
drivers/staging/android/uapi/ion.h +3 -4
@@ -20,7 +20,6 @@#include <linux/ioctl.h> #include <linux/types.h> -typedef int ion_user_handle_t ;/** * enum ion_heap_types - list of all possible types of heaps
@@ -88,7 +87,7 @@ struct ion_allocation_data {size_t align;unsigned int heap_id_mask;unsigned int flags; -ion_user_handle_t handle; +int handle; };/**
@@ -102,7 +101,7 @@ struct ion_allocation_data {* provides the file descriptor and the kernel returns the handle. */ struct ion_fd_data { -ion_user_handle_t handle; +int handle;int fd; };
@@ -111,7 +110,7 @@ struct ion_fd_data {* @handle: a handle */ struct ion_handle_data { -ion_user_handle_t handle; +int handle; };/**
Quoted 1 line · Sohny Thomas
- removed non-existant issue from TODO file
s,existant,existent,
Quoted 4 lines
kuid_toruid_tnot present in staging/android
- fixed 80 char limit exceeding line
- a newline after decelartions as per checkpatch.pl
- fixed an unnecessary typedef as reported by checkpatch.pl
Fix one issue per patch, please.
Thanks,
Frans
Quoted 11 lines · Frans Klaver
Quoted 1 line · Sohny Thomas
- removed non-existant issue from TODO file
s,existant,existent,
Quoted 4 lines
kuid_toruid_tnot present in staging/android
- fixed 80 char limit exceeding line
- a newline after decelartions as per checkpatch.pl
- fixed an unnecessary typedef as reported by checkpatch.plFix one issue per patch, please.
And Signed-off-by is missing.
regards
sudip
Quoted 4 lines · Frans Klaver
Quoted 1 line · Sohny Thomas
- removed non-existant issue from TODO file
s,existant,existent,
Thanks missed that
Quoted 7 lines
Quoted 5 lines
kuid_toruid_tnot present in staging/android
- fixed 80 char limit exceeding line
- a newline after decelartions as per checkpatch.pl
- fixed an unnecessary typedef as reported by checkpatch.plFix one issue per patch, please.
Since these were all simple Fixes of about 1/2 lines , I thought to make a single patch.
Quoted 4 lines
Thanks,
Frans
Quoted 9 lines · Sohny Thomas
Quoted 4 lines · Frans Klaver
Quoted 1 line · Sohny Thomas
- removed non-existant issue from TODO file
s,existant,existent,
Thanks missed that
Quoted 1 line
Quoted 7 lines
Quoted 6 lines
Quoted 4 lines
kuid_toruid_tnot present in staging/android
- fixed 80 char limit exceeding line
- a newline after decelartions as per checkpatch.pl
- fixed an unnecessary typedef as reported by checkpatch.plFix one issue per patch, please.
Since these were all simple Fixes of about 1/2 lines , I thought to make a single patch.
They are simple fixes, but a reviewer still has to figure out what comment belongs to which code change. Since there's no reason for these changes to be atomic, you might as well split them up to make reviewing easier.
Frans
Quoted 15 lines · Frans Klaver
Quoted 14 lines · Sohny Thomas
Quoted 4 lines · Frans Klaver
Quoted 1 line · Sohny Thomas
- removed non-existant issue from TODO file
s,existant,existent,
Thanks missed that
Quoted 6 lines
Quoted 5 lines
kuid_toruid_tnot present in staging/android
- fixed 80 char limit exceeding line
- a newline after decelartions as per checkpatch.pl
- fixed an unnecessary typedef as reported by checkpatch.pl
Quoted 8 lines
Quoted 2 lines
Quoted 1 line
Fix one issue per patch, please.
Since these were all simple Fixes of about 1/2 lines , I thought to make a single patch.
They are simple fixes, but a reviewer still has to figure out what comment belongs to which code change. Since there's no reason for these changes to be atomic, you might as well split them up to make reviewing easier.
Yeap, V2 coming with changes and fixes Sudip's catch too. Thanks for your time.
-Sohny
Quoted 7 lines
Frans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/