Skip to contentSkip to conversation

macb: zynq: why is SG disabled?

DISCUSSION Nicolae Rosia 4 participants 4 messages Jul 1, 2015 – Jul 2, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hello,

After reading the GEM part of Zynq7000 Technical Reference Manual [0], I think that SG should be supported. Is there a reason why SG is disabled in macb for Zynq?

Best regards,
Nicolae Rosia

#1 lore raw

Le 01/07/2015 17:14, Nicolae Rosia a ?crit :

Quoted 7 lines

Hello,

After reading the GEM part of Zynq7000 Technical Reference Manual [0], I think that SG should be supported. Is there a reason why SG is disabled in macb for Zynq?

Best regards,
Nicolae Rosia

Hi Nicolae,

when the scatter-gather patch was introduced, the feature was enabled only on tested boards to avoid regressions on other boards.
So SG is enabled on sama5d4x and sama5d2x SoCs. SG is disabled on purpose on sama5d3x.

For Zynq, I think the feature is still disabled just because it has never been tested.

Best regards,

Cyrille

#2 lore raw

Hi Nicolae and Cyrille,

SG feature was not tested for Zynq using macb driver but tested it using the
emacps Driver in Xilinx tree (this driver is deprecated recently)

We will test and enable this feature in driver for Zynq.

Regards,
Punnaiah

Quoted 30 lines

-----Original Message-----
From: Cyrille Pitchen [mailto:cyrille.pitchen at atmel.com]
Sent: Wednesday, July 01, 2015 10:34 PM
To: Nicolae Rosia; Michal Simek; Punnaiah Choudary Kalluri;
netdev at vger.kernel.org; Nicolas Ferre; linux-arm-kernel at lists.infradead.org
Subject: Re: macb: zynq: why is SG disabled?

Le 01/07/2015 17:14, Nicolae Rosia a ?crit :

Quoted 3 lines

Hello,

After reading the GEM part of Zynq7000 Technical Reference Manual [0], I

think that SG should be supported.

Quoted 4 lines

Is there a reason why SG is disabled in macb for Zynq?

Best regards,
Nicolae Rosia

Hi Nicolae,

when the scatter-gather patch was introduced, the feature was enabled only on tested boards to avoid regressions on other boards.
So SG is enabled on sama5d4x and sama5d2x SoCs. SG is disabled on purpose on sama5d3x.

For Zynq, I think the feature is still disabled just because it has never been tested.

Best regards,

Cyrille

#3 lore raw

Le 02/07/2015 04:33, Punnaiah Choudary Kalluri a ?crit :

Quoted 6 lines

Hi Nicolae and Cyrille,

SG feature was not tested for Zynq using macb driver but tested it using the
emacps Driver in Xilinx tree (this driver is deprecated recently)

We will test and enable this feature in driver for Zynq.

Ok, fine: we will be glad to merge patches that would enable this feature on Zynq.

Bye,

Quoted 31 lines
Quoted 30 lines

-----Original Message-----
From: Cyrille Pitchen [mailto:cyrille.pitchen at atmel.com]
Sent: Wednesday, July 01, 2015 10:34 PM
To: Nicolae Rosia; Michal Simek; Punnaiah Choudary Kalluri;
netdev at vger.kernel.org; Nicolas Ferre; linux-arm-kernel at lists.infradead.org
Subject: Re: macb: zynq: why is SG disabled?

Le 01/07/2015 17:14, Nicolae Rosia a ?crit :

Quoted 3 lines

Hello,

After reading the GEM part of Zynq7000 Technical Reference Manual [0], I

think that SG should be supported.

Quoted 4 lines

Is there a reason why SG is disabled in macb for Zynq?

Best regards,
Nicolae Rosia

Hi Nicolae,

when the scatter-gather patch was introduced, the feature was enabled only on tested boards to avoid regressions on other boards.
So SG is enabled on sama5d4x and sama5d2x SoCs. SG is disabled on purpose on sama5d3x.

For Zynq, I think the feature is still disabled just because it has never been tested.

Best regards,

Cyrille

Signature · 1 line
Nicolas Ferre