Skip to contentSkip to conversation

gpio: msm: Remove empty msm_gpio_{request,free}()

PATCH New Geert Uytterhoeven 2 participants 2 messages Jul 1, 2015

Subsystems (2)
Arm Qualcomm mailing list GPIO
lore
Share & tools
lore

Geert Uytterhoeven

author
#0 lore raw

PATCH 1/1 gpio: msm: Remove empty msm_gpio_{request,free}()

gpio_chip.request() and gpio_chip.free() are optional, and can just be left unimplemented.

Signed-off-by Geert Uytterhoeven <[email protected]>

---
Untested due to lack of hardware.

---
 drivers/gpio/gpio-msm-v2.c | 12 ------------
 1 file changed, 12 deletions(-)
drivers/gpio/gpio-msm-v2.c +0 -12
index 52ff18229fdc874a..d9ea0c8e5f0aa82d 100644
@@ -169,16 +169,6 @@ static int msm_gpio_direction_output(struct gpio_chip *chip,
 	return 0;
 }
 
-static int msm_gpio_request(struct gpio_chip *chip, unsigned offset)
-{
-	return 0;
-}
-
-static void msm_gpio_free(struct gpio_chip *chip, unsigned offset)
-{
-	return;
-}
-
 static int msm_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
 {
 	struct msm_gpio_dev *g_dev = to_msm_gpio_dev(chip);

@@ -404,8 +394,6 @@ static int msm_gpio_probe(struct platform_device *pdev)
 	msm_gpio.gpio_chip.get = msm_gpio_get;
 	msm_gpio.gpio_chip.set = msm_gpio_set;
 	msm_gpio.gpio_chip.to_irq = msm_gpio_to_irq;
-	msm_gpio.gpio_chip.request = msm_gpio_request;
-	msm_gpio.gpio_chip.free = msm_gpio_free;
 
 	ret = gpiochip_add(&msm_gpio.gpio_chip);
 	if (ret < 0) {
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 gpio: msm: Remove empty msm_gpio_{request,free}()

Quoted 6 lines · Geert Uytterhoeven

gpio_chip.request() and gpio_chip.free() are optional, and can just be left unimplemented.

Signed-off-by Geert Uytterhoeven <[email protected]>

---
Untested due to lack of hardware.

Actually we should just delete this driver now that we have an msm8660 pinctrl implementation.

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project