sunxi:Added Mele i7 eMMC MOD DTS
PATCH 2/3 sunxi:Added Mele i7 eMMC MOD DTS
PATCH 2/3 sunxi:Added Mele i7 eMMC MOD DTS
Hi,
Quoted 16 lines · ???????
From
83aa308eb836b0a63f0e30bd10d72040151a1e98Mon Sep 17 00:00:00 2001
From: Zhi Yuan Wan <[email protected]>
Date: Thu, 25 Jun 2015 20:00:46 +0800
Subject: [PATCH 2/3] sunxi:Added Mele i7 eMMC MOD DTSSigned-off-by Zhi Yuan Wan <[email protected]>--- arch/arm/dts/sun6i-a31-i7.dts | 10 ++++++++++ configs/Mele_I7_defconfig | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-)arch/arm/dts/sun6i-a31-i7.dts +0
-0
arch/arm/dts/sun6i-a31-i7.dts line 57
Quoted 7 lines
arch/arm/dts/sun6i-a31-i7.dts +1
-0@@ -51,6 +51,7 @@ model = "Mele I7 Quad top set box"; compatible = "mele,i7", "allwinner,sun6i-a31"; + aliases { serial0 = &uart0; };
Whitespace only change, please drop this bit.
Quoted 6 lines
arch/arm/dts/sun6i-a31-i7.dts +2
-0@@ -107,6 +108,15 @@ status = "okay"; }; +&mmc2 { + pinctrl-names = "default";
arch/arm/dts/sun6i-a31-i7.dts line 122
Quoted 10 lines
arch/arm/dts/sun6i-a31-i7.dts +7
-0+ pinctrl-0 = <&mmc2_pins_a>; + vmmc-supply = <®_vcc3v3>; + bus-width = <4>; + non-removable; + status = "okay"; +}; + &pio { led_pins_i7: led_pins at 0 { allwinner,pins = "PH13";
This bit looks good, but please submit dts file patches to the upstream linux kernel first, using the standard kernel patch submission process.
Also as said before if your I7 version has an eMMC, please add a new dts file for this titled: arch/arm/dts/sun6i-a31-mele-i7-emmc.dts .
Please submit this new file upstream.
configs/Mele_I7_defconfig line 7
Quoted 13 lines
configs/Mele_I7_defconfig +1
-1@@ -1,7 +1,7 @@ CONFIG_ARM=y CONFIG_ARCH_SUNXI=y CONFIG_MACH_SUN6I=y -CONFIG_DRAM_ZQ=120 +CONFIG_DRAM_ZQ=251 CONFIG_USB1_VBUS_PIN="PC27" CONFIG_USB2_VBUS_PIN="" CONFIG_DEFAULT_DEVICE_TREE="sun6i-a31-i7"
This change is completely unrelated to the emmc changes, please submit this as a separate patch. Please also explain why you are making this change, where does the 251 value come from ?
Regards,
Hans
PATCH 2/3 sunxi:Added Mele i7 eMMC MOD DTS
Quoted 52 lines · Hans de Goede
Hi,
Quoted 17 lines · ???????
From
83aa308eb836b0a63f0e30bd10d72040151a1e98Mon Sep 17 00:00:00 2001
From: Zhi Yuan Wan <[email protected]>
Date: Thu, 25 Jun 2015 20:00:46 +0800
Subject: [PATCH 2/3] sunxi:Added Mele i7 eMMC MOD DTSSigned-off-by Zhi Yuan Wan <[email protected]>--- arch/arm/dts/sun6i-a31-i7.dts | 10 ++++++++++ configs/Mele_I7_defconfig | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-)arch/arm/dts/sun6i-a31-i7.dts +0
-0arch/arm/dts/sun6i-a31-i7.dts line 57
Quoted 7 lines
arch/arm/dts/sun6i-a31-i7.dts +1
-0@@ -51,6 +51,7 @@ model = "Mele I7 Quad top set box"; compatible = "mele,i7", "allwinner,sun6i-a31"; + aliases { serial0 = &uart0; };Whitespace only change, please drop this bit.
Quoted 6 lines
arch/arm/dts/sun6i-a31-i7.dts +2
-0@@ -107,6 +108,15 @@ status = "okay"; }; +&mmc2 { + pinctrl-names = "default";arch/arm/dts/sun6i-a31-i7.dts line 122
Quoted 10 lines
arch/arm/dts/sun6i-a31-i7.dts +7
-0+ pinctrl-0 = <&mmc2_pins_a>; + vmmc-supply = <®_vcc3v3>; + bus-width = <4>; + non-removable; + status = "okay"; +}; + &pio { led_pins_i7: led_pins at 0 { allwinner,pins = "PH13";This bit looks good, but please submit dts file patches to the upstream linux kernel first, using the standard kernel patch submission process.
Quoted 2 lines
Also as said before if your I7 version has an eMMC, please add a new dts file for this titled:
arch/arm/dts/sun6i-a31-mele-i7-emmc.dts.
AFAIK this is an after market mod. See:
http://linux-sunxi.org/Replace_NAND_with_eMMC_howto
Quoted 29 lines
Please submit this new file upstream.
configs/Mele_I7_defconfig line 7
Quoted 13 lines
configs/Mele_I7_defconfig +1
-1@@ -1,7 +1,7 @@ CONFIG_ARM=y CONFIG_ARCH_SUNXI=y CONFIG_MACH_SUN6I=y -CONFIG_DRAM_ZQ=120 +CONFIG_DRAM_ZQ=251 CONFIG_USB1_VBUS_PIN="PC27" CONFIG_USB2_VBUS_PIN="" CONFIG_DEFAULT_DEVICE_TREE="sun6i-a31-i7"This change is completely unrelated to the emmc changes, please submit this as a separate patch. Please also explain why you are making this change, where does the 251 value come from ?
Regards,
Hans
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
PATCH 2/3 sunxi:Added Mele i7 eMMC MOD DTS
Quoted 53 lines · Chen-Yu Tsai
Quoted 52 lines · Hans de Goede
Hi,
Quoted 17 lines · ???????
From
83aa308eb836b0a63f0e30bd10d72040151a1e98Mon Sep 17 00:00:00 2001
From: Zhi Yuan Wan <[email protected]>
Date: Thu, 25 Jun 2015 20:00:46 +0800
Subject: [PATCH 2/3] sunxi:Added Mele i7 eMMC MOD DTSSigned-off-by Zhi Yuan Wan <[email protected]>--- arch/arm/dts/sun6i-a31-i7.dts | 10 ++++++++++ configs/Mele_I7_defconfig | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-)arch/arm/dts/sun6i-a31-i7.dts +0
-0arch/arm/dts/sun6i-a31-i7.dts line 57
Quoted 7 lines
arch/arm/dts/sun6i-a31-i7.dts +1
-0@@ -51,6 +51,7 @@ model = "Mele I7 Quad top set box"; compatible = "mele,i7", "allwinner,sun6i-a31"; + aliases { serial0 = &uart0; };Whitespace only change, please drop this bit.
Quoted 6 lines
arch/arm/dts/sun6i-a31-i7.dts +2
-0@@ -107,6 +108,15 @@ status = "okay"; }; +&mmc2 { + pinctrl-names = "default";arch/arm/dts/sun6i-a31-i7.dts line 122
Quoted 10 lines
arch/arm/dts/sun6i-a31-i7.dts +7
-0+ pinctrl-0 = <&mmc2_pins_a>; + vmmc-supply = <®_vcc3v3>; + bus-width = <4>; + non-removable; + status = "okay"; +}; + &pio { led_pins_i7: led_pins at 0 { allwinner,pins = "PH13";This bit looks good, but please submit dts file patches to the upstream linux kernel first, using the standard kernel patch submission process.
Quoted 6 lines
Quoted 2 lines
Also as said before if your I7 version has an eMMC, please add a new dts file for this titled:
arch/arm/dts/sun6i-a31-mele-i7-emmc.dts.AFAIK this is an after market mod. See:
I don't think we want to carry this kind of hacks in-tree. If you're willing to do that to your hardware, you can carry your own patch against a DT, especially since you'll have to modify it to enable the eMMC even it was merged.
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150706/0c0c525d/attachment.sig>