amba: Support clk parents and rates assigned in DT
Subsystems (2)
PATCH 1/1 amba: Support clk parents and rates assigned in DT
Add the call to of_clk_set_defaults() into the amba probe path so that devices on the amba bus can use the assigned rates and parents feature of the common clock framework.
---
Russell,
Can you please ack this change? We're going to send it through the clk tree because hisi clock requires it.
Thanks,
Stephen
drivers/amba/bus.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/amba/bus.c +5 -0
@@ -19,6 +19,7 @@#include <linux/amba/bus.h> #include <linux/sizes.h> #include <linux/limits.h> +#include <linux/clk/clk-conf.h> #include <asm/irq.h>
@@ -237,6 +238,10 @@ static int amba_probe(struct device *dev)int ret; do { + ret = of_clk_set_defaults(dev->of_node, false); + if (ret < 0) + break; + ret = dev_pm_domain_attach(dev, true); if (ret == -EPROBE_DEFER) break;
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 6 lines · Stephen Boyd
Add the call to
of_clk_set_defaults()into the amba probe path so that devices on the amba bus can use the assigned rates and parents feature of the common clock framework.Signed-off-by Stephen Boyd <[email protected]>---
Shall I put this into the patch tracker? Turns out it wasn't needed for the hisi stuff immediately.
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
Hi Russell,
Could you spend several minutes to review Stephen's patch?
Thanks,
Bintian
Quoted 11 lines · Stephen Boyd
Quoted 6 lines · Stephen Boyd
Add the call to
of_clk_set_defaults()into the amba probe path so that devices on the amba bus can use the assigned rates and parents feature of the common clock framework.Signed-off-by Stephen Boyd <[email protected]>---
Shall I put this into the patch tracker? Turns out it wasn't needed for the hisi stuff immediately.
Quoted 3 lines · Bintian
Hi Russell,
Could you spend several minutes to review Stephen's patch?
Sorry, I'm busy this week, I need to sort out my git tree, get some fixes out which should've been pushed during the merge window, and other stuff. I'm not going to have much time to read email, let alone do reviews. Please be patient.
Signature · 2 lines
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.
Quoted 10 lines · Russell King - ARM Linux
Quoted 3 lines · Bintian
Hi Russell,
Could you spend several minutes to review Stephen's patch?
Sorry, I'm busy this week, I need to sort out my git tree, get some fixes out which should've been pushed during the merge window, and other stuff. I'm not going to have much time to read email, let alone do reviews. Please be patient.
No problem, just keep your own pace.
Thanks,
Bintian