getrandom compilation broken in RHEL5.11GA

From: "Xiaoguang Wang" <[email protected]>
To: "Jan Stancek" <[email protected]>, "ced hnyda" <[email protected]>
Cc: "LTP" <[email protected]>
Sent: Tuesday, 7 July, 2015 12:43:59 PM
Subject: getrandom compilation broken in RHEL5.11GA

hello Jan, Cedric,

When I compile ltp in RHEL5.11GA, I run into these errors:
-----------------------------------------------------------------------------------------------------------
[root@RHEL5U11ga_Intel64 getrandom]# make
make -C "/root/ltp/testcases/kernel/include" -f "/root/ltp/testcases/kernel/include/Makefile" all make[1]: Entering directory /root/ltp/testcases/kernel/include' make[1]: Nothing to be done for all'.
make[1]: Leaving directory `/root/ltp/testcases/kernel/include' gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall -W -g -O2

(quoted diff) +0 -3

-Wold-style-definition -D_FORTIFY_SOURCE=2
-I/root/ltp/testcases/kernel/include -I../../../../include
-I../../../../include   -L../../../../lib  getrandom01.c   -lltp -o

getrandom01
In file included from getrandom01.c:29:
/usr/include/linux/random.h:38: error: expected specifier-qualifier-list

before ‘__u32’
/usr/include/linux/random.h:42: error: expected specifier-qualifier-list before ‘__u32’
make: *** [getrandom01] Error 1
------------------------------------------------------------------------------------------------------------
I tried to add "#include <sys/types.h>" or "#include <linux/types.h>", neither works. There maybe some bugs
in RHEL5.11GA's glibc.

Given that we use ltp_syscall() and have "GRND_RANDOM GRND_NONBLOCK" defined in
lapi/getrandom.h, what about we remove "#include <linux/random.h>" form these these 4 test cases, then
they will compile correctly in RHEL5.

Regards,
Xiaoguang Wang

----- Original Message -----

Quoted 23 lines

From: "Xiaoguang Wang" <[email protected]>
To: "Jan Stancek" <[email protected]>, "ced hnyda" <[email protected]>
Cc: "LTP" <[email protected]>
Sent: Tuesday, 7 July, 2015 12:43:59 PM
Subject: getrandom compilation broken in RHEL5.11GA

hello Jan, Cedric,

When I compile ltp in RHEL5.11GA, I run into these errors:
-----------------------------------------------------------------------------------------------------------
[root@RHEL5U11ga_Intel64 getrandom]# make
make -C "/root/ltp/testcases/kernel/include" -f "/root/ltp/testcases/kernel/include/Makefile" all make[1]: Entering directory /root/ltp/testcases/kernel/include' make[1]: Nothing to be done for all'.
make[1]: Leaving directory `/root/ltp/testcases/kernel/include' gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall -W -g -O2

(quoted diff) +0 -3

-Wold-style-definition -D_FORTIFY_SOURCE=2
-I/root/ltp/testcases/kernel/include -I../../../../include
-I../../../../include   -L../../../../lib  getrandom01.c   -lltp -o

getrandom01
In file included from getrandom01.c:29:
/usr/include/linux/random.h:38: error: expected specifier-qualifier-list

Quoted 8 lines

before ‘__u32’
/usr/include/linux/random.h:42: error: expected specifier-qualifier-list before ‘__u32’
make: *** [getrandom01] Error 1
------------------------------------------------------------------------------------------------------------
I tried to add "#include <sys/types.h>" or "#include <linux/types.h>", neither works. There maybe some bugs
in RHEL5.11GA's glibc.

It's a kernel header.

Quoted 5 lines

Given that we use ltp_syscall() and have "GRND_RANDOM GRND_NONBLOCK" defined in
lapi/getrandom.h, what about we remove "#include <linux/random.h>" form these these 4 test cases, then
they will compile correctly in RHEL5.

We can either rely on lapi/getrandom.h or get back m4 check. The latter seems like too much trouble for 2 testcases that need it, so I'd go with removing it and rely on lapi header. Can you send a patch to list please?

Regards,
Jan

Quoted 4 lines

Regards,
Xiaoguang Wang

.