Skip to contentSkip to conversation

input: fix sur40.c dependency/build errors

PATCH RESEND Applied Randy Dunlap 2 participants 6 messages Jul 10, 2015 – Oct 18, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 input: fix sur40.c dependency/build errors

From: Randy Dunlap <[email protected]>

Fix build errors due to missing Kconfig dependency.

drivers/built-in.o: In function `sur40_disconnect':
sur40.c:(.text+0x22be6e): undefined reference to video_unregister_device' sur40.c:(.text+0x22be77): undefined reference to v4l2_device_unregister' drivers/built-in.o: In function `sur40_process_video':
sur40.c:(.text+0x22c1d4): undefined reference to v4l2_get_timestamp' drivers/built-in.o: In function sur40_probe':
sur40.c:(.text+0x22ca82): undefined reference to v4l2_device_register' sur40.c:(.text+0x22cb1a): undefined reference to v4l2_device_unregister' sur40.c:(.text+0x22cbf7): undefined reference to video_device_release_empty' sur40.c:(.text+0x22cc53): undefined reference to __video_register_device' sur40.c:(.text+0x22cc90): undefined reference to video_unregister_device' drivers/built-in.o: In function sur40_vidioc_querycap':
sur40.c:(.text+0x22ccb0): undefined reference to `video_devdata'

---
 drivers/input/touchscreen/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/input/touchscreen/Kconfig +1 -0
@@ -993,6 +993,7 @@ config TOUCHSCREEN_SUN4I
 config TOUCHSCREEN_SUR40
 	tristate "Samsung SUR40 (Surface 2.0/PixelSense) touchscreen"
 	depends on USB && MEDIA_USB_SUPPORT && HAS_DMA
+	depends on VIDEO_V4L2
 	select INPUT_POLLDEV
 	select VIDEOBUF2_DMA_SG
 	help
maintainer Applied
#1 lore raw
Quoted 18 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix build errors due to missing Kconfig dependency.

drivers/built-in.o: In function `sur40_disconnect':
sur40.c:(.text+0x22be6e): undefined reference to video_unregister_device' sur40.c:(.text+0x22be77): undefined reference to v4l2_device_unregister' drivers/built-in.o: In function `sur40_process_video':
sur40.c:(.text+0x22c1d4): undefined reference to v4l2_get_timestamp' drivers/built-in.o: In function sur40_probe':
sur40.c:(.text+0x22ca82): undefined reference to v4l2_device_register' sur40.c:(.text+0x22cb1a): undefined reference to v4l2_device_unregister' sur40.c:(.text+0x22cbf7): undefined reference to video_device_release_empty' sur40.c:(.text+0x22cc53): undefined reference to __video_register_device' sur40.c:(.text+0x22cc90): undefined reference to video_unregister_device' drivers/built-in.o: In function sur40_vidioc_querycap':
sur40.c:(.text+0x22ccb0): undefined reference to `video_devdata'

Quoted 1 line

Applied, thank you.

Quoted 14 lines
---
 drivers/input/touchscreen/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/input/touchscreen/Kconfig +1 -0
@@ -993,6 +993,7 @@ config TOUCHSCREEN_SUN4I
 config TOUCHSCREEN_SUR40
 	tristate "Samsung SUR40 (Surface 2.0/PixelSense) touchscreen"
 	depends on USB && MEDIA_USB_SUPPORT && HAS_DMA
+	depends on VIDEO_V4L2
 	select INPUT_POLLDEV
 	select VIDEOBUF2_DMA_SG
 	help
Signature · 1 line
Dmitry
maintainer
#2 lore raw
Quoted 19 lines · Dmitry Torokhov
Quoted 18 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix build errors due to missing Kconfig dependency.

drivers/built-in.o: In function `sur40_disconnect':
sur40.c:(.text+0x22be6e): undefined reference to video_unregister_device' sur40.c:(.text+0x22be77): undefined reference to v4l2_device_unregister' drivers/built-in.o: In function `sur40_process_video':
sur40.c:(.text+0x22c1d4): undefined reference to v4l2_get_timestamp' drivers/built-in.o: In function sur40_probe':
sur40.c:(.text+0x22ca82): undefined reference to v4l2_device_register' sur40.c:(.text+0x22cb1a): undefined reference to v4l2_device_unregister' sur40.c:(.text+0x22cbf7): undefined reference to video_device_release_empty' sur40.c:(.text+0x22cc53): undefined reference to __video_register_device' sur40.c:(.text+0x22cc90): undefined reference to video_unregister_device' drivers/built-in.o: In function sur40_vidioc_querycap':
sur40.c:(.text+0x22ccb0): undefined reference to `video_devdata'

Quoted 3 lines
Quoted 1 line

Applied, thank you.

Actually, Mauro, can this go through media tree for now?

Quoted 18 lines
Quoted 15 lines
---
 drivers/input/touchscreen/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/input/touchscreen/Kconfig +1 -0
@@ -993,6 +993,7 @@ config TOUCHSCREEN_SUN4I
 config TOUCHSCREEN_SUR40
 	tristate "Samsung SUR40 (Surface 2.0/PixelSense) touchscreen"
 	depends on USB && MEDIA_USB_SUPPORT && HAS_DMA
+	depends on VIDEO_V4L2
 	select INPUT_POLLDEV
 	select VIDEOBUF2_DMA_SG
 	help
Signature · 1 line
Dmitry
Signature · 1 line
Dmitry
maintainer
#3 lore raw
Quoted 20 lines · Dmitry Torokhov
Quoted 19 lines · Dmitry Torokhov
Quoted 18 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix build errors due to missing Kconfig dependency.

drivers/built-in.o: In function `sur40_disconnect':
sur40.c:(.text+0x22be6e): undefined reference to video_unregister_device' sur40.c:(.text+0x22be77): undefined reference to v4l2_device_unregister' drivers/built-in.o: In function `sur40_process_video':
sur40.c:(.text+0x22c1d4): undefined reference to v4l2_get_timestamp' drivers/built-in.o: In function sur40_probe':
sur40.c:(.text+0x22ca82): undefined reference to v4l2_device_register' sur40.c:(.text+0x22cb1a): undefined reference to v4l2_device_unregister' sur40.c:(.text+0x22cbf7): undefined reference to video_device_release_empty' sur40.c:(.text+0x22cc53): undefined reference to __video_register_device' sur40.c:(.text+0x22cc90): undefined reference to video_unregister_device' drivers/built-in.o: In function sur40_vidioc_querycap':
sur40.c:(.text+0x22ccb0): undefined reference to `video_devdata'

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Applied, thank you.

Actually, Mauro, can this go through media tree for now?

Do we still need this patch?

Thanks.

Quoted 22 lines
Quoted 19 lines
Quoted 16 lines

---
 drivers/input/touchscreen/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/input/touchscreen/Kconfig +1 -0
@@ -993,6 +993,7 @@ config TOUCHSCREEN_SUN4I
 config TOUCHSCREEN_SUR40
 	tristate "Samsung SUR40 (Surface 2.0/PixelSense) touchscreen"
 	depends on USB && MEDIA_USB_SUPPORT && HAS_DMA
+	depends on VIDEO_V4L2
 	select INPUT_POLLDEV
 	select VIDEOBUF2_DMA_SG
 	help
Signature · 1 line
Dmitry
Signature · 1 line
Dmitry
Signature · 1 line
Dmitry
#4 lore raw
Quoted 21 lines · Dmitry Torokhov
Quoted 20 lines · Dmitry Torokhov
Quoted 19 lines · Dmitry Torokhov
Quoted 18 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix build errors due to missing Kconfig dependency.

drivers/built-in.o: In function `sur40_disconnect':
sur40.c:(.text+0x22be6e): undefined reference to video_unregister_device' sur40.c:(.text+0x22be77): undefined reference to v4l2_device_unregister' drivers/built-in.o: In function `sur40_process_video':
sur40.c:(.text+0x22c1d4): undefined reference to v4l2_get_timestamp' drivers/built-in.o: In function sur40_probe':
sur40.c:(.text+0x22ca82): undefined reference to v4l2_device_register' sur40.c:(.text+0x22cb1a): undefined reference to v4l2_device_unregister' sur40.c:(.text+0x22cbf7): undefined reference to video_device_release_empty' sur40.c:(.text+0x22cc53): undefined reference to __video_register_device' sur40.c:(.text+0x22cc90): undefined reference to video_unregister_device' drivers/built-in.o: In function sur40_vidioc_querycap':
sur40.c:(.text+0x22ccb0): undefined reference to `video_devdata'

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Applied, thank you.

Actually, Mauro, can this go through media tree for now?

Do we still need this patch?

Yes, I just tested 4.3-rc5 and it still has this problem.

Quoted 1 line

Thanks.

(reuse bits)

Quoted 24 lines
Quoted 23 lines
Quoted 20 lines
Quoted 17 lines


---
 drivers/input/touchscreen/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/input/touchscreen/Kconfig +1 -0
@@ -993,6 +993,7 @@ config TOUCHSCREEN_SUN4I
 config TOUCHSCREEN_SUR40
 	tristate "Samsung SUR40 (Surface 2.0/PixelSense) touchscreen"
 	depends on USB && MEDIA_USB_SUPPORT && HAS_DMA
+	depends on VIDEO_V4L2
 	select INPUT_POLLDEV
 	select VIDEOBUF2_DMA_SG
 	help
Signature · 1 line
Dmitry
Signature · 1 line
Dmitry
Signature · 1 line
~Randy
maintainer Applied
#5 lore raw
Quoted 24 lines · Randy Dunlap
Quoted 23 lines · Dmitry Torokhov
Quoted 22 lines · Dmitry Torokhov
Quoted 21 lines · Dmitry Torokhov
Quoted 19 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix build errors due to missing Kconfig dependency.

drivers/built-in.o: In function `sur40_disconnect':
sur40.c:(.text+0x22be6e): undefined reference to video_unregister_device' sur40.c:(.text+0x22be77): undefined reference to v4l2_device_unregister' drivers/built-in.o: In function `sur40_process_video':
sur40.c:(.text+0x22c1d4): undefined reference to v4l2_get_timestamp' drivers/built-in.o: In function sur40_probe':
sur40.c:(.text+0x22ca82): undefined reference to v4l2_device_register' sur40.c:(.text+0x22cb1a): undefined reference to v4l2_device_unregister' sur40.c:(.text+0x22cbf7): undefined reference to video_device_release_empty' sur40.c:(.text+0x22cc53): undefined reference to __video_register_device' sur40.c:(.text+0x22cc90): undefined reference to video_unregister_device' drivers/built-in.o: In function sur40_vidioc_querycap':
sur40.c:(.text+0x22ccb0): undefined reference to `video_devdata'

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Applied, thank you.

Actually, Mauro, can this go through media tree for now?

Do we still need this patch?

Yes, I just tested 4.3-rc5 and it still has this problem.

Applied, thank you.

Signature · 1 line
Dmitry