Skip to contentSkip to conversation

heimdal: needs host-ncurses

PATCH New Vicente Olivert Riera 3 participants 6 messages Jul 10, 2015 – Jul 14, 2015

lore
Share & tools
lore

Vicente Olivert Riera

author
#0 lore raw

PATCH 1/2 heimdal: needs host-ncurses

Otherwise it will fail with an error like this one:

checking for tgetent in -lcurses... no checking for tgetent in -lncurses... no
configure: error: libcurses or libncurses are required!

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/heimdal/heimdal.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/heimdal/heimdal.mk +1 -1
index 6260f8c..19bca5e 100644
@@ -6,7 +6,7 @@
 
 HEIMDAL_VERSION = 1.6rc2
 HEIMDAL_SITE = http://www.h5l.org/dist/src
-HEIMDAL_DEPENDENCIES = host-e2fsprogs host-pkgconf
+HEIMDAL_DEPENDENCIES = host-e2fsprogs host-ncurses host-pkgconf
 HEIMDAL_INSTALL_STAGING = YES
 # static because of -fPIC issues with e2fsprogs on x86_64 host
 HOST_HEIMDAL_CONF_OPTS = \
Signature · 1 line
2.3.6
author
#1 lore raw

PATCH 2/2 heimdal: disable parallel build

The commit 2fc8be39edd610623d322c71e42a06b535cbadb7 enabled parallel build, but this is causing build failures like this one:

Making all in kadm5
make[3]: Entering directory `/home/test/autobuild/instance-0/output/build/host-heimdal-1.6rc2/lib/kadm5' compile_et kadm5_err.et
compile_et kadm5_err.et
CC ad.lo
CC chpass_c.lo
In file included from chpass_c.c:34:
kadm5_locl.h:78:23: error: kadm5_err.h: No such file or directory

The file 'kadm5_err.h' is a generated header which is being requested before being generated.

Fixes:

http://autobuild.buildroot.net/results/3a4/3a42c5b294a9a8602844ed1127ec5eadb60a6bed/

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/heimdal/heimdal.mk | 1 +
 1 file changed, 1 insertion(+)
package/heimdal/heimdal.mk +1 -0
index 19bca5e..8c2aa2b 100644
@@ -24,6 +24,7 @@ HOST_HEIMDAL_CONF_OPTS = \
 	--without-x \
 	--disable-heimdal-documentation
 HOST_HEIMDAL_CONF_ENV = MAKEINFO=true
+HEIMDAL_MAKE = $(MAKE1)
 HEIMDAL_LICENSE = BSD-3c
 HEIMDAL_LICENSE_FILES = LICENSE
Signature · 1 line
2.3.6
#2 lore raw

PATCH 2/2 heimdal: disable parallel build

Quoted 13 lines · Vicente Olivert Riera

The commit 2fc8be39edd610623d322c71e42a06b535cbadb7 enabled parallel build, but this is causing build failures like this one:

Making all in kadm5
make[3]: Entering directory `/home/test/autobuild/instance-0/output/build/host-heimdal-1.6rc2/lib/kadm5' compile_et kadm5_err.et
compile_et kadm5_err.et
CC ad.lo
CC chpass_c.lo
In file included from chpass_c.c:34:
kadm5_locl.h:78:23: error: kadm5_err.h: No such file or directory

Quoted 8 lines

The file 'kadm5_err.h' is a generated header which is being requested before being generated.

Fixes:

   http://autobuild.buildroot.net/results/3a4/3a42c5b294a9a8602844ed1127ec5eadb60a6bed/
Signed-off-by Vicente Olivert Riera <[email protected]>

Hi Vicente.
That's harsh, specially since it seems to be a tiny breakage that's already fixed upstream via:
http://repo.or.cz/w/heimdal.git/commitdiff/6affa4c
Care to redo it in a "fixing" way? :)
Regards.

author
#3 lore raw

PATCH 2/2 heimdal: disable parallel build

Sure, no problem.

Quoted 36 lines · Gustavo Zacarias
Quoted 17 lines · Vicente Olivert Riera

The commit 2fc8be39edd610623d322c71e42a06b535cbadb7 enabled parallel build, but this is causing build failures like this one:

Making all in kadm5
make[3]: Entering directory `/home/test/autobuild/instance-0/output/build/host-heimdal-1.6rc2/lib/kadm5'

compile_et kadm5_err.et
compile_et kadm5_err.et
CC ad.lo
CC chpass_c.lo
In file included from chpass_c.c:34:
kadm5_locl.h:78:23: error: kadm5_err.h: No such file or directory

The file 'kadm5_err.h' is a generated header which is being requested before being generated.

Quoted 7 lines

Fixes:

http://autobuild.buildroot.net/results/3a4/3a42c5b294a9a8602844ed1127ec5eadb60a6bed/

Signed-off-by Vicente Olivert Riera <[email protected]>

Hi Vicente.
That's harsh, specially since it seems to be a tiny breakage that's already fixed upstream via:
http://repo.or.cz/w/heimdal.git/commitdiff/6affa4c
Care to redo it in a "fixing" way? :)
Regards.

#4 lore raw

PATCH 2/2 heimdal: disable parallel build

In reply to Vicente Olivert Riera

Dear Vicente Olivert Riera,

Quoted 16 lines · Vicente Olivert Riera

The commit 2fc8be39edd610623d322c71e42a06b535cbadb7 enabled parallel build, but this is causing build failures like this one:

Making all in kadm5
make[3]: Entering directory `/home/test/autobuild/instance-0/output/build/host-heimdal-1.6rc2/lib/kadm5' compile_et kadm5_err.et
compile_et kadm5_err.et
CC ad.lo
CC chpass_c.lo
In file included from chpass_c.c:34:
kadm5_locl.h:78:23: error: kadm5_err.h: No such file or directory

The file 'kadm5_err.h' is a generated header which is being requested before being generated.

Quoted 8 lines

Fixes:

http://autobuild.buildroot.net/results/3a4/3a42c5b294a9a8602844ed1127ec5eadb60a6bed/

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/heimdal/heimdal.mk | 1 +
 1 file changed, 1 insertion(+)

I've marked this patch as Rejected and instead committed a patch that backports the upstream commit pointed by Gustavo and that should fix the parallel build issue.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Applied
#5 lore raw

PATCH 1/2 heimdal: needs host-ncurses

In reply to Vicente Olivert Riera

Dear Vicente Olivert Riera,

Quoted 10 lines · Vicente Olivert Riera

Otherwise it will fail with an error like this one:

checking for tgetent in -lcurses... no checking for tgetent in -lncurses... no
configure: error: libcurses or libncurses are required!

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/heimdal/heimdal.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com