Skip to contentSkip to conversation

linux: adjust fixup logic for ktap

PATCH New Thomas Petazzoni 2 participants 3 messages Feb 22, 2015 – Jul 13, 2015

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 linux: adjust fixup logic for ktap

The ktap package requires some parts of the kernel tracing infrastructure to be enabled, especially CONFIG_EVENT_TRACING. However, this option is a blind option in the kernel, so enabling it in linux.mk has no effect: we need to enable a non-blind option that selects CONFIG_EVENT_TRACING. We've chosen to select CONFIG_FTRACE.

This fixes the build of ktap.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 linux/linux.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
linux/linux.mk +1 -1
index 29f59e8..75f4936 100644
@@ -198,7 +198,7 @@ define LINUX_CONFIGURE_CMDS
 		$(call KCONFIG_ENABLE_OPT,CONFIG_INOTIFY_USER,$(@D)/.config))
 	$(if $(BR2_PACKAGE_KTAP),
 		$(call KCONFIG_ENABLE_OPT,CONFIG_DEBUG_FS,$(@D)/.config)
-		$(call KCONFIG_ENABLE_OPT,CONFIG_EVENT_TRACING,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_FTRACE,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_PERF_EVENTS,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_FUNCTION_TRACER,$(@D)/.config))
 	$(if $(BR2_PACKAGE_SYSTEMD),
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 linux: adjust fixup logic for ktap

Quoted 6 lines · Thomas Petazzoni

The ktap package requires some parts of the kernel tracing infrastructure to be enabled, especially CONFIG_EVENT_TRACING. However, this option is a blind option in the kernel, so enabling it in linux.mk has no effect: we need to enable a non-blind option that selects CONFIG_EVENT_TRACING. We've chosen to select CONFIG_FTRACE.

I think it makes more sense to select the smaller ENABLE_DEFAULT_TRACERS, no?

Otherwise:

Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

Quoted 22 lines

This fixes the build of ktap.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 linux/linux.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
linux/linux.mk +1 -1
index 29f59e8..75f4936 100644
@@ -198,7 +198,7 @@ define LINUX_CONFIGURE_CMDS
 		$(call KCONFIG_ENABLE_OPT,CONFIG_INOTIFY_USER,$(@D)/.config))
 	$(if $(BR2_PACKAGE_KTAP),
 		$(call KCONFIG_ENABLE_OPT,CONFIG_DEBUG_FS,$(@D)/.config)
-		$(call KCONFIG_ENABLE_OPT,CONFIG_EVENT_TRACING,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_FTRACE,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_PERF_EVENTS,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_FUNCTION_TRACER,$(@D)/.config))
 	$(if $(BR2_PACKAGE_SYSTEMD),
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
author
#2 lore raw

PATCH 1/1 linux: adjust fixup logic for ktap

In reply to Thomas Petazzoni

Hello,

Quoted 7 lines · Thomas Petazzoni

The ktap package requires some parts of the kernel tracing infrastructure to be enabled, especially CONFIG_EVENT_TRACING. However, this option is a blind option in the kernel, so enabling it in linux.mk has no effect: we need to enable a non-blind option that selects CONFIG_EVENT_TRACING. We've chosen to select CONFIG_FTRACE.

Quoted 6 lines

This fixes the build of ktap.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 linux/linux.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied with Arnout's suggestion taken into account.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com