Skip to contentSkip to conversation

insane.bbclass: skip dev-deps QA checking for ptest package

PATCH In review Robert Yang 2 participants 4 messages Jul 6, 2015 – Jul 12, 2015

lore
Share & tools
lore
#0 lore raw

cover insane.bbclass: skip dev-deps QA checking for ptest package

The following changes since commit dd09fab685de2eaf04aa5ab60f8220b89c1deae9:

tune-core2.inc: set X86ARCH32 to i686 (instead of i586) (2015-07-02 23:08:27 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/insane
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/insane

Robert Yang (1):
insane.bbclass: skip dev-deps QA checking for ptest package

 meta/classes/insane.bbclass |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 insane.bbclass: skip dev-deps QA checking for ptest package

The ptest pkg such as perl-ptest may need .h, .so or other files in dev package to run test cases, so skipping dev-deps checkin for ptest package.

---
 meta/classes/insane.bbclass |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/classes/insane.bbclass +2 -1
index 4537eec..d0eaa6b 100644
@@ -792,7 +792,8 @@ def package_qa_check_rdepends(pkg, pkgdest, skip, taskdeps, packages, d):
                 if "-dbg" in rdepend and "debug-deps" not in skip:
                     error_msg = "%s rdepends on %s" % (pkg,rdepend)
                     sane = package_qa_handle_error("debug-deps", error_msg, d)
-                if (not "-dev" in pkg and not "-staticdev" in pkg) and rdepend.endswith("-dev") and "dev-deps" not in skip:
+                if (not pkg.endswith('-ptest') and not "-dev" in pkg and not "-staticdev" in pkg) \
+                        and rdepend.endswith("-dev") and "dev-deps" not in skip:
                     error_msg = "%s rdepends on %s" % (pkg, rdepend)
                     sane = package_qa_handle_error("dev-deps", error_msg, d)
                 if rdepend not in packages:
Signature · 1 line
1.7.9.5
#2 lore raw
Quoted 4 lines · Robert Yang

The ptest pkg such as perl-ptest may need .h, .so or other files in dev package to run test cases, so skipping dev-deps checkin for ptest package.

Is this a common occurrence or is perl the first instance of this? This warning can be skipped with INSANE_SKIP_${PN}-ptest = "dev-deps", right?

Ross

#3 lore raw
Quoted 11 lines · Ross

On 6 July 2015 at 11:01, Robert Yang <[email protected] <mailto:[email protected]>> wrote:

The ptest pkg such as perl-ptest may need .h, .so or other files in dev package to run test cases, so skipping dev-deps checkin for ptest package.

Is this a common occurrence or is perl the first instance of this? This warning can be skipped with INSANE_SKIP_${PN}-ptest = "dev-deps", right?

I only know perl atm, I will try more.

// Robert

Quoted 2 lines

Ross