Skip to contentSkip to conversation

3.18.18 - synaptics.c regression

DISCUSSION Nick Warne 1 participant 1 message Jul 12, 2015

lore
Share & tools
lore

Nick Warne

author
#0 lore raw

I am just building 3.18.18, and GCC threw up a warning about 'missing curly braces' in drivers/input/mouse/synaptics.c

Looking at the file, line 152 has the min_max_pnpid_table[3].board_id’ stuff missing:
*snip*

        {
                (const char * const []){"LEN0034", "LEN0036", "LEN0037",
                                        "LEN0039", "LEN2002", "LEN2004",
                                        NULL},
                {ANY_BOARD_ID, 2961},
                1024, 5112, 2024, 4832
        },
        {
                (const char * const []){"LEN2000", NULL},
                1024, 5113, 2021, 4832    <---line missing above here
        },
        {
                (const char * const []){"LEN2001", NULL},
                {ANY_BOARD_ID, ANY_BOARD_ID},
                1024, 5022, 2508, 4832
        },

*snip*

I am not sure what goes here, maybe just {ANY_BOARD_ID, ANY_BOARD_ID}?

Regards,

Nick

Signature · 3 lines
Gosh that takes me back... or is it forward?  That's the trouble with
time travel, you never can tell."
		-- Doctor Who "Androids of Tara"