Skip to contentSkip to conversation

gptfdisk: bump version 1.0.0

PATCH New Aurélien Chabot 3 participants 6 messages Jul 13, 2015 – Jul 18, 2015

lore
Share & tools
lore

Aurélien Chabot

author
#0 lore raw

PATCH 1/1 gptfdisk: bump version 1.0.0

Signed-off-by Aur?lien Chabot <[email protected]>
---
 package/gptfdisk/0001-ldlibs.patch | 2 +-
 package/gptfdisk/gptfdisk.hash     | 6 +++---
 package/gptfdisk/gptfdisk.mk       | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)
package/gptfdisk/0001-ldlibs.patch +1 -1
index ca1d7fb..280dfc9 100644
@@ -15,7 +15,7 @@ diff -Nura gptfdisk-0.8.10.orig/Makefile gptfdisk-0.8.10/Makefile
  
  cgdisk: $(LIB_OBJS) cgdisk.o gptcurses.o
 -	$(CXX) $(LIB_OBJS) cgdisk.o gptcurses.o $(LDFLAGS) -luuid -lncursesw -o cgdisk
-+	$(CXX) $(LIB_OBJS) cgdisk.o gptcurses.o $(LDFLAGS) -luuid -lncursesw $(LDLIBS) -o cgdisk
++	$(CXX) $(LIB_OBJS) cgdisk.o gptcurses.o $(LDFLAGS) -luuid -lncurses $(LDLIBS) -o cgdisk
  #	$(CXX) $(LIB_OBJS) cgdisk.o gptcurses.o $(LDFLAGS) -licuio -licuuc -luuid -lncurses -o cgdisk
  
  sgdisk: $(LIB_OBJS) sgdisk.o gptcl.o
package/gptfdisk/gptfdisk.hash +3 -3
index 93f7b36..0a72e0d 100644
@@ -1,3 +1,3 @@
-# From http://sourceforge.net/projects/gptfdisk/files/gptfdisk/0.8.10/
-md5	9cf4246c181c324bdbd553fe9b348373	gptfdisk-0.8.10.tar.gz
-sha1	1708e232220236b6bdf299b315e9bc2205c01ba5	gptfdisk-0.8.10.tar.gz
+# From http://sourceforge.net/projects/gptfdisk/files/gptfdisk/1.0.0/
+md5	2061f917af084215898d4fea04d8388f	gptfdisk-1.0.0.tar.gz
+sha1	97f25db2def1c1939ed3954520bfd9948806d95a	gptfdisk-1.0.0.tar.gz
package/gptfdisk/gptfdisk.mk +1 -1
index f812376..abfddfb 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GPTFDISK_VERSION = 0.8.10
+GPTFDISK_VERSION = 1.0.0
 GPTFDISK_SITE = http://downloads.sourceforge.net/sourceforge/gptfdisk
 GPTFDISK_LICENSE = GPLv2+
 GPTFDISK_LICENSE_FILES = COPYING
Signature · 1 line
2.4.5
author
#1 lore raw

PATCH 1/1 gptfdisk: bump version 1.0.0

Review

Quoted 5 lines · Aur?lien Chabot

-+ $(CXX) $(LIB_OBJS) cgdisk.o gptcurses.o $(LDFLAGS) -luuid

(quoted diff) +1 -2
-lncursesw $(LDLIBS) -o cgdisk
++      $(CXX) $(LIB_OBJS) cgdisk.o gptcurses.o $(LDFLAGS) -luuid
-lncurses $(LDLIBS) -o cgdisk

I had to do that to make it build correctly. This seems strange to me, any
idea why ?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150713/7316021f/attachment.html>

#2 lore raw

PATCH 1/1 gptfdisk: bump version 1.0.0

Quoted 4 lines · Aur?lien Chabot

On Mon, Jul 13, 2015 at 8:26 PM, Aur?lien Chabot <[email protected] <mailto:[email protected]>> wrote:

Quoted 8 lines
    -+      $(CXX) $(LIB_OBJS) cgdisk.o gptcurses.o $(LDFLAGS) -luuid -lncursesw
    $(LDLIBS) -o cgdisk
    ++      $(CXX) $(LIB_OBJS) cgdisk.o gptcurses.o $(LDFLAGS) -luuid -lncurses
    $(LDLIBS) -o cgdisk

I had to do that to make it build correctly. This seems strange to me, any idea why ?

It looks like gptfdisk no longer uses the wide-char version of ncurses. Or
perhaps it depends on the configuration...

In that case, the select of BR2_PACKAGE_NCURSES_WCHAR can probably be removed
as well. Could you test that?

Oh, and if you resubmit, please mention a change like this explicitly in the
commit log (along with an explanation why it is needed, which would have been difficult in this case since you didn't understand :-).

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
author
#3 lore raw

PATCH v2 1/1 gptfdisk: bump version 1.0.0

In reply to Aurélien Chabot

In this latest patch revision, I just remove the diff of ncurses vs ncursesw, my build issue where most probably due to a wrong compilation step from myself.

Aur?lien Chabot (1):
gptfdisk: bump version 1.0.0

 package/gptfdisk/gptfdisk.hash | 6 +++---
 package/gptfdisk/gptfdisk.mk   | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
2.4.6
author
#4 lore raw

PATCH v2 1/1 gptfdisk: bump version 1.0.0

Signed-off-by Aur?lien Chabot <[email protected]>
---
 package/gptfdisk/gptfdisk.hash | 6 +++---
 package/gptfdisk/gptfdisk.mk   | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
package/gptfdisk/gptfdisk.hash +3 -3
index 93f7b36..0a72e0d 100644
@@ -1,3 +1,3 @@
-# From http://sourceforge.net/projects/gptfdisk/files/gptfdisk/0.8.10/
-md5	9cf4246c181c324bdbd553fe9b348373	gptfdisk-0.8.10.tar.gz
-sha1	1708e232220236b6bdf299b315e9bc2205c01ba5	gptfdisk-0.8.10.tar.gz
+# From http://sourceforge.net/projects/gptfdisk/files/gptfdisk/1.0.0/
+md5	2061f917af084215898d4fea04d8388f	gptfdisk-1.0.0.tar.gz
+sha1	97f25db2def1c1939ed3954520bfd9948806d95a	gptfdisk-1.0.0.tar.gz
package/gptfdisk/gptfdisk.mk +1 -1
index f812376..abfddfb 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GPTFDISK_VERSION = 0.8.10
+GPTFDISK_VERSION = 1.0.0
 GPTFDISK_SITE = http://downloads.sourceforge.net/sourceforge/gptfdisk
 GPTFDISK_LICENSE = GPLv2+
 GPTFDISK_LICENSE_FILES = COPYING
Signature · 1 line
2.4.6
Applied
#5 lore raw

PATCH v2 1/1 gptfdisk: bump version 1.0.0

Dear Aur?lien Chabot,

Quoted 5 lines · Aur?lien Chabot
Signed-off-by Aur?lien Chabot <[email protected]>
---
 package/gptfdisk/gptfdisk.hash | 6 +++---
 package/gptfdisk/gptfdisk.mk   | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com