Skip to contentSkip to conversation

phy: berlin-usb: PLL divider fixes

PATCH In review Thomas Hebb 3 participants 3 messages Jul 2, 2015 – Jul 15, 2015

lore
Share & tools
lore

Thomas Hebb

author
#0 lore raw

cover phy: berlin-usb: PLL divider fixes

The USB PLL dividers currently set by phy-berlin-usb are incorrect for BG2 and BG2CD (i.e. all Berlin variants but BG2Q). This series fixes the divider values for those two chips and additionally corrects the name of the of_match table to no longer contain "sata" (which was presumably mistakenly carried over from phy-berlin-sata).

I have verified that the new divider values work on BG2CD and Antoine Tenart has verified that they work on BG2Q. The divider value for BG2 was taken from bootloader source but has not been tested.

Thomas Hebb (4):
phy: berlin-usb: fix divider for BG2CD
ARM: dts: berlin: change BG2Q's USB PHY compatible
phy: berlin-usb: fix divider for BG2
phy: berlin-usb: rename table copied from SATA PHY

 arch/arm/boot/dts/berlin2q.dtsi |  6 +++---
 drivers/phy/phy-berlin-usb.c    | 12 ++++++------
 2 files changed, 9 insertions(+), 9 deletions(-)
Signature · 1 line
2.4.4
Tested-by on the v1 series
#1 lore raw

Hi Thomas,

Thanks for this series!

Quoted 9 lines · Thomas Hebb

The USB PLL dividers currently set by phy-berlin-usb are incorrect for BG2 and BG2CD (i.e. all Berlin variants but BG2Q). This series fixes the divider values for those two chips and additionally corrects the name of the of_match table to no longer contain "sata" (which was presumably mistakenly carried over from phy-berlin-sata).

I have verified that the new divider values work on BG2CD and Antoine Tenart has verified that they work on BG2Q. The divider value for BG2 was taken from bootloader source but has not been tested.

For the BG2Q,

Tested-by Antoine Tenart <[email protected]>
Quoted 14 lines

Thomas Hebb (4):
phy: berlin-usb: fix divider for BG2CD
ARM: dts: berlin: change BG2Q's USB PHY compatible
phy: berlin-usb: fix divider for BG2
phy: berlin-usb: rename table copied from SATA PHY

 arch/arm/boot/dts/berlin2q.dtsi |  6 +++---
 drivers/phy/phy-berlin-usb.c    | 12 ++++++------
 2 files changed, 9 insertions(+), 9 deletions(-)
Signature · 1 line
2.4.4
Signature · 3 lines
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

Hi,

Quoted 11 lines · Antoine Tenart

Hi Thomas,

Thanks for this series!

Quoted 6 lines · Thomas Hebb

The USB PLL dividers currently set by phy-berlin-usb are incorrect for BG2 and BG2CD (i.e. all Berlin variants but BG2Q). This series fixes the divider values for those two chips and additionally corrects the name of the of_match table to no longer contain "sata" (which was presumably mistakenly carried over from phy-berlin-sata).

Quoted 7 lines
Quoted 3 lines

I have verified that the new divider values work on BG2CD and Antoine Tenart has verified that they work on BG2Q. The divider value for BG2 was taken from bootloader source but has not been tested.

For the BG2Q,

Tested-by Antoine Tenart <[email protected]>

merged this series except
"ARM: dts: berlin: change BG2Q's USB PHY compatible"

Cheers
Kishon

Quoted 16 lines
Quoted 15 lines

Thomas Hebb (4):
phy: berlin-usb: fix divider for BG2CD
ARM: dts: berlin: change BG2Q's USB PHY compatible
phy: berlin-usb: fix divider for BG2
phy: berlin-usb: rename table copied from SATA PHY

 arch/arm/boot/dts/berlin2q.dtsi |  6 +++---
 drivers/phy/phy-berlin-usb.c    | 12 ++++++------
 2 files changed, 9 insertions(+), 9 deletions(-)
Signature · 1 line
2.4.4