configs: make keystone2 config to start using arm_v7_common header

TI armv7 based SoCs are based on two architectures - one based on OMAP generation architecture and others based on Keystone architecture.

Many of the options are architecture specific, however a lot are common with v7 architecture. So, step 1 will be to move out OMAP specific stuff from ti_armv7_common into a ti_armv7_omap.h header which is then used by all the relevant architecture headers.

Signed-off-by Nishanth Menon <[email protected]>

---
V2: no change.

V1: https://patchwork.ozlabs.org/patch/496726/

  include/configs/am43xx_evm.h       |  2 +-
  include/configs/ti_am335x_common.h |  2 +-
  include/configs/ti_armv7_common.h  | 21 ----------------
  include/configs/ti_armv7_omap.h    | 49 ++++++++++++++++++++++++++++++++++++++
  include/configs/ti_omap3_common.h  |  2 +-
  include/configs/ti_omap4_common.h  |  2 +-
  include/configs/ti_omap5_common.h  |  2 +-
  7 files changed, 54 insertions(+), 26 deletions(-)

create mode 100644 include/configs/ti_armv7_omap.h

include/configs/am43xx_evm.h +1 -1

index 33e534a76583..65ac8ef34eb8 100644
@@ -80,7 +80,7 @@
  #endif
 
  /* Now bring in the rest of the common code. */
-#include <configs/ti_armv7_common.h>
+#include <configs/ti_armv7_omap.h>
 
  /* Always 64 KiB env size */
  #define CONFIG_ENV_SIZE			(64 << 10)

include/configs/ti_am335x_common.h +1 -1

index 4d2ae280e7f1..9697431b4496 100644
@@ -94,6 +94,6 @@
  #endif
 
  /* Now bring in the rest of the common code. */
-#include <configs/ti_armv7_common.h>
+#include <configs/ti_armv7_omap.h>
 
  #endif	/* __CONFIG_TI_AM335X_COMMON_H__ */

include/configs/ti_armv7_common.h +0 -2

index 0aea7d12ec16..63244dbc83ff 100644
@@ -18,8 +18,6 @@
  #define __CONFIG_TI_ARMV7_COMMON_H__
 
  /* Common define for many platforms. */
-#define CONFIG_OMAP
-#define CONFIG_OMAP_COMMON
  #define CONFIG_SYS_GENERIC_BOARD
 
  /*

include/configs/ti_armv7_common.h +0 -13

  /*
- * GPMC NAND block.  We support 1 device and the physical address to
- * access CS0 at is 0x8000000.
- */
-#ifdef CONFIG_NAND
-#define CONFIG_NAND_OMAP_GPMC
-#ifndef CONFIG_SYS_NAND_BASE
-#define CONFIG_SYS_NAND_BASE		0x8000000
-#endif
-#define CONFIG_SYS_MAX_NAND_DEVICE	1
-#define CONFIG_CMD_NAND
-#endif
-
-/*
   * The following are general good-enough settings for U-Boot.  We set a
   * large malloc pool as we generally have a lot of DDR, and we opt for
   * function over binary size in the main portion of U-Boot as this is

include/configs/ti_armv7_omap.h new file +49 -0

new file mode 100644
index 000000000000..7548170afcf7
@@ -0,0 +1,49 @@
+/*
+ * ti_armv7_omap.h
+ *
+ * Copyright (C) 2015 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ *
+ * The various ARMv7 SoCs from TI all share a number of IP blocks when
+ * implementing a given feature. This is meant to isolate the features
+ * that are based on OMAP architecture.
+ */
+#ifndef __CONFIG_TI_ARMV7_OMAP_H__
+#define __CONFIG_TI_ARMV7_OMAP_H__
+
+/* Common defines for all OMAP architecture based SoCs */
+#define CONFIG_OMAP
+#define CONFIG_OMAP_COMMON
+
+/* I2C IP block */
+#define CONFIG_SYS_OMAP24_I2C_SPEED	100000
+#define CONFIG_SYS_OMAP24_I2C_SLAVE	1
+#define CONFIG_SYS_I2C_OMAP24XX
+
+/* MMC/SD IP block */
+#define CONFIG_OMAP_HSMMC
+
+/* SPI IP Block */
+#define CONFIG_OMAP3_SPI
+
+/* GPIO block */
+#define CONFIG_OMAP_GPIO
+
+/*
+ * GPMC NAND block.  We support 1 device and the physical address to
+ * access CS0 at is 0x8000000.
+ */
+#ifdef CONFIG_NAND
+#define CONFIG_NAND_OMAP_GPMC
+#ifndef CONFIG_SYS_NAND_BASE
+#define CONFIG_SYS_NAND_BASE		0x8000000
+#endif
+#define CONFIG_SYS_MAX_NAND_DEVICE	1
+#define CONFIG_CMD_NAND
+#endif
+
+/* Now for the remaining common defines */
+#include <configs/ti_armv7_common.h>
+
+#endif /* __CONFIG_TI_ARMV7_OMAP_H__ */

include/configs/ti_omap3_common.h +1 -1

index 429b109afa23..be231a551361 100644
@@ -84,6 +84,6 @@
  #endif
 
  /* Now bring in the rest of the common code. */
-#include <configs/ti_armv7_common.h>
+#include <configs/ti_armv7_omap.h>
 
  #endif	/* __CONFIG_TI_OMAP3_COMMON_H__ */

include/configs/ti_omap4_common.h +1 -1

index e96613406b3b..959f312edb5b 100644
@@ -52,7 +52,7 @@
  #define CONFIG_SYS_DEFAULT_LPDDR2_TIMINGS
  #endif
 
-#include <configs/ti_armv7_common.h>
+#include <configs/ti_armv7_omap.h>
 
  /*
   * Hardware drivers

include/configs/ti_omap5_common.h +1 -1

index f3e5a7587de9..789542be6710 100644
@@ -47,7 +47,7 @@
  #include <asm/arch/cpu.h>
  #include <asm/arch/omap.h>
 
-#include <configs/ti_armv7_common.h>
+#include <configs/ti_armv7_omap.h>
 
  /*
   * Hardware drivers

On 07/16/2015 03:08 PM, Nishanth Menon wrote:

Quoted 3 lines

  /* MMC/SD IP block */
  #define CONFIG_MMC
  #define CONFIG_GENERIC_MMC

Why do we need MMC options in common? Only keystone device that uses MMC is Galileo. This should stay in individual device specific or board specific config file.

Quoted 3 lines

-#define CONFIG_OMAP_HSMMC
#define CONFIG_CMD_MMC

Same here..

Quoted 3 lines

/* GPIO block */
-#define CONFIG_OMAP_GPIO
#define CONFIG_CMD_GPIO

I believe currently keystone doesn't use GPIO, but this may change. Probably remove this as well for now and add it when GPIO is supported on K2.

Quoted 1 line · Murali Karicheri

On 07/16/2015 03:08 PM, Nishanth Menon wrote:

[...]

Quoted 4 lines

Quoted 3 lines

   /* MMC/SD IP block */
   #define CONFIG_MMC
   #define CONFIG_GENERIC_MMC

Quoted 3 lines

Why do we need MMC options in common? Only keystone device that uses MMC is Galileo. This should stay in individual device specific or board specific config file.

precisely why MMC is present in generic - lack of mmc is not consistent in all ks2 devices as well - we can #undef if as necessary. I did miss undefing it in patch #4 - I just did #undef CONFIG_SPL_MMC_SUPPORT

I can respin patch #4. with these added in.

Quoted 6 lines

Quoted 3 lines

-#define CONFIG_OMAP_HSMMC
#define CONFIG_CMD_MMC

Same here..

ditto.

Quoted 6 lines

Quoted 3 lines

   /* GPIO block */

-#define CONFIG_OMAP_GPIO
#define CONFIG_CMD_GPIO

I believe currently keystone doesn't use GPIO, but this may change. Probably remove this as well for now and add it when GPIO is supported on K2.

patch #4:

(quoted diff) +3 -0

+/* And no support for GPIO, yet.. */
+#undef CONFIG_SPL_GPIO_SUPPORT
+#undef CONFIG_CMD_GPIO

idea being to have as many common definitions as possible and undef the ones we dont need as necessary. only thing i was careful here about was to try and remove all OMAP specific defines out.

CONFIG_LINUX_BOOT_PARAM_ADDR is not a valid configuration option. Do just like what the rest of the world does.

Suggested-by Tom Rini <[email protected]>

Signed-off-by Nishanth Menon <[email protected]>

---
New patch.

  board/ti/ks2_evm/board.c  | 2 +-
  include/configs/ks2_evm.h | 1 -
  2 files changed, 1 insertion(+), 2 deletions(-)

board/ti/ks2_evm/board.c +1 -1

index 8892a2843df4..0cefb3404403 100644
@@ -48,7 +48,7 @@ int dram_init(void)
 
  int board_init(void)
  {
-	gd->bd->bi_boot_params = CONFIG_LINUX_BOOT_PARAM_ADDR;
+	gd->bd->bi_boot_params = CONFIG_SYS_SDRAM_BASE + 0x100;
 
  	return 0;
  }

include/configs/ks2_evm.h +0 -0

index e05d56cd8262..d838f270018b 100644

Quoted 36 lines · Nishanth Menon

CONFIG_LINUX_BOOT_PARAM_ADDR is not a valid configuration option. Do just like what the rest of the world does.

Suggested-by Tom Rini <[email protected]>

Signed-off-by Nishanth Menon <[email protected]>

---
New patch.

  board/ti/ks2_evm/board.c  | 2 +-
  include/configs/ks2_evm.h | 1 -
  2 files changed, 1 insertion(+), 2 deletions(-)

board/ti/ks2_evm/board.c +1 -1

index 8892a2843df4..0cefb3404403 100644
@@ -48,7 +48,7 @@ int dram_init(void)
 
  int board_init(void)
  {
-    gd->bd->bi_boot_params = CONFIG_LINUX_BOOT_PARAM_ADDR;
+    gd->bd->bi_boot_params = CONFIG_SYS_SDRAM_BASE + 0x100;
 
      return 0;
  }

include/configs/ks2_evm.h +0 -1

index e05d56cd8262..d838f270018b 100644
@@ -307,7 +307,6 @@
  #define CONFIG_OF_BOARD_SETUP
  #define CONFIG_SYS_BARGSIZE        1024
  #define CONFIG_SYS_LOAD_ADDR        (CONFIG_SYS_SDRAM_BASE +
 0x08000000)
-#define CONFIG_LINUX_BOOT_PARAM_ADDR    (CONFIG_SYS_SDRAM_BASE + 0x100)
 

include/configs/ks2_evm.h line 311

Quoted 3 lines

include/configs/ks2_evm.h +0 -0

  #define CONFIG_SUPPORT_RAW_INITRD

Acked-by Murali Karicheri <[email protected]>

Quoted 52 lines · Nishanth Menon

rename the keystone2 common header into an keystone2 architecture specific header which can then reuse the common ti_armv7 config headers.

Signed-off-by Nishanth Menon <[email protected]>

---
no change
V1: https://patchwork.ozlabs.org/patch/496728/

  include/configs/k2e_evm.h                           | 2 +-
  include/configs/k2hk_evm.h                          | 2 +-
  include/configs/k2l_evm.h                           | 2 +-
  include/configs/{ks2_evm.h => ti_armv7_keystone2.h} | 0
  4 files changed, 3 insertions(+), 3 deletions(-)

rename include/configs/{ks2_evm.h => ti_armv7_keystone2.h} (100%)

include/configs/k2e_evm.h +1 -1

index a28ceb7064a7..ac50a01b2980 100644
@@ -27,7 +27,7 @@
      "name_uboot=u-boot-spi-k2e-evm.gph\0"                \
      "name_fs=arago-console-image-k2e-evm.cpio.gz\0"
 
-#include <configs/ks2_evm.h>
+#include <configs/ti_armv7_keystone2.h>
 
  /* SPL SPI Loader Configuration */
  #define CONFIG_SPL_TEXT_BASE           0x0c100000

include/configs/k2hk_evm.h +1 -1

index eae772178338..29e3403aa082 100644
@@ -27,7 +27,7 @@
      "name_uboot=u-boot-spi-k2hk-evm.gph\0"                \
      "name_fs=arago-console-image-k2hk-evm.cpio.gz\0"
 
-#include <configs/ks2_evm.h>
+#include <configs/ti_armv7_keystone2.h>
 
  /* SPL SPI Loader Configuration */
  #define CONFIG_SPL_TEXT_BASE        0x0c200000

include/configs/k2l_evm.h +1 -1

index 57da0579255a..50d5c991a0bb 100644
@@ -27,7 +27,7 @@
      "name_uboot=u-boot-spi-k2l-evm.gph\0"                \
      "name_fs=arago-console-image-k2l-evm.cpio.gz\0"
 
-#include <configs/ks2_evm.h>
+#include <configs/ti_armv7_keystone2.h>
 

include/configs/ti_armv7_keystone2.h

Quoted 8 lines

include/configs/k2l_evm.h +0 -0

  /* SPL SPI Loader Configuration */
  #define CONFIG_SPL_TEXT_BASE        0x0c100000

include/configs/ti_armv7_keystone2.h renamed from include/configs/ks2_evm.h +0 -0

similarity index 100%
rename from include/configs/ks2_evm.h
rename to include/configs/ti_armv7_keystone2.h

Acked-by Murali Karicheri <[email protected]>

Try to maintain as much commonality by conditionally including stuff in armv7_common as necessary and removing the common defines from keystone2 header.

Signed-off-by Nishanth Menon <[email protected]>

---
Changes in V2:
- common CONFIG_SYS_SDRAM_BASE
- common CONFIG_SYS_LOAD_ADDR
- rebased to new series

V1: https://patchwork.ozlabs.org/patch/496730/

  include/configs/k2e_evm.h            |  2 --
  include/configs/k2hk_evm.h           |  2 --
  include/configs/k2l_evm.h            |  2 --
  include/configs/ti_armv7_common.h    |  6 ++++-
  include/configs/ti_armv7_keystone2.h | 52 +++++++++++-------------------------
  5 files changed, 20 insertions(+), 44 deletions(-)

include/configs/k2e_evm.h +0 -0

index ac50a01b2980..f1e650141ae1 100644

include/configs/k2hk_evm.h +0 -1

-
  #define CONFIG_EXTRA_ENV_KS2_BOARD_SETTINGS				\
  	"addr_mon=0x0c5f0000\0"						\
  	"args_ubi=setenv bootargs ${bootargs} rootfstype=ubifs "	\

include/configs/k2l_evm.h +0 -0

index 50d5c991a0bb..395608a5f6db 100644

include/configs/ti_armv7_common.h +4 -1

  #define CONFIG_SYS_SDRAM_BASE		0x80000000
+
+#ifndef CONFIG_SYS_INIT_SP_ADDR
  #define CONFIG_SYS_INIT_SP_ADDR         (NON_SECURE_SRAM_END - \
  						GENERATED_GBL_DATA_SIZE)
+#endif
 
  /* Timer information. */
  #define CONFIG_SYS_PTV			2	/* Divisor: 2^(PTV+1) => 8 */

@@ -140,7 +144,7 @@
   * mtdparts, both for ease of use in U-Boot and for passing information
   * on to the Linux kernel.
   */
-#if defined(CONFIG_SPI_BOOT) || defined(CONFIG_NOR) || defined(CONFIG_NAND)
+#if defined(CONFIG_SPI_BOOT) || defined(CONFIG_NOR) || defined(CONFIG_NAND) || defined(CONFIG_NAND_DAVINCI)
  #define CONFIG_MTD_DEVICE		/* Required for mtdparts */
  #define CONFIG_CMD_MTDPARTS
  #endif

include/configs/ti_armv7_keystone2.h +8 -37

index d838f270018b..7d89bd78e43b 100644
@@ -14,10 +14,7 @@
 
  /* U-Boot Build Configuration */
  #define CONFIG_SKIP_LOWLEVEL_INIT	/* U-Boot is a 2nd stage loader */
-#define CONFIG_SYS_NO_FLASH		/* that is, no *NOR* flash */
-#define CONFIG_SYS_CONSOLE_INFO_QUIET
  #define CONFIG_BOARD_EARLY_INIT_F
-#define CONFIG_SYS_THUMB_BUILD
 
  /* SoC Configuration */
  #define CONFIG_ARCH_CPU_INIT

@@ -28,11 +25,9 @@
 
  /* Memory Configuration */
  #define CONFIG_NR_DRAM_BANKS		2
-#define CONFIG_SYS_SDRAM_BASE		0x80000000
  #define CONFIG_SYS_LPAE_SDRAM_BASE	0x800000000
  #define CONFIG_MAX_RAM_BANK_SIZE	(2 << 30)       /* 2GB */
  #define CONFIG_STACKSIZE		(512 << 10)     /* 512 KiB */
-#define CONFIG_SYS_MALLOC_LEN		(4 << 20)       /* 4 MiB */
  #define CONFIG_SYS_INIT_SP_ADDR		(CONFIG_SYS_TEXT_BASE - \
  					GENERATED_GBL_DATA_SIZE)
 

@@ -49,15 +44,10 @@
  #define CONFIG_SPL_STACK		(CONFIG_SYS_SPL_MALLOC_START + \
  					CONFIG_SYS_SPL_MALLOC_SIZE + \
  					CONFIG_SPL_STACK_SIZE - 4)
-#define CONFIG_SPL_LIBCOMMON_SUPPORT
-#define CONFIG_SPL_LIBGENERIC_SUPPORT
-#define CONFIG_SPL_SERIAL_SUPPORT
  #define CONFIG_SPL_SPI_FLASH_SUPPORT
  #define CONFIG_SPL_SPI_SUPPORT
-#define CONFIG_SPL_BOARD_INIT
  #define CONFIG_SPL_SPI_LOAD
  #define CONFIG_SYS_SPI_U_BOOT_OFFS	CONFIG_SPL_PAD_TO
-#define CONFIG_SPL_FRAMEWORK
 
  /* UART Configuration */
  #define CONFIG_SYS_NS16550

@@ -68,13 +58,10 @@
  #define CONFIG_SYS_NS16550_COM2		KS2_UART1_BASE
  #define CONFIG_SYS_NS16550_CLK		clk_get_rate(KS2_CLK1_6)
  #define CONFIG_CONS_INDEX		1
-#define CONFIG_BAUDRATE			115200
 
  /* SPI Configuration */
-#define CONFIG_SPI
  #define CONFIG_SPI_FLASH_STMICRO
  #define CONFIG_DAVINCI_SPI
-#define CONFIG_CMD_SPI
  #define CONFIG_SYS_SPI_CLK		clk_get_rate(KS2_CLK1_6)
  #define CONFIG_SF_DEFAULT_SPEED		30000000
  #define CONFIG_ENV_SPI_MAX_HZ		CONFIG_SF_DEFAULT_SPEED

@@ -148,7 +135,6 @@
  #define CONFIG_AEMIF_CNTRL_BASE		KS2_AEMIF_CNTRL_BASE
 
  /* I2C Configuration */
-#define CONFIG_SYS_I2C
  #define CONFIG_SYS_I2C_DAVINCI
  #define CONFIG_SYS_DAVINCI_I2C_SPEED	100000
  #define CONFIG_SYS_DAVINCI_I2C_SLAVE	0x10 /* SMBus host address */

@@ -185,7 +171,6 @@
  #define CONFIG_ENV_IS_IN_NAND
  #define CONFIG_ENV_OFFSET			0x100000
  #define CONFIG_MTD_PARTITIONS
-#define CONFIG_MTD_DEVICE
  #define CONFIG_RBTREE
  #define CONFIG_LZO
  #define MTDIDS_DEFAULT			"nand0=davinci_nand.0"

@@ -197,8 +182,6 @@
  #define CONFIG_USB_XHCI
  #define CONFIG_USB_XHCI_KEYSTONE
  #define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS	2
-#define CONFIG_USB_STORAGE
-#define CONFIG_DOS_PARTITION
  #define CONFIG_EFI_PARTITION
  #define CONFIG_FS_FAT
  #define CONFIG_SYS_CACHELINE_SIZE		64

@@ -208,39 +191,25 @@
  #define CONFIG_USB_PHY_CFG_BASE			KS2_USB_PHY_CFG_BASE
 
  /* U-Boot command configuration */
-#define CONFIG_CMD_ASKENV
  #define CONFIG_CMD_DHCP
-#define CONFIG_CMD_I2C
  #define CONFIG_CMD_PING
  #define CONFIG_CMD_SAVES
-#define CONFIG_CMD_MTDPARTS
  #define CONFIG_CMD_NAND
  #define CONFIG_CMD_UBI
  #define CONFIG_CMD_UBIFS
  #define CONFIG_CMD_SF
  #define CONFIG_CMD_EEPROM
  #define CONFIG_CMD_USB
-#define CONFIG_CMD_FAT
-#define CONFIG_CMD_FS_GENERIC
 
  /* U-Boot general configuration */
-#define CONFIG_SYS_GENERIC_BOARD
  #define CONFIG_MISC_INIT_R
-#define CONFIG_SYS_CBSIZE		1024
-#define CONFIG_SYS_PBSIZE		2048
-#define CONFIG_SYS_MAXARGS		16
-#define CONFIG_SYS_HUSH_PARSER
-#define CONFIG_SYS_LONGHELP
  #define CONFIG_CRC32_VERIFY
  #define CONFIG_MX_CYCLIC
-#define CONFIG_CMDLINE_EDITING
-#define CONFIG_VERSION_VARIABLE
  #define CONFIG_TIMESTAMP
 
  /* EDMA3 */
  #define CONFIG_TI_EDMA3
 
-#define CONFIG_BOOTDELAY		3
  #define CONFIG_BOOTFILE			"uImage"
  #define CONFIG_EXTRA_ENV_SETTINGS					\
  	CONFIG_EXTRA_ENV_KS2_BOARD_SETTINGS				\

@@ -301,14 +270,23 @@
  #define CONFIG_BOOTARGS							\
 
  /* Linux interfacing */
-#define CONFIG_CMDLINE_TAG
-#define CONFIG_SETUP_MEMORY_TAGS
-#define CONFIG_OF_LIBFDT		1
  #define CONFIG_OF_BOARD_SETUP
-#define CONFIG_SYS_BARGSIZE		1024
-#define CONFIG_SYS_LOAD_ADDR		(CONFIG_SYS_SDRAM_BASE + 0x08000000)
 
-#define CONFIG_SUPPORT_RAW_INITRD
+
+/* Now for the remaining common defines */
+#include <configs/ti_armv7_common.h>
+
+/* We wont be loading up OS from SPL for now.. */
+#undef CONFIG_SPL_OS_BOOT
+/* We do not have MMC SPL support.. yet.. */
+#undef CONFIG_SPL_LIBDISK_SUPPORT

Quoted 4 lines · Nishanth Menon

Try to maintain as much commonality by conditionally including stuff in armv7_common as necessary and removing the common defines from keystone2 header.

Including the common ti_armv7_common.h for keystone also add duplication of the various addresses

#define DEFAULT_LINUX_BOOT_ENV \
    "loadaddr=0x82000000\0" \
    "kernel_addr_r=0x82000000\0" \
    "fdtaddr=0x88000000\0" \
    "fdt_addr_r=0x88000000\0" \
    "rdaddr=0x88080000\0" \
    "ramdisk_addr_r=0x88080000\0" \
    "bootm_size=0x10000000\0"

Some of these are also defined in keystone common file. The env scripts for keystone to be reworked to use the common variable above.

Rework the CONFIG_EXTRA_ENV_KS2_BOARD_SETTINGS to include common as well.

Did you do a test with env default -f -a with this to check if it continues to work for Keystone Linux boot.

Quoted 8 lines

include/configs/k2e_evm.h +0 -0

index ac50a01b2980..f1e650141ae1 100644
@@ -15,8 +15,6 @@
  #define CONFIG_K2E_EVM
 

include/configs/k2e_evm.h line 18

Quoted 2 lines

include/configs/k2e_evm.h +0 -1

  /* U-Boot general configuration */
-#define CONFIG_SYS_PROMPT               "K2E EVM # "

Why remove this?

Quoted 6 lines

include/configs/k2e_evm.h +0 -0

  #define CONFIG_EXTRA_ENV_KS2_BOARD_SETTINGS                \
      "addr_mon=0x0c140000\0"                        \
      "args_ubi=setenv bootargs ${bootargs} rootfstype=ubifs "    \

include/configs/ti_armv7_common.h +0 -0

index 63244dbc83ff..814da3409c46 100644

include/configs/ti_armv7_common.h line 76

Quoted 7 lines

include/configs/ti_armv7_common.h +1 -0

@@ -73,9 +73,13 @@
  #ifndef CONFIG_NR_DRAM_BANKS
  #define CONFIG_NR_DRAM_BANKS        1
  #endif
+

Why these extra spaces?

I assume the one you have removed is already part of include/configs/ti_armv7_keystone2.h.

Quoted 17 lines · Murali Karicheri

Quoted 4 lines · Nishanth Menon

Try to maintain as much commonality by conditionally including stuff in armv7_common as necessary and removing the common defines from keystone2 header.

Including the common ti_armv7_common.h for keystone also add duplication of the various addresses

#define DEFAULT_LINUX_BOOT_ENV \
     "loadaddr=0x82000000\0" \
     "kernel_addr_r=0x82000000\0" \
     "fdtaddr=0x88000000\0" \
     "fdt_addr_r=0x88000000\0" \
     "rdaddr=0x88080000\0" \
     "ramdisk_addr_r=0x88080000\0" \
     "bootm_size=0x10000000\0"

Quoted 4 lines

Some of these are also defined in keystone common file. The env scripts for keystone to be reworked to use the common variable above.

Rework the CONFIG_EXTRA_ENV_KS2_BOARD_SETTINGS to include common as well.

we need to cleanup all the variables once we get the distro config

included in anyways... I had decided not to rock the apple cart too much with this patch -> just the basic consolidation with as minimal changes as necessary. inclusion of DEFAULT_LINUX_BOOT_ENV into keystone2.h can be done as a follow on patch.

Quoted 4 lines

Did you do a test with env default -f -a with this to check if it continues to work for Keystone Linux boot.

after the series: http://pastebin.ubuntu.com/11893531/
before the series: http://pastebin.ubuntu.com/11893576/
deltas:
bootdelay is 1 now
additional definitions:
arch=arm
soc=keystone
vendor=ti
cpu=armv7
board=ks2_evm
board_name=ks2_evm

will be great to get a tested by on that. Nothing else seems to have changed.

Quoted 8 lines

Quoted 8 lines

include/configs/k2e_evm.h +0 -0

index ac50a01b2980..f1e650141ae1 100644
@@ -15,8 +15,6 @@
   #define CONFIG_K2E_EVM
 

Quoted 4 lines

include/configs/k2e_evm.h line 18

Quoted 2 lines

include/configs/k2e_evm.h +0 -1

   /* U-Boot general configuration */
-#define CONFIG_SYS_PROMPT               "K2E EVM # "

Why remove this?

arm_v7_common defines just "u-boot#" for all SoC and boards. So, we dont need this.

Quoted 15 lines

Quoted 10 lines

include/configs/k2e_evm.h +0 -0

   #define CONFIG_EXTRA_ENV_KS2_BOARD_SETTINGS                \
       "addr_mon=0x0c140000\0"                        \
       "args_ubi=setenv bootargs ${bootargs} rootfstype=ubifs "    \

include/configs/ti_armv7_common.h +0 -0

index 63244dbc83ff..814da3409c46 100644

include/configs/ti_armv7_common.h line 76

Quoted 4 lines

include/configs/ti_armv7_common.h +1 -0

@@ -73,9 +73,13 @@
   #ifndef CONFIG_NR_DRAM_BANKS
   #define CONFIG_NR_DRAM_BANKS        1
   #endif
+

Why these extra spaces?

Thanks.. will drop.

Quoted 2 lines

I assume the one you have removed is already part of include/configs/ti_armv7_keystone2.h.

for i in git grep "^#define" include/configs/ti_armv7_keystone2.h|sed -e "s/\s\s*/ /g"|cut -d ' ' -f2|sort|uniq; do k=git grep $i include/configs/ti_armv7_common.h; if [ -n "$k" ]; then echo $i; fi; done

Then started cleaning them up.

Quoted 21 lines · Nishanth Menon

Quoted 20 lines · Murali Karicheri

Quoted 4 lines · Nishanth Menon

Try to maintain as much commonality by conditionally including stuff in armv7_common as necessary and removing the common defines from keystone2 header.

Including the common ti_armv7_common.h for keystone also add duplication of the various addresses

#define DEFAULT_LINUX_BOOT_ENV \
     "loadaddr=0x82000000\0" \
     "kernel_addr_r=0x82000000\0" \
     "fdtaddr=0x88000000\0" \
     "fdt_addr_r=0x88000000\0" \
     "rdaddr=0x88080000\0" \
     "ramdisk_addr_r=0x88080000\0" \
     "bootm_size=0x10000000\0"

Some of these are also defined in keystone common file. The env scripts for keystone to be reworked to use the common variable above.

Quoted 4 lines

Quoted 2 lines

Rework the CONFIG_EXTRA_ENV_KS2_BOARD_SETTINGS to include common as well.

we need to cleanup all the variables once we get the distro config

What do you mean by distro config? Could you explain?

Quoted 5 lines

included in anyways... I had decided not to rock the apple cart too much with this patch -> just the basic consolidation with as minimal changes as necessary. inclusion of DEFAULT_LINUX_BOOT_ENV into keystone2.h can be done as a follow on patch.

Probably not this one. User would see both these variables and will cause confusion and should be fixed.

Quoted 14 lines

Quoted 13 lines

include/configs/k2e_evm.h line 18

Quoted 11 lines

include/configs/k2e_evm.h +0 -1

index ac50a01b2980..f1e650141ae1 100644
@@ -15,8 +15,6 @@
   #define CONFIG_K2E_EVM
 
   /* U-Boot general configuration */
-#define CONFIG_SYS_PROMPT               "K2E EVM # "

Why remove this?

Quoted 2 lines

arm_v7_common defines just "u-boot#" for all SoC and boards. So, we dont need this.

Sorry, this may be needed from the automation perspective. Also for backward compatibility for users. Would like to keep for K2.

Quoted 25 lines · Murali Karicheri

Quoted 24 lines · Nishanth Menon

Quoted 22 lines · Murali Karicheri

Quoted 4 lines · Nishanth Menon

Try to maintain as much commonality by conditionally including stuff in armv7_common as necessary and removing the common defines from keystone2 header.

Including the common ti_armv7_common.h for keystone also add duplication of the various addresses

#define DEFAULT_LINUX_BOOT_ENV \
      "loadaddr=0x82000000\0" \
      "kernel_addr_r=0x82000000\0" \
      "fdtaddr=0x88000000\0" \
      "fdt_addr_r=0x88000000\0" \
      "rdaddr=0x88080000\0" \
      "ramdisk_addr_r=0x88080000\0" \
      "bootm_size=0x10000000\0"

Some of these are also defined in keystone common file. The env scripts for keystone to be reworked to use the common variable above.

Rework the CONFIG_EXTRA_ENV_KS2_BOARD_SETTINGS to include common as well.

Quoted 3 lines

Quoted 1 line

we need to cleanup all the variables once we get the distro config

What do you mean by distro config? Could you explain?

include/config_distro* - both will eventually get integrated into armv7_common.h to benefit all TI SoC platforms.

Quoted 7 lines

Quoted 6 lines

included in anyways... I had decided not to rock the apple cart too much with this patch -> just the basic consolidation with as minimal changes as necessary. inclusion of DEFAULT_LINUX_BOOT_ENV into keystone2.h can be done as a follow on patch.

Quoted 3 lines

Probably not this one. User would see both these variables and will cause confusion and should be fixed.

they are no variables, they are defines. they will eventually be fixed.

I am leery to make a huge jump on a single series. lets do consolidation in small baby steps please.

as I have already shown in my reply - the status quo is being maintained and we are one step closer to an common framework.

Quoted 15 lines

Quoted 15 lines

Quoted 14 lines

include/configs/k2e_evm.h line 18

Quoted 12 lines

include/configs/k2e_evm.h +0 -1

index ac50a01b2980..f1e650141ae1 100644
@@ -15,8 +15,6 @@
    #define CONFIG_K2E_EVM
 
    /* U-Boot general configuration */
-#define CONFIG_SYS_PROMPT               "K2E EVM # "

Why remove this?

Quoted 5 lines

Quoted 2 lines

arm_v7_common defines just "u-boot#" for all SoC and boards. So, we dont need this.

Sorry, this may be needed from the automation perspective. Also for backward compatibility for users. Would like to keep for K2.

This has been beaten to death in the past as well (I think some 3/4 years ago.. i think it should be in the archives, just too lazy to dig through multi-year old discussions)..

I will let Tom comment more here. My understanding is that the convention followed by all other TI SoCs will imply not having custom sys_prompt..

That said, custom sys_prompt is NOT a need from automation perspective - we have all our boards in automation farm for years now with and without custom boot prompt. board identification can be done in other ways.

Quoted 28 lines · Nishanth Menon

Quoted 27 lines · Murali Karicheri

Quoted 25 lines · Nishanth Menon

Quoted 17 lines · Murali Karicheri

Quoted 4 lines · Nishanth Menon

Try to maintain as much commonality by conditionally including stuff in armv7_common as necessary and removing the common defines from keystone2 header.

Including the common ti_armv7_common.h for keystone also add duplication of the various addresses

#define DEFAULT_LINUX_BOOT_ENV \
     "loadaddr=0x82000000\0" \
     "kernel_addr_r=0x82000000\0" \
     "fdtaddr=0x88000000\0" \
     "fdt_addr_r=0x88000000\0" \
     "rdaddr=0x88080000\0" \
     "ramdisk_addr_r=0x88080000\0" \
     "bootm_size=0x10000000\0"

Quoted 5 lines

Some of these are also defined in keystone common file. The env scripts for keystone to be reworked to use the common variable above.

Rework the CONFIG_EXTRA_ENV_KS2_BOARD_SETTINGS to include common as well.

we need to cleanup all the variables once we get the distro config

Quoted 4 lines

Quoted 1 line

What do you mean by distro config? Could you explain?

include/config_distro* - both will eventually get integrated into armv7_common.h to benefit all TI SoC platforms.

Ok I see. But that doesn't mean we can accept duplicate env variables. Do you see my point?

Quoted 5 lines

Quoted 5 lines

Quoted 4 lines

included in anyways... I had decided not to rock the apple cart too much with this patch -> just the basic consolidation with as minimal changes as necessary. inclusion of DEFAULT_LINUX_BOOT_ENV into keystone2.h can be done as a follow on patch.

Quoted 5 lines

Quoted 3 lines

Probably not this one. User would see both these variables and will cause confusion and should be fixed.

they are no variables, they are defines. they will eventually be fixed.

The defines finally create env variables on NAND or any other medium :) So my comment stays.

Quoted 5 lines

I am leery to make a huge jump on a single series. lets do consolidation in small baby steps please.

as I have already shown in my reply - the status quo is being maintained and we are one step closer to an common framework.

Ok. If this happens soon (within a month) I am fine with this. Otherwise, this could go under the radar and cause maintenance issue.

Quoted 30 lines

Quoted 15 lines

Quoted 15 lines

Quoted 14 lines

include/configs/k2e_evm.h line 18

Quoted 12 lines

include/configs/k2e_evm.h +0 -1

index ac50a01b2980..f1e650141ae1 100644
@@ -15,8 +15,6 @@
   #define CONFIG_K2E_EVM
 
   /* U-Boot general configuration */
-#define CONFIG_SYS_PROMPT               "K2E EVM # "

Why remove this?

Quoted 5 lines

Quoted 2 lines

arm_v7_common defines just "u-boot#" for all SoC and boards. So, we dont need this.

Sorry, this may be needed from the automation perspective. Also for backward compatibility for users. Would like to keep for K2.

This has been beaten to death in the past as well (I think some 3/4 years ago.. i think it should be in the archives, just too lazy to dig through multi-year old discussions)..

I will let Tom comment more here. My understanding is that the convention followed by all other TI SoCs will imply not having custom sys_prompt..

Quoted 3 lines

That said, custom sys_prompt is NOT a need from automation perspective - we have all our boards in automation farm for years now with and without custom boot prompt. board identification can be done in other ways.

From a users perspective as well, it is good to know which board I am working with when I work with multiple boards. Not sure what is the argument not to have a board specific prompt at u-boot level. Definitely like to hear from Tom.