ARM: tegra: Add Tegra20 SPI device nodes
Subsystems (2)
PATCH v2 1/1 ARM: tegra: Add Tegra20 SPI device nodes
From: Mirza Krak <[email protected]>
Add the device tree node for the SPI controllers found on Tegra20 SOCs.
---
Changes in v2:
* Dropped tegra30-slink compatible string, based on comment from Thierry Reding on v1 patch
arch/arm/dts/tegra20.dtsi | 44 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+)
arch/arm/dts/tegra20.dtsi +44 -0
@@ -268,6 +268,50 @@ #pwm-cells = <2>; }; + spi at 7000d400 { + compatible = "nvidia,tegra20-slink"; + reg = <0x7000d400 0x200>; + interrupts = <0 59 0x04>; + nvidia,dma-request-selector = <&apbdma 15>; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&tegra_car 41>; + status = "disabled"; + }; + + spi at 7000d600 { + compatible = "nvidia,tegra20-slink"; + reg = <0x7000d600 0x200>; + interrupts = <0 82 0x04>; + nvidia,dma-request-selector = <&apbdma 16>; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&tegra_car 44>; + status = "disabled"; + }; + + spi at 7000d800 { + compatible = "nvidia,tegra20-slink"; + reg = <0x7000d480 0x200>; + interrupts = <0 83 0x04>; + nvidia,dma-request-selector = <&apbdma 17>; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&tegra_car 46>; + status = "disabled"; + }; + + spi at 7000da00 { + compatible = "nvidia,tegra20-slink"; + reg = <0x7000da00 0x200>; + interrupts = <0 93 0x04>; + nvidia,dma-request-selector = <&apbdma 18>; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&tegra_car 68>; + status = "disabled"; + }; + i2c at 7000c000 { #address-cells = <1>; #size-cells = <0>;
--
2.1.0
PATCH v2 1/1 ARM: tegra: Add Tegra20 SPI device nodes
arch/arm/dts/tegra20.dtsi line 275
Quoted 11 lines · Mirza Krak
From: Mirza Krak <[email protected]>
Add the device tree node for the SPI controllers found on Tegra20 SOCs.
arch/arm/dts/tegra20.dtsi +5
-0+ spi at 7000d400 { + compatible = "nvidia,tegra20-slink"; + reg = <0x7000d400 0x200>; + interrupts = <0 59 0x04>; + nvidia,dma-request-selector = <&apbdma 15>;
That property doesn't seem to exist in the kernel DT, and "resets", "reset-names", "dmas", "dma-names" are missing. I'd suggest simply cutting/pasting from the kernel DT to make sure they stay in sync.
interrupts and clocks should also use the #defines to provide named constants for better readability and the same consistency reasons.
PATCH v2 1/1 ARM: tegra: Add Tegra20 SPI device nodes
Hi,
Quoted 17 lines · Stephen Warren
Quoted 7 lines · Mirza Krak
From: Mirza Krak <[email protected]>
Add the device tree node for the SPI controllers found on Tegra20 SOCs.
arch/arm/dts/tegra20.dtsi line 275
Quoted 7 lines
arch/arm/dts/tegra20.dtsi +5
-0+ spi at 7000d400 { + compatible = "nvidia,tegra20-slink"; + reg = <0x7000d400 0x200>; + interrupts = <0 59 0x04>; + nvidia,dma-request-selector = <&apbdma 15>;
Quoted 6 lines
That property doesn't seem to exist in the kernel DT, and "resets", "reset-names", "dmas", "dma-names" are missing. I'd suggest simply cutting/pasting from the kernel DT to make sure they stay in sync.
interrupts and clocks should also use the #defines to provide named constants for better readability and the same consistency reasons.
Also it's pretty easy to just copy over the kernel files. They should just work!
Regards,
Simon
PATCH v2 1/1 ARM: tegra: Add Tegra20 SPI device nodes
2015-07-21 22:28 GMT+02:00 Simon Glass <[email protected]>:
Quoted 7 lines
Hi
Also it's pretty easy to just copy over the kernel files. They should just work!
Regards,
Simon
Ok, will give it a go then.
Signature · 14 lines
Med V?nliga H?lsningar / Best Regards ******************************************************************* Mirza Krak Host Mobility AB mirza.krak at hostmobility.com Anders Personsgatan 12, 416 64 G?teborg Sweden http://www.hostmobility.com Direct: +46 31 31 32 704 Phone: +46 31 31 32 700 Fax: +46 31 80 67 51 Mobile: +46 730 28 06 22 *******************************************************************