Skip to contentSkip to conversation

ARM: dts: i.MX35: Fix can support

PATCH Superseded Denis Carikli 5 participants 8 messages Jul 22, 2015 – Jul 25, 2015

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Denis Carikli

author
#0 lore raw

PATCH 1/1 ARM: dts: i.MX35: Fix can support

Signed-off-by Denis Carikli <[email protected]>
---
 arch/arm/boot/dts/imx35.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/imx35.dtsi +4 -4
index b6478e9..e6540b5 100644
@@ -286,8 +286,8 @@
 			can1: can at 53fe4000 {
 				compatible = "fsl,imx35-flexcan", "fsl,p1010-flexcan";
 				reg = <0x53fe4000 0x1000>;
-				clocks = <&clks 33>;
-				clock-names = "ipg";
+				clocks = <&clks 33>, <&clks 33>;
+				clock-names = "ipg", "per";
 				interrupts = <43>;
 				status = "disabled";
 			};

@@ -295,8 +295,8 @@
 			can2: can at 53fe8000 {
 				compatible = "fsl,imx35-flexcan", "fsl,p1010-flexcan";
 				reg = <0x53fe8000 0x1000>;
-				clocks = <&clks 34>;
-				clock-names = "ipg";
+				clocks = <&clks 34>, <&clks 34>;
+				clock-names = "ipg", "per";
 				interrupts = <44>;
 				status = "disabled";
 			};
Signature · 1 line
2.4.5
#1 lore raw

PATCH 1/1 ARM: dts: i.MX35: Fix can support

Hello,

Quoted 1 line · Denis Carikli
Signed-off-by Denis Carikli <[email protected]>

something like:

Since commit 23147826523 ("asjksad dsajksdkljf") the can driver requires a dt nodes to have a second clock. Add them to imx35 to fix probing the flex can driver on the respective platforms.

in the changelog would be nice.

Best regards,
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
author
#2 lore raw

PATCH v2 1/1 ARM: dts: i.MX35: Fix can support.

Since commit 3d42a379b6fa5b46058e3302b1802b29f64865bb ("can: flexcan: add 2nd clock to support imx53 and newer") the can driver requires a dt nodes to have a second clock. Add them to imx35 to fix probing the flex can driver on the respective platforms.

Signed-off-by Denis Carikli <[email protected]>
---
 arch/arm/boot/dts/imx35.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/imx35.dtsi +4 -4
index b6478e9..e6540b5 100644
@@ -286,8 +286,8 @@
 			can1: can at 53fe4000 {
 				compatible = "fsl,imx35-flexcan", "fsl,p1010-flexcan";
 				reg = <0x53fe4000 0x1000>;
-				clocks = <&clks 33>;
-				clock-names = "ipg";
+				clocks = <&clks 33>, <&clks 33>;
+				clock-names = "ipg", "per";
 				interrupts = <43>;
 				status = "disabled";
 			};

@@ -295,8 +295,8 @@
 			can2: can at 53fe8000 {
 				compatible = "fsl,imx35-flexcan", "fsl,p1010-flexcan";
 				reg = <0x53fe8000 0x1000>;
-				clocks = <&clks 34>;
-				clock-names = "ipg";
+				clocks = <&clks 34>, <&clks 34>;
+				clock-names = "ipg", "per";
 				interrupts = <44>;
 				status = "disabled";
 			};
Signature · 1 line
2.4.5
#3 lore raw

PATCH v2 1/1 ARM: dts: i.MX35: Fix can support.

Hi Denis,

[ add Marc to CC ]

Am 23.07.2015 um 10:31 schrieb Denis Carikli:

Quoted 5 lines

Since commit 3d42a379b6fa5b46058e3302b1802b29f64865bb ("can: flexcan: add 2nd clock to support imx53 and newer") the can driver requires a dt nodes to have a second clock. Add them to imx35 to fix probing the flex can driver on the respective platforms.

could you describe the problem more in detail or do you have a log in case the probing failed?

According to Marc's commit this fix shouldn't be necessary.

Regards
Stefan

#4 lore raw

PATCH v2 1/1 ARM: dts: i.MX35: Fix can support.

Quoted 11 lines · Stefan Wahren

Hi Denis,

[ add Marc to CC ]

Am 23.07.2015 um 10:31 schrieb Denis Carikli:

Quoted 5 lines

Since commit 3d42a379b6fa5b46058e3302b1802b29f64865bb ("can: flexcan: add 2nd clock to support imx53 and newer") the can driver requires a dt nodes to have a second clock. Add them to imx35 to fix probing the flex can driver on the respective platforms.

Quoted 4 lines

could you describe the problem more in detail or do you have a log in case the probing failed?

According to Marc's commit this fix shouldn't be necessary.

In the pre DT era and without a clock name, a single clock is sufficient. But with clock name or DT with clock-name you need both a "ipg" and a "per" clock. The imx35.dtsi was added with one clock only, so it was probably never working on mx35 with DT.

Marc

Signature · 12 lines
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150723/5dca3f0e/attachment.sig>
#5 lore raw

PATCH v2 1/1 ARM: dts: i.MX35: Fix can support.

Am 23.07.2015 um 11:29 schrieb Marc Kleine-Budde:

Quoted 11 lines · Stefan Wahren
Quoted 10 lines

Hi Denis,

[ add Marc to CC ]

Am 23.07.2015 um 10:31 schrieb Denis Carikli:

Quoted 5 lines

Since commit 3d42a379b6fa5b46058e3302b1802b29f64865bb ("can: flexcan: add 2nd clock to support imx53 and newer") the can driver requires a dt nodes to have a second clock. Add them to imx35 to fix probing the flex can driver on the respective platforms.

Quoted 8 lines
Quoted 4 lines

could you describe the problem more in detail or do you have a log in case the probing failed?

According to Marc's commit this fix shouldn't be necessary.

In the pre DT era and without a clock name, a single clock is sufficient. But with clock name or DT with clock-name you need both a "ipg" and a "per" clock. The imx35.dtsi was added with one clock only, so it was probably never working on mx35 with DT.

Okay the other plaforms like mx25 and mx28 already had 2 clocks defined.

But why doesn't say the binding doc nothing about those required clocks?

Stefan

Quoted 3 lines

Marc

#6 lore raw

PATCH v2 1/1 ARM: dts: i.MX35: Fix can support.

Quoted 16 lines · Stefan Wahren

Am 23.07.2015 um 11:29 schrieb Marc Kleine-Budde:

Quoted 15 lines · Stefan Wahren
Quoted 14 lines

Hi Denis,

[ add Marc to CC ]

Am 23.07.2015 um 10:31 schrieb Denis Carikli:

Quoted 5 lines

Since commit 3d42a379b6fa5b46058e3302b1802b29f64865bb ("can: flexcan: add 2nd clock to support imx53 and newer") the can driver requires a dt nodes to have a second clock. Add them to imx35 to fix probing the flex can driver on the respective platforms.

could you describe the problem more in detail or do you have a log in case the probing failed?

According to Marc's commit this fix shouldn't be necessary.

Quoted 8 lines
Quoted 4 lines

In the pre DT era and without a clock name, a single clock is sufficient. But with clock name or DT with clock-name you need both a "ipg" and a "per" clock. The imx35.dtsi was added with one clock only, so it was probably never working on mx35 with DT.

Okay the other plaforms like mx25 and mx28 already had 2 clocks defined.

But why doesn't say the binding doc nothing about those required clocks?

Good question - Dokumentation bug...

Marc

Signature · 12 lines
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150723/c0a6912e/attachment.sig>
Applied
#7 lore raw

PATCH v2 1/1 ARM: dts: i.MX35: Fix can support.

In reply to Denis Carikli
Quoted 7 lines · Denis Carikli

Since commit 3d42a379b6fa5b46058e3302b1802b29f64865bb ("can: flexcan: add 2nd clock to support imx53 and newer") the can driver requires a dt nodes to have a second clock. Add them to imx35 to fix probing the flex can driver on the respective platforms.

Signed-off-by Denis Carikli <[email protected]>

Applied, thanks.