ARM: SAMSUNG: local regs-srom header in mach-exynos
Subsystems (3)
PATCH 1/12 ARM: SAMSUNG: local regs-srom header in mach-exynos
This patch moves regs-srom header file into mach-exynos.
c: Krzysztof Kozlowski <[email protected]>
---
arch/arm/{plat-samsung/include/plat => mach-exynos}/regs-srom.h | 3 +--
arch/arm/mach-exynos/suspend.c | 4 ++--
2 files changed, 3 insertions(+), 4 deletions(-)
rename arch/arm/{plat-samsung/include/plat => mach-exynos}/regs-srom.h (96%)arch/arm/mach-exynos/regs-srom.h renamed from arch/arm/plat-samsung/include/plat/regs-srom.h +1 -2
@@ -1,5 +1,4 @@ -/* linux/arch/arm/plat-samsung/include/plat/regs-srom.h -* +/* * Copyright (c) 2010 Samsung Electronics Co., Ltd. * http://www.samsung.com *
arch/arm/mach-exynos/suspend.c +2 -2
@@ -32,11 +32,11 @@#include <asm/suspend.h> #include <plat/pm-common.h> -#include <plat/regs-srom.h> #include "common.h" -#include "regs-pmu.h" #include "exynos-pmu.h" +#include "regs-pmu.h" +#include "regs-srom.h" #define REG_TABLE_END (-1U)
Signature · 1 line
2.0.0
Quoted 2 lines · Kukjin Kim
This patch moves regs-srom header file into mach-exynos.
Hi,
Minor nits:
1. Could you trim it and remove unnecessary empty line before description?
2. Could you answer in commit message: Why? Why are you moving the headers?
Quoted 2 lines
c: Krzysztof Kozlowski <[email protected]>
Malformed "Cc:" tag.
Best regards,
Krzysztof
Quoted 40 lines
Signed-off-by Kukjin Kim <[email protected]>--- arch/arm/{plat-samsung/include/plat => mach-exynos}/regs-srom.h | 3 +-- arch/arm/mach-exynos/suspend.c | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) rename arch/arm/{plat-samsung/include/plat => mach-exynos}/regs-srom.h (96%)arch/arm/mach-exynos/regs-srom.h renamed from arch/arm/plat-samsung/include/plat/regs-srom.h +1
-2@@ -1,5 +1,4 @@ -/* linux/arch/arm/plat-samsung/include/plat/regs-srom.h -* +/* * Copyright (c) 2010 Samsung Electronics Co., Ltd. * http://www.samsung.com * arch/arm/mach-exynos/suspend.c +2
-2@@ -32,11 +32,11 @@#include <asm/suspend.h> #include <plat/pm-common.h> -#include <plat/regs-srom.h> #include "common.h" -#include "regs-pmu.h" #include "exynos-pmu.h" +#include "regs-pmu.h" +#include "regs-srom.h" #define REG_TABLE_END (-1U)
Quoted 7 lines · Krzysztof Kozlowski
Quoted 2 lines · Kukjin Kim
This patch moves regs-srom header file into mach-exynos.
Hi,
Hi,
Quoted 2 lines
Minor nits:
1. Could you trim it and remove unnecessary empty line before description?
Yeah, actually I couldn't use git send-email when I submitted but just used e-mail. It should be fine in my local branch.
Quoted 2 lines
2. Could you answer in commit message: Why? Why are you moving the headers?
OK, basically we don't need to keep headers in <mach/xxx> and <plat/xxx> if it is not required. For example, actually common.h files in mach-xxxx/ have been made/moved because of the reason before. Someday we did because it was required to support multi_v7 as well. Anyway it is still required and note that I have some more patches to move headers which are used only for under drivers/ not arch side into drivers/. And next step is removing some definitions which are not used more.
Quoted 5 lines
Quoted 2 lines
c: Krzysztof Kozlowski <[email protected]>
Malformed "Cc:" tag.
Oh, OK. Thanks.
One more thing, please ignore patch "[09/12] ARM: SAMSUNG: local keypad header in mach-s3c64xx" in this series because the header is used in plat-samsung as well.
Anyway, thanks,
Kukjin