Skip to contentSkip to conversation

scsi: a100u2w: trivial typo in printk

PATCH In review Colin King 3 participants 4 messages Jul 29, 2015 – Jul 30, 2015

Subsystems (2)
SCSI PMC sierra MaxRAID driver
lore
Share & tools
lore

Colin King

author
#0 lore raw

PATCH 1/1 scsi: a100u2w: trivial typo in printk

From: Colin Ian King <[email protected]>

Trivial typo fix, \b should be \n

Signed-off-by Colin Ian King <[email protected]>
---
 drivers/scsi/a100u2w.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/a100u2w.c +1 -1
index cac6b37..8086bd0 100644
@@ -888,7 +888,7 @@ static int inia100_build_scb(struct orc_host * host, struct orc_scb * scb, struc
 	scb->sense_len = SENSE_SIZE;
 	scb->cdb_len = cmd->cmd_len;
 	if (scb->cdb_len >= IMAX_CDB) {
-		printk("max cdb length= %x\b", cmd->cmd_len);
+		printk("max cdb length= %x\n", cmd->cmd_len);
 		scb->cdb_len = IMAX_CDB;
 	}
 	scb->ident = (u8)(cmd->device->lun & 0xff) | DISC_ALLOW;
Signature · 1 line
2.4.6
#1 lore raw

PATCH 1/1 scsi: pmcraid: trivial typo in printk

Trivial typo fixes:

o \b should be \n
o coalesce format to avoid excess spaces

Signed-off-by Joe Perches <[email protected]>

---
And another here:

 drivers/scsi/pmcraid.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/scsi/pmcraid.c +2 -3
index ed31d8c..b421de2 100644
@@ -1558,8 +1558,7 @@ static void pmcraid_handle_config_change(struct pmcraid_instance *pinstance)
 	cfg_entry = &ccn_hcam->cfg_entry;
 	fw_version = be16_to_cpu(pinstance->inq_data->fw_version);
 
-	pmcraid_info("CCN(%x): %x timestamp: %llx type: %x lost: %x flags: %x \
-		 res: %x:%x:%x:%x\n",
+	pmcraid_info("CCN(%x): %x timestamp: %llx type: %x lost: %x flags: %x res: %x:%x:%x:%x\n",
 		 pinstance->ccn.hcam->ilid,
 		 pinstance->ccn.hcam->op_code,
 		((pinstance->ccn.hcam->timestamp1) |

@@ -1583,7 +1582,7 @@ static void pmcraid_handle_config_change(struct pmcraid_instance *pinstance)
 	if (pinstance->ccn.hcam->notification_lost) {
 		cfgcmd = pmcraid_get_free_cmd(pinstance);
 		if (cfgcmd) {
-			pmcraid_info("lost CCN, reading config table\b");
+			pmcraid_info("lost CCN, reading config table\n");
 			pinstance->reinit_cfg_table = 1;
 			pmcraid_querycfg(cfgcmd);
 		} else {
Reviewed-by on v1 1/1
#2 lore raw

Re: [PATCH] scsi: pmcraid: trivial typo in printk

Quoted 7 lines · Joe Perches

Trivial typo fixes:

o \b should be \n
o coalesce format to avoid excess spaces

Signed-off-by Joe Perches <[email protected]>

---

Reviewed-by Hannes Reinecke <[email protected]>

Cheers,

Hannes

Signature · 5 lines
Dr. Hannes Reinecke		               zSeries & Storage
[email protected]			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
Reviewed-by on v1 1/1
#3 lore raw
In reply to Colin King
Quoted 6 lines · Colin King

From: Colin Ian King <[email protected]>

Trivial typo fix, \b should be \n

Signed-off-by Colin Ian King <[email protected]>

---

Reviewed-by Hannes Reinecke <[email protected]>

Cheers,

Hannes

Signature · 5 lines
Dr. Hannes Reinecke		               zSeries & Storage
[email protected]			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)