arm:ls1021a: Reserve secure code into RAM instead of OCRAM

PATCH New Zhuoyu Zhang 3 participants 6 messages Mar 24, 2015 – Aug 4, 2015

lore

Share & tools

lore

Zhuoyu Zhang

author

2015-03-24 09:27 UTC #0 lore raw

PATCH 1/1 arm:ls1021a: Reserve secure code into RAM instead of OCRAM

For ls1021a, Reserve secure code in to memory in case OCRAM is needed by other usage.

Signed-off-by Zhuoyu Zhang <[email protected]>

---
 include/configs/ls1021aqds.h | 1 -
 include/configs/ls1021atwr.h | 1 -
 2 files changed, 2 deletions(-)

include/configs/ls1021aqds.h +0 -1

index 3dc4da3..42439a4 100644
@@ -554,7 +554,6 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_LS102XA_NS_ACCESS
 #define CONFIG_SMP_PEN_ADDR		0x01ee0200
 #define CONFIG_TIMER_CLK_FREQ		12500000
-#define CONFIG_ARMV7_SECURE_BASE	OCRAM_BASE_S_ADDR
 
 #define CONFIG_HWCONFIG
 #define HWCONFIG_BUFFER_SIZE		128

include/configs/ls1021atwr.h +0 -1

index a13876b..dccc661 100644
@@ -347,7 +347,6 @@
 #define CONFIG_LS102XA_NS_ACCESS
 #define CONFIG_SMP_PEN_ADDR		0x01ee0200
 #define CONFIG_TIMER_CLK_FREQ		12500000
-#define CONFIG_ARMV7_SECURE_BASE	OCRAM_BASE_S_ADDR
 
 #define CONFIG_HWCONFIG
 #define HWCONFIG_BUFFER_SIZE		128

Signature · 1 line

2.1.0.27.g96db324

York Sun

2015-04-16 20:02 UTC #1 lore raw

PATCH 1/1 arm:ls1021a: Reserve secure code into RAM instead of OCRAM

Quoted 27 lines · Zhuoyu Zhang

For ls1021a, Reserve secure code in to memory in case OCRAM is needed by other usage.

Signed-off-by Zhuoyu Zhang <[email protected]>

---
 include/configs/ls1021aqds.h | 1 -
 include/configs/ls1021atwr.h | 1 -
 2 files changed, 2 deletions(-)

include/configs/ls1021aqds.h +0 -1

index 3dc4da3..42439a4 100644
@@ -554,7 +554,6 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_LS102XA_NS_ACCESS
 #define CONFIG_SMP_PEN_ADDR		0x01ee0200
 #define CONFIG_TIMER_CLK_FREQ		12500000
-#define CONFIG_ARMV7_SECURE_BASE	OCRAM_BASE_S_ADDR
 
 #define CONFIG_HWCONFIG
 #define HWCONFIG_BUFFER_SIZE		128

include/configs/ls1021atwr.h +0 -0

index a13876b..dccc661 100644

include/configs/ls1021atwr.h line 352

Quoted 7 lines

include/configs/ls1021atwr.h +0 -1

@@ -347,7 +347,6 @@
 #define CONFIG_LS102XA_NS_ACCESS
 #define CONFIG_SMP_PEN_ADDR		0x01ee0200
 #define CONFIG_TIMER_CLK_FREQ		12500000
-#define CONFIG_ARMV7_SECURE_BASE	OCRAM_BASE_S_ADDR
 
 #define CONFIG_HWCONFIG
 #define HWCONFIG_BUFFER_SIZE		128

Zhuoyu,

I don't see how the secure code is reserved in RAM. You only remove CONFIG_ARMV7_SECURE_BASE. Did I miss something?

York

Zhang Z.Y.

author

2015-07-29 02:25 UTC #2 lore raw

PATCH 1/1 arm:ls1021a: Reserve secure code into RAM instead of OCRAM

Hi, York

Sorry for the delay, I wrongly filter this patch and missed it.
As for your question, if platform does not define CONFIG_ARMV7_SECURE_BASE, U-boot will help define a default secure text section in linker script to reserve secure code. CONFIG_ARMV7_SECURE_BASE for LS1 is previously defined as OCRAM_BASE, This patch just remove it and use DDR by default.

Zhuoyu

Quoted 50 lines

-----Original Message-----
From: Sun York-R58495
Sent: Friday, April 17, 2015 4:03 AM
To: Zhang Zhuoyu-B46552
Cc: u-boot at lists.denx.de; Jin Zhengxiong-R64188; Wang Huan-B18965
Subject: Re: [PATCH] arm:ls1021a: Reserve secure code into RAM instead of OCRAM
Quoted 27 lines · Zhuoyu Zhang
For ls1021a, Reserve secure code in to memory in case OCRAM is needed by other usage.
Signed-off-by Zhuoyu Zhang <[email protected]>
---
 include/configs/ls1021aqds.h | 1 -
 include/configs/ls1021atwr.h | 1 -
 2 files changed, 2 deletions(-)
(quoted diff) +0 -0
b/include/configs/ls1021aqds.h index 3dc4da3..42439a4 100644
include/configs/ls1021aqds.h +0 -0
@@ -554,7 +554,6 @@ unsigned long get_board_ddr_clk(void);  #define
CONFIG_LS102XA_NS_ACCESS
#define CONFIG_SMP_PEN_ADDR 0x01ee0200
#define CONFIG_TIMER_CLK_FREQ 12500000
include/configs/ls1021aqds.h +0 -1
-#define CONFIG_ARMV7_SECURE_BASE	OCRAM_BASE_S_ADDR
 
 #define CONFIG_HWCONFIG
 #define HWCONFIG_BUFFER_SIZE		128
(quoted diff) +0 -0
b/include/configs/ls1021atwr.h index a13876b..dccc661 100644
include/configs/ls1021atwr.h line 352
Quoted 7 lines
include/configs/ls1021atwr.h +0 -1
@@ -347,7 +347,6 @@
 #define CONFIG_LS102XA_NS_ACCESS
 #define CONFIG_SMP_PEN_ADDR		0x01ee0200
 #define CONFIG_TIMER_CLK_FREQ		12500000
-#define CONFIG_ARMV7_SECURE_BASE	OCRAM_BASE_S_ADDR
 
 #define CONFIG_HWCONFIG
 #define HWCONFIG_BUFFER_SIZE		128
Zhuoyu,
I don't see how the secure code is reserved in RAM. You only remove CONFIG_ARMV7_SECURE_BASE. Did I miss something?
York

Zhang Z.Y.

author

2015-07-31 06:02 UTC #3 lore raw

PATCH 1/1 arm:ls1021a: Reserve secure code into RAM instead of OCRAM

In reply to York Sun

Hi, York

Could you help ACK this patch?

Best Regards
Zhuoyu

Quoted 69 lines

-----Original Message-----
From: Zhang Zhuoyu-B46552
Sent: Wednesday, July 29, 2015 10:25 AM
To: Sun York-R58495
Cc: u-boot at lists.denx.de; Jin Zhengxiong-R64188; Wang Huan-B18965
Subject: RE: [PATCH] arm:ls1021a: Reserve secure code into RAM instead of OCRAM
Hi, York
Sorry for the delay, I wrongly filter this patch and missed it. As for your question, if platform does not define CONFIG_ARMV7_SECURE_BASE, U-boot will help define a default secure text section in linker script to reserve secure code. CONFIG_ARMV7_SECURE_BASE for LS1 is previously defined as OCRAM_BASE, This patch just remove it and use DDR by default.
Zhuoyu
Quoted 50 lines
-----Original Message-----
From: Sun York-R58495
Sent: Friday, April 17, 2015 4:03 AM
To: Zhang Zhuoyu-B46552
Cc: u-boot at lists.denx.de; Jin Zhengxiong-R64188; Wang Huan-B18965
Subject: Re: [PATCH] arm:ls1021a: Reserve secure code into RAM instead of OCRAM
Quoted 27 lines · Zhuoyu Zhang
For ls1021a, Reserve secure code in to memory in case OCRAM is needed by other usage.
Signed-off-by Zhuoyu Zhang <[email protected]>
---
 include/configs/ls1021aqds.h | 1 -
 include/configs/ls1021atwr.h | 1 -
 2 files changed, 2 deletions(-)
(quoted diff) +0 -0
b/include/configs/ls1021aqds.h index 3dc4da3..42439a4 100644
include/configs/ls1021aqds.h +0 -0
@@ -554,7 +554,6 @@ unsigned long get_board_ddr_clk(void);  #define
CONFIG_LS102XA_NS_ACCESS
#define CONFIG_SMP_PEN_ADDR 0x01ee0200
#define CONFIG_TIMER_CLK_FREQ 12500000
include/configs/ls1021aqds.h +0 -1
-#define CONFIG_ARMV7_SECURE_BASE	OCRAM_BASE_S_ADDR
 
 #define CONFIG_HWCONFIG
 #define HWCONFIG_BUFFER_SIZE		128
(quoted diff) +0 -0
b/include/configs/ls1021atwr.h index a13876b..dccc661 100644
include/configs/ls1021atwr.h line 352
Quoted 7 lines
include/configs/ls1021atwr.h +0 -1
@@ -347,7 +347,6 @@
 #define CONFIG_LS102XA_NS_ACCESS
 #define CONFIG_SMP_PEN_ADDR		0x01ee0200
 #define CONFIG_TIMER_CLK_FREQ		12500000
-#define CONFIG_ARMV7_SECURE_BASE	OCRAM_BASE_S_ADDR
 
 #define CONFIG_HWCONFIG
 #define HWCONFIG_BUFFER_SIZE		128
Zhuoyu,
I don't see how the secure code is reserved in RAM. You only remove CONFIG_ARMV7_SECURE_BASE. Did I miss something?
York

Huan Wang

2015-08-03 02:29 UTC #4 lore raw

PATCH 1/1 arm:ls1021a: Reserve secure code into RAM instead of OCRAM

Acked-by Alison Wang <[email protected]>

Tested-by Alison Wang <[email protected]>

Best Regards,
Alison Wang

Quoted 86 lines

-----Original Message-----
From: Zhang Zhuoyu-B46552
Sent: Friday, July 31, 2015 2:02 PM
To: Sun York-R58495
Cc: u-boot at lists.denx.de; Jin Zhengxiong-R64188; Wang Huan-B18965; Wang Dongsheng-B40534
Subject: RE: [PATCH] arm:ls1021a: Reserve secure code into RAM instead of OCRAM
Hi, York
Could you help ACK this patch?
Best Regards
Zhuoyu
Quoted 6 lines
-----Original Message-----
From: Zhang Zhuoyu-B46552
Sent: Wednesday, July 29, 2015 10:25 AM
To: Sun York-R58495
Cc: u-boot at lists.denx.de; Jin Zhengxiong-R64188; Wang Huan-B18965
Subject: RE: [PATCH] arm:ls1021a: Reserve secure code into RAM
instead
Quoted 63 lines
of OCRAM
Hi, York
Sorry for the delay, I wrongly filter this patch and missed it. As for your question, if platform does not define CONFIG_ARMV7_SECURE_BASE, U-boot will help define a default secure text section in linker script to reserve secure code. CONFIG_ARMV7_SECURE_BASE for LS1 is previously defined as OCRAM_BASE, This patch just remove it and use DDR by default.
Zhuoyu
Quoted 50 lines
-----Original Message-----
From: Sun York-R58495
Sent: Friday, April 17, 2015 4:03 AM
To: Zhang Zhuoyu-B46552
Cc: u-boot at lists.denx.de; Jin Zhengxiong-R64188; Wang Huan-B18965
Subject: Re: [PATCH] arm:ls1021a: Reserve secure code into RAM instead of OCRAM
Quoted 27 lines · Zhuoyu Zhang
For ls1021a, Reserve secure code in to memory in case OCRAM is needed by other usage.
Signed-off-by Zhuoyu Zhang <[email protected]>
---
include/configs/ls1021aqds.h | 1 - include/configs/ls1021atwr.h
| 1 -
 2 files changed, 2 deletions(-)
(quoted diff) +0 -0
b/include/configs/ls1021aqds.h index 3dc4da3..42439a4 100644
include/configs/ls1021aqds.h +0 -1
@@ -554,7 +554,6 @@ unsigned long get_board_ddr_clk(void);
 #define CONFIG_LS102XA_NS_ACCESS
 #define CONFIG_SMP_PEN_ADDR		0x01ee0200
 #define CONFIG_TIMER_CLK_FREQ		12500000
-#define CONFIG_ARMV7_SECURE_BASE	OCRAM_BASE_S_ADDR
 
 #define CONFIG_HWCONFIG
 #define HWCONFIG_BUFFER_SIZE		128
(quoted diff) +0 -0
b/include/configs/ls1021atwr.h index a13876b..dccc661 100644
include/configs/ls1021atwr.h line 352
Quoted 7 lines
include/configs/ls1021atwr.h +0 -1
@@ -347,7 +347,6 @@
 #define CONFIG_LS102XA_NS_ACCESS
 #define CONFIG_SMP_PEN_ADDR		0x01ee0200
 #define CONFIG_TIMER_CLK_FREQ		12500000
-#define CONFIG_ARMV7_SECURE_BASE	OCRAM_BASE_S_ADDR
 
 #define CONFIG_HWCONFIG
 #define HWCONFIG_BUFFER_SIZE		128
Zhuoyu,
I don't see how the secure code is reserved in RAM. You only remove CONFIG_ARMV7_SECURE_BASE. Did I miss something?
York

York Sun

2015-08-04 15:43 UTC #5 lore raw

PATCH 1/1 arm:ls1021a: Reserve secure code into RAM instead of OCRAM

In reply to Zhuoyu Zhang

Quoted 5 lines · Zhuoyu Zhang

For ls1021a, Reserve secure code in to memory in case OCRAM is needed by other usage.
Signed-off-by Zhuoyu Zhang <[email protected]>
---

Applied to u-boot-fsl-qoriq master. Thanks.

York