Skip to contentSkip to conversation

net: lpc32xx: correct command register reset value

PATCH New Vladimir Zapolskiy 3 participants 5 messages Jun 28, 2015 – Aug 12, 2015

Subsystems (2)
Network drivers Arm/LPC32XX SoC support
lore
Share & tools
lore

Vladimir Zapolskiy

author maintainer
#0 lore raw

PATCH 1/1 net: lpc32xx: correct command register reset value

According to LPC32x0 User Manual the following bits in Command register 0x3106_0100 are defined:

Bit Symbol
2 - Unused
3 RegReset
4 TxReset
5 RxReset

Fix wrong (1-bit shifted right) COMMAND_RESETS value, which sets an unused bit, but neglects RxReset.

Signed-off-by Vladimir Zapolskiy <[email protected]>
---
 drivers/net/lpc32xx_eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/lpc32xx_eth.c +1 -1
index 8dcbb4a..72451a9 100644
@@ -170,7 +170,7 @@ struct lpc32xx_eth_registers {
 #define COMMAND_PASSRUNTFRAME 0x00000040
 #define COMMAND_FULL_DUPLEX   0x00000400
 /* Helper: general reset */
-#define COMMAND_RESETS        0x0000001C
+#define COMMAND_RESETS        0x00000038
 
 /* STATUS register bitfields/masks and offsets (see Table 283) */
 #define STATUS_RXSTATUS 0x00000001
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 net: lpc32xx: correct command register reset value

Bonjour Vladimir,

Le Sun, 28 Jun 2015 06:03:38 +0300, Vladimir Zapolskiy <[email protected]> a ?crit :

Quoted 22 lines

According to LPC32x0 User Manual the following bits in Command register 0x3106_0100 are defined:

Bit Symbol
2 - Unused
3 RegReset
4 TxReset
5 RxReset

Fix wrong (1-bit shifted right) COMMAND_RESETS value, which sets an unused bit, but neglects RxReset.

Signed-off-by Vladimir Zapolskiy <[email protected]>
---
 drivers/net/lpc32xx_eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/lpc32xx_eth.c +0 -0
index 8dcbb4a..72451a9 100644

drivers/net/lpc32xx_eth.c struct lpc32xx_eth_registers { · line 176

Quoted 8 lines
drivers/net/lpc32xx_eth.c +1 -1
@@ -170,7 +170,7 @@ struct lpc32xx_eth_registers {
 #define COMMAND_PASSRUNTFRAME 0x00000040
 #define COMMAND_FULL_DUPLEX   0x00000400
 /* Helper: general reset */
-#define COMMAND_RESETS        0x0000001C
+#define COMMAND_RESETS        0x00000038
 
 /* STATUS register bitfields/masks and offsets (see Table 283) */
 #define STATUS_RXSTATUS 0x00000001
Acked-by Albert ARIBAUD (3ADEV) <[email protected]>

Thanks for pointing this bug out!

Cordialement,
Albert ARIBAUD
3ADEV

#2 lore raw

PATCH 1/1 net: lpc32xx: correct command register reset value

In reply to Vladimir Zapolskiy

Hi Vladimir,

Quoted 9 lines · Vladimir Zapolskiy

According to LPC32x0 User Manual the following bits in Command register 0x3106_0100 are defined:

Bit Symbol
2 - Unused
3 RegReset
4 TxReset
5 RxReset

Quoted 5 lines

Fix wrong (1-bit shifted right) COMMAND_RESETS value, which sets an unused bit, but neglects RxReset.

Signed-off-by Vladimir Zapolskiy <[email protected]>

---

Acked-by Joe Hershberger <[email protected]>

I'll pull this into u-boot-net/next, Thanks!
-Joe

author maintainer
#3 lore raw

PATCH 1/1 net: lpc32xx: correct command register reset value

Hi Joe,

Quoted 15 lines · Joe Hershberger

Hi Vladimir,

Quoted 12 lines · Vladimir Zapolskiy

According to LPC32x0 User Manual the following bits in Command register 0x3106_0100 are defined:

Bit Symbol
2 - Unused
3 RegReset
4 TxReset
5 RxReset

Fix wrong (1-bit shifted right) COMMAND_RESETS value, which sets an unused bit, but neglects RxReset.

Quoted 8 lines
Quoted 2 lines
Signed-off-by Vladimir Zapolskiy <[email protected]>

---

Acked-by Joe Hershberger <[email protected]>

I'll pull this into u-boot-net/next, Thanks!
-Joe

ping.

With best wishes,
Vladimir

#4 lore raw

PATCH 1/1 net: lpc32xx: correct command register reset value

In reply to Vladimir Zapolskiy

Hi Vladimir,

Quoted 9 lines · Vladimir Zapolskiy

According to LPC32x0 User Manual the following bits in Command register 0x3106_0100 are defined:

Bit Symbol
2 - Unused
3 RegReset
4 TxReset
5 RxReset

Quoted 4 lines

Fix wrong (1-bit shifted right) COMMAND_RESETS value, which sets an unused bit, but neglects RxReset.

Signed-off-by Vladimir Zapolskiy <[email protected]>

Applied to u-boot-net, thanks!
-Joe