net: lpc32xx: connect MAC to phy with CONFIG_PHY_ADDR id
Subsystems (2)
Vladimir Zapolskiy
maintainerPATCH 1/1 net: lpc32xx: connect MAC to phy with CONFIG_PHY_ADDR id
The lpc32xx_eth_phylib_init() function is capable to connect LPC32XX MAC to some specified phy by phy id, by chance the single user of lpc32xx_eth has CONFIG_PHY_ADDR set to 0, however other boards may have non-zero CONFIG_PHY_ADDR value, fix it.
--- drivers/net/lpc32xx_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/lpc32xx_eth.c +1 -1
@@ -630,7 +630,7 @@ int lpc32xx_eth_initialize(bd_t *bis)eth_register (dev);#if defined(CONFIG_PHYLIB ) -lpc32xx_eth_phylib_init (dev,0 ); +lpc32xx_eth_phylib_init (dev,CONFIG_PHY_ADDR );#elif defined(CONFIG_MII ) || defined(CONFIG_CMD_MII )miiphy_register (dev->name, mii_reg_read, mii_reg_write);#endif
Signature · 1 line
2.1.4
PATCH 1/1 net: lpc32xx: connect MAC to phy with CONFIG_PHY_ADDR id
Bonjour Vladimir,
Le Mon, 29 Jun 2015 03:35:12 +0300, Vladimir Zapolskiy <[email protected]> a ?crit :
Quoted 15 lines
The
lpc32xx_eth_phylib_init()function is capable to connect LPC32XX MAC to some specified phy by phy id, by chance the single user oflpc32xx_ethhasCONFIG_PHY_ADDRset to 0, however other boards may have non-zeroCONFIG_PHY_ADDRvalue, fix it.Signed-off-by Vladimir Zapolskiy <[email protected]>--- drivers/net/lpc32xx_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/lpc32xx_eth.c +0
-0
drivers/net/lpc32xx_eth.c int lpc32xx_eth_initialize(bd_t *bis) · line 636
Quoted 8 lines
drivers/net/lpc32xx_eth.c +1
-1@@ -630,7 +630,7 @@ int lpc32xx_eth_initialize(bd_t *bis)eth_register (dev);#if defined(CONFIG_PHYLIB ) -lpc32xx_eth_phylib_init (dev,0 ); +lpc32xx_eth_phylib_init (dev,CONFIG_PHY_ADDR );#elif defined(CONFIG_MII ) || defined(CONFIG_CMD_MII )miiphy_register (dev->name, mii_reg_read, mii_reg_write);#endif
Cordialement,
Albert ARIBAUD
3ADEV
LEMIEUX
PATCH 1/1 net: lpc32xx: connect MAC to phy with CONFIG_PHY_ADDR id
Quoted 36 lines
-----Original Message-----
From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Albert ARIBAUD
Sent: 29-Jun-15 4:25 AMBonjour Vladimir,
Le Mon, 29 Jun 2015 03:35:12 +0300, Vladimir Zapolskiy <[email protected]> a ?crit :
Quoted 15 lines
The
lpc32xx_eth_phylib_init()function is capable to connect LPC32XX MAC to some specified phy by phy id, by chance the single user oflpc32xx_ethhasCONFIG_PHY_ADDRset to 0, however other boards may have non-zeroCONFIG_PHY_ADDRvalue, fix it.Signed-off-by Vladimir Zapolskiy <[email protected]>--- drivers/net/lpc32xx_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/lpc32xx_eth.c +0
-0drivers/net/lpc32xx_eth.c int lpc32xx_eth_initialize(bd_t *bis) · line 636
Quoted 8 lines
drivers/net/lpc32xx_eth.c +1
-1@@ -630,7 +630,7 @@ int lpc32xx_eth_initialize(bd_t *bis)eth_register (dev);#if defined(CONFIG_PHYLIB ) -lpc32xx_eth_phylib_init (dev,0 ); +lpc32xx_eth_phylib_init (dev,CONFIG_PHY_ADDR );#elif defined(CONFIG_MII ) || defined(CONFIG_CMD_MII )miiphy_register (dev->name, mii_reg_read, mii_reg_write);#endif
Quoted 3 lines
Cordialement,
Albert ARIBAUD
3ADEV
Tested with a PHY setup at an address different than 0;
Quoted 4 lines
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
________________________________
This e-mail contains privileged and confidential information intended for the use of the addressees named above. If you are not the intended recipient of this e-mail, you are hereby notified that you must not disseminate, copy or take any action in respect of any information contained in it. If you have received this e-mail in error, please notify the sender immediately by e-mail and immediately destroy this e-mail and its attachments.
PATCH 1/1 net: lpc32xx: connect MAC to phy with CONFIG_PHY_ADDR id
In reply to Vladimir ZapolskiyHi Vladimir,
Quoted 7 lines · Vladimir Zapolskiy
The
lpc32xx_eth_phylib_init()function is capable to connect LPC32XX MAC to some specified phy by phy id, by chance the single user oflpc32xx_ethhasCONFIG_PHY_ADDRset to 0, however other boards may have non-zeroCONFIG_PHY_ADDRvalue, fix it.Signed-off-by Vladimir Zapolskiy <[email protected]>---
I'll pull this into u-boot-net/next, Thanks!
-Joe
Vladimir Zapolskiy
maintainerPATCH 1/1 net: lpc32xx: connect MAC to phy with CONFIG_PHY_ADDR id
Hi Joe,
Quoted 8 lines · Joe Hershberger
Hi Vladimir,
Quoted 5 lines · Vladimir Zapolskiy
The
lpc32xx_eth_phylib_init()function is capable to connect LPC32XX MAC to some specified phy by phy id, by chance the single user oflpc32xx_ethhasCONFIG_PHY_ADDRset to 0, however other boards may have non-zeroCONFIG_PHY_ADDRvalue, fix it.
Quoted 8 lines
Quoted 2 lines
Signed-off-by Vladimir Zapolskiy <[email protected]>---
Acked-by Joe Hershberger <[email protected]>I'll pull this into u-boot-net/next, Thanks!
-Joe
ping.
With best wishes,
Vladimir
PATCH 1/1 net: lpc32xx: connect MAC to phy with CONFIG_PHY_ADDR id
In reply to Vladimir ZapolskiyHi Vladimir,
Quoted 6 lines · Vladimir Zapolskiy
The
lpc32xx_eth_phylib_init()function is capable to connect LPC32XX MAC to some specified phy by phy id, by chance the single user oflpc32xx_ethhasCONFIG_PHY_ADDRset to 0, however other boards may have non-zeroCONFIG_PHY_ADDRvalue, fix it.Signed-off-by Vladimir Zapolskiy <[email protected]>
Applied to u-boot-net, thanks!
-Joe