Skip to contentSkip to conversation

drm/i915/skl WaDisableSbeCacheDispatchPortSharing

PATCH In review Mika Kuoppala 2 participants 4 messages Aug 6, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/skl WaDisableSbeCacheDispatchPortSharing

Add WaDisableSbeCacheDispatchPortSharing:skl

---
 drivers/gpu/drm/i915/intel_ringbuffer.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/gpu/drm/i915/intel_ringbuffer.c +7 -0
index 1c14233..1a10358 100644
@@ -1059,6 +1059,13 @@ static int skl_init_workarounds(struct intel_engine_cs *ring)
 				  HDC_FENCE_DEST_SLM_DISABLE |
 				  HDC_BARRIER_PERFORMANCE_DISABLE);
 
+	/* WaDisableSbeCacheDispatchPortSharing:skl */
+	if (INTEL_REVID(dev) <= SKL_REVID_F0) {
+		WA_SET_BIT_MASKED(
+			GEN7_HALF_SLICE_CHICKEN1,
+			GEN7_SBE_SS_CACHE_DISPATCH_PORT_SHARING_DISABLE);
+	}
+
 	return skl_tune_iz_hashing(ring);
 }
 
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 13 lines · Mika Kuoppala

Add WaDisableSbeCacheDispatchPortSharing:skl

---
  drivers/gpu/drm/i915/intel_ringbuffer.c | 7 +++++++
  1 file changed, 7 insertions(+)
drivers/gpu/drm/i915/intel_ringbuffer.c +0 -0
index 1c14233..1a10358 100644

drivers/gpu/drm/i915/intel_ringbuffer.c static int skl_init_workarounds(struct intel_engine_cs *ring) · line 1068

Quoted 10 lines
drivers/gpu/drm/i915/intel_ringbuffer.c +7 -0
@@ -1059,6 +1059,13 @@ static int skl_init_workarounds(struct intel_engine_cs *ring)
  				  HDC_FENCE_DEST_SLM_DISABLE |
  				  HDC_BARRIER_PERFORMANCE_DISABLE);
 
+	/* WaDisableSbeCacheDispatchPortSharing:skl */
+	if (INTEL_REVID(dev) <= SKL_REVID_F0) {
+		WA_SET_BIT_MASKED(
+			GEN7_HALF_SLICE_CHICKEN1,
+			GEN7_SBE_SS_CACHE_DISPATCH_PORT_SHARING_DISABLE);
+	}
+

seems to be applicable for BXT also until B0.

regards
Arun

drivers/gpu/drm/i915/intel_ringbuffer.c static int skl_init_workarounds(struct intel_engine_cs *ring) · line 1071

Quoted 4 lines
drivers/gpu/drm/i915/intel_ringbuffer.c +0 -0
  	return skl_tune_iz_hashing(ring);
  }
 

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
Quoted 17 lines · Arun
Quoted 16 lines · Mika Kuoppala

Add WaDisableSbeCacheDispatchPortSharing:skl

---
  drivers/gpu/drm/i915/intel_ringbuffer.c | 7 +++++++
  1 file changed, 7 insertions(+)
drivers/gpu/drm/i915/intel_ringbuffer.c +0 -0
index 1c14233..1a10358 100644
@@ -1059,6 +1059,13 @@ static int skl_init_workarounds(struct intel_engine_cs *ring)
  				  HDC_FENCE_DEST_SLM_DISABLE |
  				  HDC_BARRIER_PERFORMANCE_DISABLE);
 
Quoted 9 lines

drivers/gpu/drm/i915/intel_ringbuffer.c static int skl_init_workarounds(struct intel_engine_cs *ring) · line 1068

Quoted 7 lines
drivers/gpu/drm/i915/intel_ringbuffer.c +7 -0
+	/* WaDisableSbeCacheDispatchPortSharing:skl */
+	if (INTEL_REVID(dev) <= SKL_REVID_F0) {
+		WA_SET_BIT_MASKED(
+			GEN7_HALF_SLICE_CHICKEN1,
+			GEN7_SBE_SS_CACHE_DISPATCH_PORT_SHARING_DISABLE);
+	}
+

seems to be applicable for BXT also until B0.

Yes, we have that in bxt_init_workarounds. I pondered it is more clean to have rev check for each in their respective setup functions.

-Mika

Quoted 7 lines

regards
Arun

Quoted 4 lines
drivers/gpu/drm/i915/intel_ringbuffer.c +0 -0
  	return skl_tune_iz_hashing(ring);
  }
 

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by
#3 lore raw
Quoted 29 lines · Mika Kuoppala
Quoted 17 lines · Arun
Quoted 16 lines · Mika Kuoppala

Add WaDisableSbeCacheDispatchPortSharing:skl

---
   drivers/gpu/drm/i915/intel_ringbuffer.c | 7 +++++++
   1 file changed, 7 insertions(+)
drivers/gpu/drm/i915/intel_ringbuffer.c +0 -0
index 1c14233..1a10358 100644
@@ -1059,6 +1059,13 @@ static int skl_init_workarounds(struct intel_engine_cs *ring)
   				  HDC_FENCE_DEST_SLM_DISABLE |
   				  HDC_BARRIER_PERFORMANCE_DISABLE);
 
Quoted 9 lines

drivers/gpu/drm/i915/intel_ringbuffer.c static int skl_init_workarounds(struct intel_engine_cs *ring) · line 1068

Quoted 7 lines
drivers/gpu/drm/i915/intel_ringbuffer.c +7 -0
+	/* WaDisableSbeCacheDispatchPortSharing:skl */
+	if (INTEL_REVID(dev) <= SKL_REVID_F0) {
+		WA_SET_BIT_MASKED(
+			GEN7_HALF_SLICE_CHICKEN1,
+			GEN7_SBE_SS_CACHE_DISPATCH_PORT_SHARING_DISABLE);
+	}
+

seems to be applicable for BXT also until B0.

Quoted 3 lines

Yes, we have that in bxt_init_workarounds. I pondered it is more clean to have rev check for each in their respective setup functions.

fine with this.

regards
Arun

Quoted 12 lines

-Mika

Quoted 7 lines

regards
Arun

Quoted 4 lines
drivers/gpu/drm/i915/intel_ringbuffer.c +0 -0
   	return skl_tune_iz_hashing(ring);
   }
 

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx