ata: ahci_brcmstb: Fix misuse of IS_ENABLED
Subsystems (2)
PATCH v2 1/1 ata: ahci_brcmstb: Fix misuse of IS_ENABLED
While IS_ENABLED() is perfectly fine for CONFIG_* symbols, it is not for other symbols such as __BIG_ENDIAN that is provided directly by the compiler.
Switch to use CONFIG_CPU_BIG_ENDIAN instead of __BIG_ENDIAN.
---
v2:
Based on Florian's comment:
Switch to use CONFIG_CPU_BIG_ENDIAN instead of __BIG_ENDIAN.
drivers/ata/ahci_brcmstb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/ata/ahci_brcmstb.c +2 -2
@@ -92,7 +92,7 @@ static inline u32 brcm_sata_readreg(void __iomem *addr)* Other architectures (e.g., ARM) either do not support big endian, or * else leave I/O in little endian mode. */ -if (IS_ENABLED (CONFIG_MIPS ) &&IS_ENABLED (__BIG_ENDIAN)) +if (IS_ENABLED (CONFIG_MIPS ) &&IS_ENABLED (CONFIG_CPU_BIG_ENDIAN ))return __raw_readl (addr);else return readl_relaxed (addr);
@@ -101,7 +101,7 @@ static inline u32 brcm_sata_readreg(void __iomem *addr)static inline void brcm_sata_writereg (u32 val,void __iomem *addr) {/* See brcm_sata_readreg() comments */ -if (IS_ENABLED (CONFIG_MIPS ) &&IS_ENABLED (__BIG_ENDIAN)) +if (IS_ENABLED (CONFIG_MIPS ) &&IS_ENABLED (CONFIG_CPU_BIG_ENDIAN ))__raw_writel (val, addr);else writel_relaxed (val, addr);
Signature · 1 line
2.1.0
PATCH v2 1/1 ata: ahci_brcmstb: Fix misuse of IS_ENABLED
Quoted 7 lines · Axel Lin
While
IS_ENABLED()is perfectly fine for CONFIG_* symbols, it is not for other symbols such as__BIG_ENDIANthat is provided directly by the compiler.Switch to use
CONFIG_CPU_BIG_ENDIANinstead of__BIG_ENDIAN.Signed-off-by Axel Lin <[email protected]>
Quoted 31 lines
---
v2:
Based on Florian's comment:
Switch to useCONFIG_CPU_BIG_ENDIANinstead of__BIG_ENDIAN.drivers/ata/ahci_brcmstb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/ata/ahci_brcmstb.c +2
-2@@ -92,7 +92,7 @@ static inline u32 brcm_sata_readreg(void __iomem *addr)* Other architectures (e.g., ARM) either do not support big endian, or * else leave I/O in little endian mode. */ -if (IS_ENABLED (CONFIG_MIPS ) &&IS_ENABLED (__BIG_ENDIAN)) +if (IS_ENABLED (CONFIG_MIPS ) &&IS_ENABLED (CONFIG_CPU_BIG_ENDIAN ))return __raw_readl (addr);else return readl_relaxed (addr);@@ -101,7 +101,7 @@ static inline u32 brcm_sata_readreg(void __iomem *addr)static inline void brcm_sata_writereg (u32 val,void __iomem *addr) {/* See brcm_sata_readreg() comments */ -if (IS_ENABLED (CONFIG_MIPS ) &&IS_ENABLED (__BIG_ENDIAN)) +if (IS_ENABLED (CONFIG_MIPS ) &&IS_ENABLED (CONFIG_CPU_BIG_ENDIAN ))__raw_writel (val, addr);else writel_relaxed (val, addr);
Signature · 1 line
Florian
Tejun Heo
AppliedPATCH v2 1/1 ata: ahci_brcmstb: Fix misuse of IS_ENABLED
In reply to Axel LinQuoted 7 lines · Axel Lin
While
IS_ENABLED()is perfectly fine for CONFIG_* symbols, it is not for other symbols such as__BIG_ENDIANthat is provided directly by the compiler.Switch to use
CONFIG_CPU_BIG_ENDIANinstead of__BIG_ENDIAN.Signed-off-by Axel Lin <[email protected]>
Applied to libata/for-4.2-fixes w/ stable cc'd.
Thanks.
Signature · 1 line
tejun