igbvf: Enable TSO for stacked vlan

PATCH New Toshiaki Makita 3 participants 8 messages Aug 6, 2015 – Aug 21, 2015

Subsystems (2)

Network drivers Intel Ethernet

lore

Share & tools

lore

Toshiaki Makita

author

2015-08-06 08:57 UTC #0 lore raw

PATCH 1/4 igbvf: Enable TSO for stacked vlan

Setting ndo_features_check to passthru_features_check allows the driver to skip the check for multiple tagged TSO packets and enables stacked vlan TSO.
Tested with I350.

Signed-off-by Toshiaki Makita <[email protected]>

---
 drivers/net/ethernet/intel/igbvf/netdev.c | 1 +
 1 file changed, 1 insertion(+)

drivers/net/ethernet/intel/igbvf/netdev.c +1 -0

index 95af14e..45679e4 100644
@@ -2614,6 +2614,7 @@ static const struct net_device_ops igbvf_netdev_ops = {
 	.ndo_poll_controller	= igbvf_netpoll,
 #endif
 	.ndo_set_features	= igbvf_set_features,
+	.ndo_features_check	= passthru_features_check,
 };
 
 /**

Signature · 1 line

1.8.1.2

Toshiaki Makita

author

2015-08-06 08:57 UTC #1 lore raw

PATCH 2/4 e1000e: Enable TSO for stacked vlan

Setting ndo_features_check to passthru_features_check allows the driver to skip the check for multiple tagged TSO packets and enables stacked vlan TSO.
Tested with I217-LM.

Signed-off-by Toshiaki Makita <[email protected]>

---
 drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
 1 file changed, 1 insertion(+)

drivers/net/ethernet/intel/e1000e/netdev.c +1 -0

index 546b5da..bcabbba 100644
@@ -6952,6 +6952,7 @@ static const struct net_device_ops e1000e_netdev_ops = {
 #endif
 	.ndo_set_features = e1000_set_features,
 	.ndo_fix_features = e1000_fix_features,
+	.ndo_features_check	= passthru_features_check,
 };
 
 /**

Signature · 1 line

1.8.1.2

Brown

2015-08-21 22:32 UTC #2 lore raw

PATCH 2/4 e1000e: Enable TSO for stacked vlan

Quoted 18 lines

From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Toshiaki Makita
Sent: Thursday, August 06, 2015 1:57 AM
To: Kirsher, Jeffrey T <[email protected]>; Brandeburg, Jesse <[email protected]>; Nelson, Shannon <[email protected]>; Wyborny, Carolyn <[email protected]>; Skidmore, Donald C <[email protected]>; Vick, Matthew <[email protected]>; Ronciak, John <[email protected]>; Williams, Mitch A <[email protected]>
Cc: intel-wired-lan at lists.osuosl.org; Toshiaki Makita <[email protected]>
Subject: [Intel-wired-lan] [PATCH next 2/4] e1000e: Enable TSO for stacked vlan
Setting ndo_features_check to passthru_features_check allows the driver to skip the check for multiple tagged TSO packets and enables stacked vlan TSO.
Tested with I217-LM.

Quoted 4 lines

Signed-off-by Toshiaki Makita <[email protected]>
---
 drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
 1 file changed, 1 insertion(+)

Tested-by Aaron Brown <[email protected]>

Toshiaki Makita

author

2015-08-06 08:57 UTC #3 lore raw

PATCH 3/4 ixgbe: Enable TSO for stacked vlan

In reply to Toshiaki Makita

Setting ndo_features_check to passthru_features_check allows the driver to skip the check for multiple tagged TSO packets and enables stacked vlan TSO.
Tested with 82599ES.

Signed-off-by Toshiaki Makita <[email protected]>

---
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 1 +
 1 file changed, 1 insertion(+)

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +1 -0

index 3e6a931..1f35e6d 100644
@@ -8255,6 +8255,7 @@ static const struct net_device_ops ixgbe_netdev_ops = {
 	.ndo_dfwd_del_station	= ixgbe_fwd_del,
 	.ndo_add_vxlan_port	= ixgbe_add_vxlan_port,
 	.ndo_del_vxlan_port	= ixgbe_del_vxlan_port,
+	.ndo_features_check	= passthru_features_check,
 };
 
 /**

Signature · 1 line

1.8.1.2

Jeff Kirsher

NAK

2015-08-07 06:07 UTC #4 lore raw

PATCH 3/4 ixgbe: Enable TSO for stacked vlan

Quoted 10 lines · Toshiaki Makita

Setting ndo_features_check to passthru_features_check allows the driver
to skip the check for multiple tagged TSO packets and enables stacked vlan TSO.
Tested with 82599ES.
Signed-off-by Toshiaki Makita <[email protected]>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 1 +
 1 file changed, 1 insertion(+)

NACK!

This does not apply cleanly AND the ixgbe code already has a .ndo_features_check which is assigned to our ixgbe_features_check().

PLEASE pull my tree to ensure you are using the latest code when generating patches.

Dropping this patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20150806/7448b70d/attachment.asc>

Toshiaki Makita

author

2015-08-07 06:22 UTC #5 lore raw

PATCH 3/4 ixgbe: Enable TSO for stacked vlan

Quoted 12 lines · Jeff Kirsher

Quoted 10 lines · Toshiaki Makita
Setting ndo_features_check to passthru_features_check allows the driver
to skip the check for multiple tagged TSO packets and enables stacked vlan TSO.
Tested with 82599ES.
Signed-off-by Toshiaki Makita <[email protected]>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 1 +
 1 file changed, 1 insertion(+)

Quoted 7 lines

NACK!
This does not apply cleanly AND the ixgbe code already has a .ndo_features_check which is assigned to our ixgbe_features_check().
PLEASE pull my tree to ensure you are using the latest code when generating patches.

Oops...
I tested patches on next-queue's "master" branch but I now realize I should have tested on "dev-queue" branch..

I'm sorry, this patch is completely unnecessary since ixgbe_features_check() doesn't call vlan_check_features().

Toshiaki Makita

author

2015-08-06 08:57 UTC #6 lore raw

PATCH 4/4 ixgbevf: Enables TSO for stacked vlan

In reply to Toshiaki Makita

Setting ndo_features_check to passthru_features_check allows the driver to skip the check for multiple tagged TSO packets and enables stacked vlan TSO.
Tested with 82599ES.

Signed-off-by Toshiaki Makita <[email protected]>

---
 drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 1 +
 1 file changed, 1 insertion(+)

drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c +1 -0

index 88298a3..67c785d 100644
@@ -3896,6 +3896,7 @@ static const struct net_device_ops ixgbevf_netdev_ops = {
 #ifdef CONFIG_NET_POLL_CONTROLLER
 	.ndo_poll_controller	= ixgbevf_netpoll,
 #endif
+	.ndo_features_check	= passthru_features_check,
 };
 
 static void ixgbevf_assign_netdev_ops(struct net_device *dev)

Signature · 1 line

1.8.1.2

Brown

2015-08-21 22:33 UTC #7 lore raw

PATCH 1/4 igbvf: Enable TSO for stacked vlan

In reply to Toshiaki Makita

Quoted 18 lines

From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Toshiaki Makita
Sent: Thursday, August 06, 2015 1:57 AM
To: Kirsher, Jeffrey T <[email protected]>; Brandeburg, Jesse <[email protected]>; Nelson, Shannon <[email protected]>; Wyborny, Carolyn <[email protected]>; Skidmore, Donald C <[email protected]>; Vick, Matthew <[email protected]>; Ronciak, John <[email protected]>; Williams, Mitch A <[email protected]>
Cc: intel-wired-lan at lists.osuosl.org; Toshiaki Makita <[email protected]>
Subject: [Intel-wired-lan] [PATCH next 1/4] igbvf: Enable TSO for stacked vlan
Setting ndo_features_check to passthru_features_check allows the driver to skip the check for multiple tagged TSO packets and enables stacked vlan TSO.
Tested with I350.

Quoted 4 lines

Signed-off-by Toshiaki Makita <[email protected]>
---
 drivers/net/ethernet/intel/igbvf/netdev.c | 1 +
 1 file changed, 1 insertion(+)

Tested-by Aaron Brown <[email protected]>