Skip to contentSkip to conversation

Enable GICv2m on ARM virt machine

PATCH New Pavel Fedin 2 participants 4 messages Aug 4, 2015 – Aug 7, 2015 Arm (32-bit)

lore
Share & tools
lore

Pavel Fedin

author
#0 lore raw

PATCH 1/1 Enable GICv2m on ARM virt machine

qemu implementation of "virt" includes GICv2m. This commit allows to use it also on ARM32 architecture.

Signed-off-by Pavel Fedin <[email protected]>
---
 arch/arm/Kconfig            | 1 +
 arch/arm/include/asm/Kbuild | 1 +
 2 files changed, 2 insertions(+)
arch/arm/Kconfig +1 -0
index 45df48b..1091025 100644
@@ -815,6 +815,7 @@ config ARCH_VIRT
 	bool "Dummy Virtual Machine" if ARCH_MULTI_V7
 	select ARM_AMBA
 	select ARM_GIC
+	select ARM_GIC_V2M if PCI_MSI
 	select ARM_PSCI
 	select HAVE_ARM_ARCH_TIMER
arch/arm/include/asm/Kbuild +1 -0
index 3c4596d..01806f5 100644
@@ -14,6 +14,7 @@ generic-y += local.h
 generic-y += local64.h
 generic-y += mcs_spinlock.h
 generic-y += msgbuf.h
+generic-y += msi.h
 generic-y += param.h
 generic-y += parport.h
 generic-y += poll.h
Signature · 1 line
1.9.5.msysgit.0
#1 lore raw

PATCH 1/1 Enable GICv2m on ARM virt machine

Hi Pavel,

Quoted 27 lines · Pavel Fedin

qemu implementation of "virt" includes GICv2m. This commit allows to use it also on ARM32 architecture.

Signed-off-by Pavel Fedin <[email protected]>
---
 arch/arm/Kconfig            | 1 +
 arch/arm/include/asm/Kbuild | 1 +
 2 files changed, 2 insertions(+)
arch/arm/Kconfig +1 -0
index 45df48b..1091025 100644
@@ -815,6 +815,7 @@ config ARCH_VIRT
 	bool "Dummy Virtual Machine" if ARCH_MULTI_V7
 	select ARM_AMBA
 	select ARM_GIC
+	select ARM_GIC_V2M if PCI_MSI
 	select ARM_PSCI
 	select HAVE_ARM_ARCH_TIMER
arch/arm/include/asm/Kbuild +0 -0
index 3c4596d..01806f5 100644

arch/arm/include/asm/Kbuild generic-y += local.h · line 20

Quoted 7 lines
arch/arm/include/asm/Kbuild +1 -0
@@ -14,6 +14,7 @@ generic-y += local.h
 generic-y += local64.h
 generic-y += mcs_spinlock.h
 generic-y += msgbuf.h
+generic-y += msi.h
 generic-y += param.h
 generic-y += parport.h
 generic-y += poll.h

You may want to add a comment about the dependency chain that requires the generic msi.h.

Thanks,

	M.
Signature · 1 line
Jazz is not dead. It just smells funny...
author
#2 lore raw

PATCH 1/1 Enable GICv2m on ARM virt machine

Hello!

Quoted 2 lines

You may want to add a comment about the dependency chain that requires the generic msi.h.

The error i get is:
--- cut ---
In file included from kernel/irq/chip.c:14:0:
include/linux/msi.h:123:21: fatal error: asm/msi.h: No such file or directory

 #include <asm/msi.h>
                     ^

--- cut ---

This portion in linux/msi.h sits under #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN, which is activated by the following chain:
ARM_GIC_V2M => PCI_MSI_IRQ_DOMAIN => GENERIC_MSI_IRQ_DOMAIN

Do i need to respin just because of comment?

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia

#3 lore raw

PATCH 1/1 Enable GICv2m on ARM virt machine

Quoted 11 lines · Pavel Fedin

Hello!

Quoted 2 lines

You may want to add a comment about the dependency chain that requires the generic msi.h.

The error i get is:
--- cut ---
In file included from kernel/irq/chip.c:14:0:
include/linux/msi.h:123:21: fatal error: asm/msi.h: No such file or directory

 #include <asm/msi.h>
                     ^
Quoted 7 lines

--- cut ---

This portion in linux/msi.h sits under #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN, which is activated by the following chain:
ARM_GIC_V2M => PCI_MSI_IRQ_DOMAIN => GENERIC_MSI_IRQ_DOMAIN

Do i need to respin just because of comment?

That's for Russell to decide, really. But I feel that adding an include file that affects the whole architecture (and not just a single platform) deserves an explanation in the commit log.

Thanks,

	M.
Signature · 1 line
Jazz is not dead. It just smells funny...