Boot crash with 659006b x86/x2apic: Split enable and setup function
A message that is not in the archive (sent off-list or not yet received): [email protected]
(missed the LKML cc apologies for the noise)
Quoted 37 lines · Laura Abbott
Hi,
We received a report[1] of an early boot crash. The reporter had difficulty getting a full kernel log to view and only had a screenshot which showed a crash in
native_apic_mem_read(full screenshot available at the bugzilla along with dmesg from working kernel)Bisection identified the following commit:
commit
659006bf3ae37a08706907ce1a36ddf57c9131d2Author: Thomas Gleixner <[email protected]> Date: Thu Jan 15 21:22:26 2015 +0000x86/x2apic: Split enable and setup function
enable_x2apic()is a convoluted unreadable mess because it is used for both enablement in early boot and for setup incpu_init().Split the code into
x2apic_enable()for enablement andx2apic_setup()for setup of (secondary cpus). Make use of the new state tracking to simplify the logic.Signed-off-by Thomas Gleixner <[email protected]>Cc Jiang Liu <[email protected]>Cc Joerg Roedel <[email protected]>Cc Tony Luck <[email protected]>Cc Borislav Petkov <[email protected]>Signed-off-by Thomas Gleixner <[email protected]>The report indicates that if local x2apic is disabled in the BIOS the kernel boots.
Any ideas?
Thanks,
Laura
Quoted 39 lines · Laura Abbott
(missed the LKML cc apologies for the noise)
Quoted 36 lines · Laura Abbott
Hi,
We received a report[1] of an early boot crash. The reporter had difficulty getting a full
kernel log to view and only had a screenshot which showed a crash innative_apic_mem_read
(full screenshot available at the bugzilla along with dmesg from working kernel)Bisection identified the following commit:
commit
659006bf3ae37a08706907ce1a36ddf57c9131d2Author: Thomas Gleixner <[email protected]> Date: Thu Jan 15 21:22:26 2015 +0000x86/x2apic: Split enable and setup function
enable_x2apic()is a convoluted unreadable mess because it is used for both enablement in early boot and for setup incpu_init().Split the code into
x2apic_enable()for enablement andx2apic_setup()for setup of (secondary cpus). Make use of the new state tracking to simplify the logic.Signed-off-by Thomas Gleixner <[email protected]>Cc Jiang Liu <[email protected]>Cc Joerg Roedel <[email protected]>Cc Tony Luck <[email protected]>Cc Borislav Petkov <[email protected]>Signed-off-by Thomas Gleixner <[email protected]>The report indicates that if local x2apic is disabled in the BIOS the kernel boots.
Any ideas?
Does the patch below fix the issue?
Thanks,
tglx
-------------------->
arch/x86/kernel/apic/apic.c +1 -1
@@ -1424,7 +1424,7 @@ static inline void __x2apic_disable(void) {u64 msr; -if (cpu_has_apic) +if (!cpu_has_apic)return ;rdmsrl (MSR_IA32_APICBASE , msr);