arm: mx6: Remove SPI support from WRU-IV baseboard
PATCH 1/1 arm: mx6: Remove SPI support from WRU-IV baseboard
This patch removes the SPI support from the WRU-IV baseboard as its not used at all.
--- board/tqc/tqma6/tqma6.c | 1 + configs/tqma6s_wru4_mmc_defconfig | 3 --- include/configs/tqma6_wru4.h | 8 ++++++++ 3 files changed, 9 insertions(+), 3 deletions(-)
board/tqc/tqma6/tqma6.c +1 -0
@@ -25,6 +25,7 @@#include <mmc.h> #include <power/pfuze100_pmic.h> #include <power/pmic.h> +#include <spi_flash.h> #include "tqma6_bb.h"
configs/tqma6s_wru4_mmc_defconfig +0 -3
@@ -3,11 +3,8 @@ CONFIG_ARCH_MX6=y CONFIG_TARGET_TQMA6=y CONFIG_TQMA6S=y CONFIG_WRU4=y -CONFIG_CMD_SETEXPR=y -CONFIG_CMD_NET=y CONFIG_AUTOBOOT_KEYED=y CONFIG_AUTOBOOT_PROMPT="Enter password in %d seconds to stop autoboot\n" CONFIG_AUTOBOOT_ENCRYPTION=y CONFIG_AUTOBOOT_STOP_STR_SHA256="36a9e7f1c95b82ffb99743e0c5c4ce95d83c9a430aac59f84ef3cbfab6145068" CONFIG_PCA9551_LED=y -CONFIG_SPI_FLASH=y
include/configs/tqma6_wru4.h +8 -0
@@ -68,4 +68,12 @@#define CONFIG_SYS_BOOTCOUNT_ADDR IRAM_BASE_ADDR#define CONFIG_SYS_BOOTCOUNT_BE +/* +* Remove all unused interfaces / commands that are defined in +* the common header tqms6.h +*/ +#undef CONFIG_CMD_SF +#undef CONFIG_CMD_SPI +#undef CONFIG_MXC_SPI +#endif /* __CONFIG_TQMA6_WRU4_H */
Signature · 1 line
2.4.8
PATCH 1/1 arm: mx6: Remove SPI support from WRU-IV baseboard
Hi Stefan, Clemens,
Quoted 49 lines · Stefan Roese
This patch removes the SPI support from the WRU-IV baseboard as its not used at all.
Signed-off-by Stefan Roese <[email protected]>Cc Clemens Gruber <[email protected]>Cc Markus Niebel <[email protected]>Cc Stefano Babic <[email protected]>--- board/tqc/tqma6/tqma6.c | 1 + configs/tqma6s_wru4_mmc_defconfig | 3 --- include/configs/tqma6_wru4.h | 8 ++++++++ 3 files changed, 9 insertions(+), 3 deletions(-)board/tqc/tqma6/tqma6.c +1
-0@@ -25,6 +25,7 @@#include <mmc.h> #include <power/pfuze100_pmic.h> #include <power/pmic.h> +#include <spi_flash.h> #include "tqma6_bb.h" configs/tqma6s_wru4_mmc_defconfig +0
-3@@ -3,11 +3,8 @@ CONFIG_ARCH_MX6=y CONFIG_TARGET_TQMA6=y CONFIG_TQMA6S=y CONFIG_WRU4=y -CONFIG_CMD_SETEXPR=y -CONFIG_CMD_NET=y CONFIG_AUTOBOOT_KEYED=y CONFIG_AUTOBOOT_PROMPT="Enter password in %d seconds to stop autoboot\n" CONFIG_AUTOBOOT_ENCRYPTION=y CONFIG_AUTOBOOT_STOP_STR_SHA256="36a9e7f1c95b82ffb99743e0c5c4ce95d83c9a430aac59f84ef3cbfab6145068" CONFIG_PCA9551_LED=y -CONFIG_SPI_FLASH=yinclude/configs/tqma6_wru4.h +0
-0@@ -68,4 +68,12 @@#define CONFIG_SYS_BOOTCOUNT_ADDR IRAM_BASE_ADDR#define CONFIG_SYS_BOOTCOUNT_BE
include/configs/tqma6_wru4.h line 79
Quoted 10 lines
include/configs/tqma6_wru4.h +8
-0+/* +* Remove all unused interfaces / commands that are defined in +* the common header tqms6.h +*/ +#undef CONFIG_CMD_SF +#undef CONFIG_CMD_SPI +#undef CONFIG_MXC_SPI +#endif /* __CONFIG_TQMA6_WRU4_H */
I read the thread - Clemens, can you send your Tested-by after you tested with success the patch ? I will apply it, then..
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/1 arm: mx6: Remove SPI support from WRU-IV baseboard
Hi Stefano, Hi Stefan,
Quoted 7 lines · Stefano Babic
Hi Stefan, Clemens,
I read the thread - Clemens, can you send your Tested-by after you tested with success the patch ? I will apply it, then..
Best regards,
Stefano Babic
Although I am not convinced that ifdefs are as bad as Stefan thinks they are, the new patch works fine too. Thank you!
Regards,
Clemens
PATCH 1/1 arm: mx6: Remove SPI support from WRU-IV baseboard
Hi Clemens,
Quoted 5 lines · Clemens Gruber
Hi Stefano, Hi Stefan,
Quoted 2 lines · Stefano Babic
Hi Stefan, Clemens,
Quoted 9 lines
Quoted 5 lines
I read the thread - Clemens, can you send your Tested-by after you tested with success the patch ? I will apply it, then..
Best regards,
Stefano BabicAlthough I am not convinced that ifdefs are as bad as Stefan thinks they are, the new patch works fine too. Thank you!
We are trying to get rid of #ifdef as much as possible.
Quoted 2 lines
Tested-by Clemens Gruber <[email protected]>
Ok, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/1 arm: mx6: Remove SPI support from WRU-IV baseboard
Quoted 11 lines · Stefano Babic
Hi Clemens,
Quoted 8 lines · Clemens Gruber
Hi Stefano, Hi Stefan,
Quoted 5 lines · Stefano Babic
Hi Stefan, Clemens,
I read the thread - Clemens, can you send your Tested-by after you tested with success the patch ? I will apply it, then..
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Best regards,
Stefano BabicAlthough I am not convinced that ifdefs are as bad as Stefan thinks they are, the new patch works fine too. Thank you!
We are trying to get rid of #ifdef as much as possible.
Agreed Stefano, this is u-boot on-going development goal.
Quoted 7 lines
Quoted 3 lines
Tested-by Clemens Gruber <[email protected]>Ok, thanks !
thanks!
Signature · 1 line
Jagan | openedev.
PATCH 1/1 arm: mx6: Remove SPI support from WRU-IV baseboard
In reply to Stefan RoeseQuoted 7 lines · Stefan Roese
This patch removes the SPI support from the WRU-IV baseboard as its not used at all.
Signed-off-by Stefan Roese <[email protected]>Cc Clemens Gruber <[email protected]>Cc Markus Niebel <[email protected]>Cc Stefano Babic <[email protected]>
Quoted 52 lines
--- board/tqc/tqma6/tqma6.c | 1 + configs/tqma6s_wru4_mmc_defconfig | 3 --- include/configs/tqma6_wru4.h | 8 ++++++++ 3 files changed, 9 insertions(+), 3 deletions(-)board/tqc/tqma6/tqma6.c +1
-0@@ -25,6 +25,7 @@#include <mmc.h> #include <power/pfuze100_pmic.h> #include <power/pmic.h> +#include <spi_flash.h> #include "tqma6_bb.h" configs/tqma6s_wru4_mmc_defconfig +0
-3@@ -3,11 +3,8 @@ CONFIG_ARCH_MX6=y CONFIG_TARGET_TQMA6=y CONFIG_TQMA6S=y CONFIG_WRU4=y -CONFIG_CMD_SETEXPR=y -CONFIG_CMD_NET=y CONFIG_AUTOBOOT_KEYED=y CONFIG_AUTOBOOT_PROMPT="Enter password in %d seconds to stop autoboot\n" CONFIG_AUTOBOOT_ENCRYPTION=y CONFIG_AUTOBOOT_STOP_STR_SHA256="36a9e7f1c95b82ffb99743e0c5c4ce95d83c9a430aac59f84ef3cbfab6145068" CONFIG_PCA9551_LED=y -CONFIG_SPI_FLASH=yinclude/configs/tqma6_wru4.h +8
-1@@ -68,4 +68,12 @@#define CONFIG_SYS_BOOTCOUNT_ADDR IRAM_BASE_ADDR#define CONFIG_SYS_BOOTCOUNT_BE +/* +* Remove all unused interfaces / commands that are defined in +* the common header tqms6.h +*/ +#undef CONFIG_CMD_SF +#undef CONFIG_CMD_SPI +#undef CONFIG_MXC_SPI +#endif /* __CONFIG_TQMA6_WRU4_H */ --
Quoted 2 lines
2.4.8
thanks!
Signature · 1 line
Jagan | openedev.
PATCH 1/1 arm: mx6: Remove SPI support from WRU-IV baseboard
In reply to Stefan RoeseQuoted 49 lines · Stefan Roese
This patch removes the SPI support from the WRU-IV baseboard as its not used at all.
Signed-off-by Stefan Roese <[email protected]>Cc Clemens Gruber <[email protected]>Cc Markus Niebel <[email protected]>Cc Stefano Babic <[email protected]>--- board/tqc/tqma6/tqma6.c | 1 + configs/tqma6s_wru4_mmc_defconfig | 3 --- include/configs/tqma6_wru4.h | 8 ++++++++ 3 files changed, 9 insertions(+), 3 deletions(-)board/tqc/tqma6/tqma6.c +1
-0@@ -25,6 +25,7 @@#include <mmc.h> #include <power/pfuze100_pmic.h> #include <power/pmic.h> +#include <spi_flash.h> #include "tqma6_bb.h" configs/tqma6s_wru4_mmc_defconfig +0
-3@@ -3,11 +3,8 @@ CONFIG_ARCH_MX6=y CONFIG_TARGET_TQMA6=y CONFIG_TQMA6S=y CONFIG_WRU4=y -CONFIG_CMD_SETEXPR=y -CONFIG_CMD_NET=y CONFIG_AUTOBOOT_KEYED=y CONFIG_AUTOBOOT_PROMPT="Enter password in %d seconds to stop autoboot\n" CONFIG_AUTOBOOT_ENCRYPTION=y CONFIG_AUTOBOOT_STOP_STR_SHA256="36a9e7f1c95b82ffb99743e0c5c4ce95d83c9a430aac59f84ef3cbfab6145068" CONFIG_PCA9551_LED=y -CONFIG_SPI_FLASH=yinclude/configs/tqma6_wru4.h +0
-0@@ -68,4 +68,12 @@#define CONFIG_SYS_BOOTCOUNT_ADDR IRAM_BASE_ADDR#define CONFIG_SYS_BOOTCOUNT_BE
include/configs/tqma6_wru4.h line 79
Quoted 10 lines
include/configs/tqma6_wru4.h +8
-0+/* +* Remove all unused interfaces / commands that are defined in +* the common header tqms6.h +*/ +#undef CONFIG_CMD_SF +#undef CONFIG_CMD_SPI +#undef CONFIG_MXC_SPI +#endif /* __CONFIG_TQMA6_WRU4_H */
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================