Skip to contentSkip to conversation

commit a71b092 "ARM: Convert handle_IRQ to use __handle_domain_irq" breaks DNS-323

DISCUSSION Detlef Vollmann 3 participants 8 messages Aug 14, 2015

lore
Share & tools
lore

Detlef Vollmann

author
#0 lore raw

Hello,

this commit:

Quoted 5 lines

commit a71b092a9c68685a270ebdde7b5986ba8787e575

Author: Marc Zyngier <[email protected]>
Date:   Tue Aug 26 11:03:18 2014 +0100

ARM: Convert handle_IRQ to use __handle_domain_irq

[...]
causes the kernel not to boot anymore on my DNS-323.
Soc: MV88F5182 Rev 2
CPU: ARM926 (Rev 0) running @ 500Mhz
CPU: Feroceon [41069260] revision 0 (ARMv5TEJ), cr=a005317f Orion ID: MV88F5182-A2. TCLK=166666667.
DNS-323: Identified HW revision B1

Boot stops after "Uncompressing Linux... done, booting the kernel." Reverting the commit works fine for me.
Tested 4.1.2 and 4.2.0-rc6 with orion5x_defconfig.

Detlef

#1 lore raw

Hi Detlef,

Quoted 16 lines · Detlef Vollmann

Hello,

this commit:

Quoted 5 lines

commit a71b092a9c68685a270ebdde7b5986ba8787e575

Author: Marc Zyngier <[email protected]>
Date:   Tue Aug 26 11:03:18 2014 +0100

ARM: Convert handle_IRQ to use __handle_domain_irq

[...]
causes the kernel not to boot anymore on my DNS-323.
Soc: MV88F5182 Rev 2
CPU: ARM926 (Rev 0) running @ 500Mhz
CPU: Feroceon [41069260] revision 0 (ARMv5TEJ), cr=a005317f Orion ID: MV88F5182-A2. TCLK=166666667.
DNS-323: Identified HW revision B1

Quoted 3 lines

Boot stops after "Uncompressing Linux... done, booting the kernel." Reverting the commit works fine for me.
Tested 4.1.2 and 4.2.0-rc6 with orion5x_defconfig.

Could you try the following patch ?

http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/356501.html

Thanks,

Gregory

Quoted 8 lines

Detlef

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw
Quoted 19 lines · Gregory CLEMENT

Hi Detlef,

Quoted 16 lines · Detlef Vollmann

Hello,

this commit:

Quoted 5 lines

commit a71b092a9c68685a270ebdde7b5986ba8787e575

Author: Marc Zyngier <[email protected]>
Date:   Tue Aug 26 11:03:18 2014 +0100

ARM: Convert handle_IRQ to use __handle_domain_irq

[...]
causes the kernel not to boot anymore on my DNS-323.
Soc: MV88F5182 Rev 2
CPU: ARM926 (Rev 0) running @ 500Mhz
CPU: Feroceon [41069260] revision 0 (ARMv5TEJ), cr=a005317f Orion ID: MV88F5182-A2. TCLK=166666667.
DNS-323: Identified HW revision B1

Quoted 7 lines
Quoted 3 lines

Boot stops after "Uncompressing Linux... done, booting the kernel." Reverting the commit works fine for me.
Tested 4.1.2 and 4.2.0-rc6 with orion5x_defconfig.

Could you try the following patch ?

http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/356501.html

As a side note, having to revert that patch to get your system up and running is a reliable indication that something is wrong with your interrupt mapping, and that you are using 0 as a valid interrupt number (which has been declared invalid a long time ago by the chief penguin).

Hopefully Gregory has put you in the right direction.

Thanks,

	M.
Signature · 1 line
Jazz is not dead. It just smells funny...
author
#3 lore raw
Quoted 24 lines · Marc Zyngier
Quoted 23 lines · Gregory CLEMENT

Hi Detlef,

Quoted 19 lines · Detlef Vollmann

Hello,

this commit:

Quoted 5 lines

commit a71b092a9c68685a270ebdde7b5986ba8787e575

Author: Marc Zyngier <[email protected]>
Date:   Tue Aug 26 11:03:18 2014 +0100

ARM: Convert handle_IRQ to use __handle_domain_irq

[...]
causes the kernel not to boot anymore on my DNS-323.
Soc: MV88F5182 Rev 2
CPU: ARM926 (Rev 0) running @ 500Mhz
CPU: Feroceon [41069260] revision 0 (ARMv5TEJ), cr=a005317f Orion ID: MV88F5182-A2. TCLK=166666667.
DNS-323: Identified HW revision B1

Boot stops after "Uncompressing Linux... done, booting the kernel." Reverting the commit works fine for me.
Tested 4.1.2 and 4.2.0-rc6 with orion5x_defconfig.

Quoted 8 lines
Quoted 3 lines

Could you try the following patch ?

http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/356501.html

As a side note, having to revert that patch to get your system up and running is a reliable indication that something is wrong with your interrupt mapping, and that you are using 0 as a valid interrupt number (which has been declared invalid a long time ago by the chief penguin).

Well, in this case it wasn't me ;-)
I wanted to avoid looking at the sources myself as the DNS-323 is still a widely used hardware.

Quoted 1 line

Hopefully Gregory has put you in the right direction.

Yes. Now I'll use that patch until some fix is accepted in mainline.

Detlef

#4 lore raw
Quoted 27 lines · Detlef Vollmann
Quoted 26 lines · Marc Zyngier
Quoted 25 lines · Gregory CLEMENT

Hi Detlef,

Quoted 16 lines · Detlef Vollmann

Hello,

this commit:

Quoted 5 lines

commit a71b092a9c68685a270ebdde7b5986ba8787e575

Author: Marc Zyngier <[email protected]>
Date:   Tue Aug 26 11:03:18 2014 +0100

ARM: Convert handle_IRQ to use __handle_domain_irq

[...]
causes the kernel not to boot anymore on my DNS-323.
Soc: MV88F5182 Rev 2
CPU: ARM926 (Rev 0) running @ 500Mhz
CPU: Feroceon [41069260] revision 0 (ARMv5TEJ), cr=a005317f Orion ID: MV88F5182-A2. TCLK=166666667.
DNS-323: Identified HW revision B1

Quoted 3 lines

Boot stops after "Uncompressing Linux... done, booting the kernel." Reverting the commit works fine for me.
Tested 4.1.2 and 4.2.0-rc6 with orion5x_defconfig.

Could you try the following patch ?

Quoted 7 lines
Quoted 6 lines
Quoted 1 line

http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/356501.html

As a side note, having to revert that patch to get your system up and running is a reliable indication that something is wrong with your interrupt mapping, and that you are using 0 as a valid interrupt number (which has been declared invalid a long time ago by the chief penguin).

Well, in this case it wasn't me ;-)

Guilty by association! ;-)

Quoted 2 lines

I wanted to avoid looking at the sources myself as the DNS-323 is still a widely used hardware.

You're missing out! Think of all these sleepless nights you could spend staring at all kind of weird and fascinating code! :D

Quoted 2 lines
Quoted 1 line

Hopefully Gregory has put you in the right direction.

Yes. Now I'll use that patch until some fix is accepted in mainline.

Hopefully soon.

Thanks,

	M.
Signature · 1 line
Jazz is not dead. It just smells funny...
author
#5 lore raw
In reply to Gregory CLEMENT

Hi Gregory,

Quoted 17 lines · Gregory CLEMENT
Quoted 16 lines · Detlef Vollmann

Hello,

this commit:

Quoted 5 lines

commit a71b092a9c68685a270ebdde7b5986ba8787e575

Author: Marc Zyngier <[email protected]>
Date:   Tue Aug 26 11:03:18 2014 +0100

ARM: Convert handle_IRQ to use __handle_domain_irq

[...]
causes the kernel not to boot anymore on my DNS-323.
Soc: MV88F5182 Rev 2
CPU: ARM926 (Rev 0) running @ 500Mhz
CPU: Feroceon [41069260] revision 0 (ARMv5TEJ), cr=a005317f Orion ID: MV88F5182-A2. TCLK=166666667.
DNS-323: Identified HW revision B1

Quoted 7 lines
Quoted 3 lines

Boot stops after "Uncompressing Linux... done, booting the kernel." Reverting the commit works fine for me.
Tested 4.1.2 and 4.2.0-rc6 with orion5x_defconfig.

Could you try the following patch ?

http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/356501.html

Thanks for the pointer.
Yes, this patch fixes it :-)

I've also tested Arnd's patch at

http://git.kernel.org/cgit/linux/kernel/git/arnd/playground.git/commit/?h=multiplatform-4.2-next&id=44b55cab3bd74739e4c39205d41e1b2ed8953155

But at least in isolation this doesn't fix the problem.

Thanks again,
Detlef

#6 lore raw

Hi Detlef,

Quoted 27 lines · Detlef Vollmann

Hi Gregory,

Quoted 17 lines · Gregory CLEMENT
Quoted 16 lines · Detlef Vollmann

Hello,

this commit:

Quoted 5 lines

commit a71b092a9c68685a270ebdde7b5986ba8787e575

Author: Marc Zyngier <[email protected]>
Date:   Tue Aug 26 11:03:18 2014 +0100

ARM: Convert handle_IRQ to use __handle_domain_irq

[...]
causes the kernel not to boot anymore on my DNS-323.
Soc: MV88F5182 Rev 2
CPU: ARM926 (Rev 0) running @ 500Mhz
CPU: Feroceon [41069260] revision 0 (ARMv5TEJ), cr=a005317f Orion ID: MV88F5182-A2. TCLK=166666667.
DNS-323: Identified HW revision B1

Quoted 7 lines
Quoted 3 lines

Boot stops after "Uncompressing Linux... done, booting the kernel." Reverting the commit works fine for me.
Tested 4.1.2 and 4.2.0-rc6 with orion5x_defconfig.

Could you try the following patch ?

http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/356501.html

Quoted 8 lines

Thanks for the pointer.
Yes, this patch fixes it :-)

I've also tested Arnd's patch at

http://git.kernel.org/cgit/linux/kernel/git/arnd/playground.git/commit/?h=multiplatform-4.2-next&id=44b55cab3bd74739e4c39205d41e1b2ed8953155

But at least in isolation this doesn't fix the problem.

Thanks for doing these two tests, so I will take Benjamin and also add your Tested-by if you agree.

Gregory

Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
author
#7 lore raw
Quoted 33 lines · Gregory CLEMENT

Hi Detlef,

Quoted 30 lines · Detlef Vollmann

Hi Gregory,

Quoted 17 lines · Gregory CLEMENT
Quoted 16 lines · Detlef Vollmann

Hello,

this commit:

Quoted 5 lines

commit a71b092a9c68685a270ebdde7b5986ba8787e575

Author: Marc Zyngier <[email protected]>
Date:   Tue Aug 26 11:03:18 2014 +0100

ARM: Convert handle_IRQ to use __handle_domain_irq

[...]
causes the kernel not to boot anymore on my DNS-323.
Soc: MV88F5182 Rev 2
CPU: ARM926 (Rev 0) running @ 500Mhz
CPU: Feroceon [41069260] revision 0 (ARMv5TEJ), cr=a005317f Orion ID: MV88F5182-A2. TCLK=166666667.
DNS-323: Identified HW revision B1

Quoted 7 lines
Quoted 3 lines

Boot stops after "Uncompressing Linux... done, booting the kernel." Reverting the commit works fine for me.
Tested 4.1.2 and 4.2.0-rc6 with orion5x_defconfig.

Could you try the following patch ?

http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/356501.html

Thanks for the pointer.
Yes, this patch fixes it :-)

Quoted 7 lines
Quoted 5 lines

I've also tested Arnd's patch at

http://git.kernel.org/cgit/linux/kernel/git/arnd/playground.git/commit/?h=multiplatform-4.2-next&id=44b55cab3bd74739e4c39205d41e1b2ed8953155

But at least in isolation this doesn't fix the problem.

Thanks for doing these two tests,

Well, thanks for the pointer!

Quoted 2 lines

so I will take Benjamin and also add your
Tested-by if you agree.

Fine by me.

Thanks,
Detlef