Skip to contentSkip to conversation

ARM: davinci: remove support for CAM ENC 4xx

PATCH New Masahiro Yamada 4 participants 7 messages Aug 16, 2015 – Aug 18, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: davinci: remove support for CAM ENC 4xx

This has not been converted to Generic Board, so should be removed. (See doc/README.generic-board for details.)

---

 arch/arm/mach-davinci/Kconfig        |    5 -
 board/ait/cam_enc_4xx/Kconfig        |   12 -
 board/ait/cam_enc_4xx/MAINTAINERS    |    6 -
 board/ait/cam_enc_4xx/Makefile       |   10 -
 board/ait/cam_enc_4xx/cam_enc_4xx.c  | 1106 ----------------------------------
 board/ait/cam_enc_4xx/config.mk      |   20 -
 board/ait/cam_enc_4xx/u-boot-spl.lds |   57 --
 board/ait/cam_enc_4xx/ublimage.cfg   |   31 -
 configs/cam_enc_4xx_defconfig        |   10 -
 doc/README.scrapyard                 |    1 +
 include/configs/cam_enc_4xx.h        |  504 ----------------
 11 files changed, 1 insertion(+), 1761 deletions(-)
 delete mode 100644 board/ait/cam_enc_4xx/Kconfig
 delete mode 100644 board/ait/cam_enc_4xx/MAINTAINERS
 delete mode 100644 board/ait/cam_enc_4xx/Makefile
 delete mode 100644 board/ait/cam_enc_4xx/cam_enc_4xx.c
 delete mode 100644 board/ait/cam_enc_4xx/config.mk
 delete mode 100644 board/ait/cam_enc_4xx/u-boot-spl.lds
 delete mode 100644 board/ait/cam_enc_4xx/ublimage.cfg
 delete mode 100644 configs/cam_enc_4xx_defconfig
 delete mode 100644 include/configs/cam_enc_4xx.h
arch/arm/mach-davinci/Kconfig +0 -5
index e6cb390..681270d 100644
@@ -18,10 +18,6 @@ config TARGET_DA850EVM
 	bool "DA850 EVM board"
 	select SUPPORT_SPL
 
-config TARGET_CAM_ENC_4XX
-	bool "CAM ENC 4xx board"
-	select SUPPORT_SPL
-
 config TARGET_OMAPL138_LCDK
 	bool "OMAPL138 LCDK"
 	select SUPPORT_SPL
@@ -62,7 +58,6 @@ config SYS_SOC
 	default "davinci"
 
 source "board/enbw/enbw_cmc/Kconfig"
-source "board/ait/cam_enc_4xx/Kconfig"
 source "board/Barix/ipam390/Kconfig"
 source "board/davinci/da8xxevm/Kconfig"
 source "board/davinci/dm355evm/Kconfig"
board/ait/cam_enc_4xx/Kconfig deleted +0 -12
deleted file mode 100644
index 64e18f4..0000000
@@ -1,12 +0,0 @@
-if TARGET_CAM_ENC_4XX
-
-config SYS_BOARD
-	default "cam_enc_4xx"
-
-config SYS_VENDOR
-	default "ait"
-
-config SYS_CONFIG_NAME
-	default "cam_enc_4xx"
-
-endif
board/ait/cam_enc_4xx/MAINTAINERS deleted +0 -6
deleted file mode 100644
index d6477c6..0000000
@@ -1,6 +0,0 @@
-CAM_ENC_4XX BOARD
-M:	Heiko Schocher <[email protected]>
-S:	Maintained
-F:	board/ait/cam_enc_4xx/
-F:	include/configs/cam_enc_4xx.h
-F:	configs/cam_enc_4xx_defconfig
board/ait/cam_enc_4xx/Makefile deleted +0 -10
deleted file mode 100644
index 0d03ce0..0000000
@@ -1,10 +0,0 @@
-#
-# (C) Copyright 2000, 2001, 2002
-# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
-#
-# Copyright (C) 2007 Sergey Kubushyn <[email protected]>
-#
-# SPDX-License-Identifier:	GPL-2.0+
-#
-
-obj-y	:= cam_enc_4xx.o
board/ait/cam_enc_4xx/cam_enc_4xx.c deleted +0 -1106

1,106 lines not on this page · raw message

board/ait/cam_enc_4xx/config.mk deleted +0 -20
deleted file mode 100644
index 2022151..0000000
@@ -1,20 +0,0 @@
-#
-# 	AIT cam_enc_4xx board
-#	cam_enc_4xx board has 1 bank of 256 MB DDR RAM
-#	Physical Address: 8000'0000 to 9000'0000
-#
-# Linux Kernel is expected to be at 8000'8000, entry 8000'8000
-# (mem base + reserved)
-#
-
-UBL_CONFIG = $(srctree)/board/$(BOARDDIR)/ublimage.cfg
-ifndef CONFIG_SPL_BUILD
-ALL-y += u-boot.ubl
-else
-# as SPL_TEXT_BASE is not page-aligned, we need for some
-# linkers the -n flag (Do not page align data), to prevent
-# the following error message:
-# arm-linux-ld: u-boot-spl: Not enough room for program headers, try linking
-# with -N
-LDFLAGS_u-boot-spl += -n
-endif
board/ait/cam_enc_4xx/u-boot-spl.lds deleted +0 -57

57 lines not on this page · raw message

board/ait/cam_enc_4xx/ublimage.cfg deleted +0 -31
deleted file mode 100644
index d4fe705..0000000
@@ -1,31 +0,0 @@
-#
-# (C Copyright 2011
-# Heiko Schocher DENX Software Engineering hs at denx.de.
-#
-# SPDX-License-Identifier:	GPL-2.0+
-#
-# Refer doc/README.ublimage for more details about how-to configure
-# and create ublimage boot image
-#
-# The syntax is taken as close as possible with the kwbimage
-
-# UBL special mode : one of
-# safe (the board has no nand neither onenand)
-MODE	safe
-
-# Entry point address for the user bootloader (absolute address)
-# nand spl TEXT_BASE = 0x20 !!
-ENTRY	0x00000020
-
-# Number of pages (size of user bootloader in number of pages)
-# @ nand spl 6 pages
-PAGES	6
-
-# Block number where user bootloader is present
-START_BLOCK	0
-
-# Page number where user bootloader is present
-# Page 0 is always UBL header
-START_PAGE	0
-
-LD_ADDR		0x20
configs/cam_enc_4xx_defconfig deleted +0 -10
deleted file mode 100644
index a67bf0e..0000000
@@ -1,10 +0,0 @@
-CONFIG_ARM=y
-CONFIG_ARCH_DAVINCI=y
-CONFIG_TARGET_CAM_ENC_4XX=y
-CONFIG_SPL=y
-# CONFIG_CMD_IMLS is not set
-# CONFIG_CMD_FLASH is not set
-# CONFIG_CMD_FPGA is not set
-# CONFIG_CMD_SETEXPR is not set
-CONFIG_SPI_FLASH=y
-CONFIG_SYS_PROMPT="cam_enc_4xx> "
doc/README.scrapyard +1 -0
index f029a0f..63f86fc 100644
@@ -12,6 +12,7 @@ The list should be sorted in reverse chronological order.
 
 Board            Arch        CPU            Commit      Removed     Last known maintainer/contact
 =================================================================================================
+CAM_ENC_4xx      arm         arm926ejs      -           -           Heiko Schocher <[email protected]>
 atstk1003        avr32       -              e5354b8a    2015-06-10  Haavard Skinnemoen <[email protected]>
 atstk1004        avr32       -              e5354b8a    2015-06-10  Haavard Skinnemoen <[email protected]>
 atstk1006        avr32       -              e5354b8a    2015-06-10  Haavard Skinnemoen <[email protected]>
include/configs/cam_enc_4xx.h deleted +0 -504

504 lines not on this page · raw message

Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 ARM: davinci: remove support for CAM ENC 4xx

Hello Masahiro,

Am 16.08.2015 um 11:59 schrieb Masahiro Yamada:

Quoted 19 lines

This has not been converted to Generic Board, so should be removed. (See doc/README.generic-board for details.)

---

  arch/arm/mach-davinci/Kconfig        |    5 -
  board/ait/cam_enc_4xx/Kconfig        |   12 -
  board/ait/cam_enc_4xx/MAINTAINERS    |    6 -
  board/ait/cam_enc_4xx/Makefile       |   10 -
  board/ait/cam_enc_4xx/cam_enc_4xx.c  | 1106 ----------------------------------
  board/ait/cam_enc_4xx/config.mk      |   20 -
  board/ait/cam_enc_4xx/u-boot-spl.lds |   57 --
  board/ait/cam_enc_4xx/ublimage.cfg   |   31 -
  configs/cam_enc_4xx_defconfig        |   10 -
  doc/README.scrapyard                 |    1 +
  include/configs/cam_enc_4xx.h        |  504 ----------------
  11 files changed, 1 insertion(+), 1761 deletions(-)
Quoted 9 lines

delete mode 100644 board/ait/cam_enc_4xx/Kconfig delete mode 100644 board/ait/cam_enc_4xx/MAINTAINERS delete mode 100644 board/ait/cam_enc_4xx/Makefile delete mode 100644 board/ait/cam_enc_4xx/cam_enc_4xx.c delete mode 100644 board/ait/cam_enc_4xx/config.mk delete mode 100644 board/ait/cam_enc_4xx/u-boot-spl.lds delete mode 100644 board/ait/cam_enc_4xx/ublimage.cfg delete mode 100644 configs/cam_enc_4xx_defconfig delete mode 100644 include/configs/cam_enc_4xx.h

Thanks!

Just one nitpick ...

[...]

doc/README.scrapyard The list should be sorted in reverse chronological order. · line 15

Quoted 9 lines
doc/README.scrapyard +1 -0
index f029a0f..63f86fc 100644
@@ -12,6 +12,7 @@ The list should be sorted in reverse chronological order.
 
  Board            Arch        CPU            Commit      Removed     Last known maintainer/contact
  =================================================================================================
+CAM_ENC_4xx      arm         arm926ejs      -           -           Heiko Schocher <[email protected]>

Why do you use upper case for the board name?

doc/README.scrapyard The list should be sorted in reverse chronological order. · line 18

Quoted 3 lines
doc/README.scrapyard +0 -0
  atstk1003        avr32       -              e5354b8a    2015-06-10  Haavard Skinnemoen <[email protected]>
  atstk1004        avr32       -              e5354b8a    2015-06-10  Haavard Skinnemoen <[email protected]>
  atstk1006        avr32       -              e5354b8a    2015-06-10  Haavard Skinnemoen <[email protected]>

[...]

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#2 lore raw

PATCH 1/1 ARM: davinci: remove support for CAM ENC 4xx

2015-08-17 13:59 GMT+09:00 Heiko Schocher <[email protected]>:

Quoted 54 lines

Hello Masahiro,

Am 16.08.2015 um 11:59 schrieb Masahiro Yamada:

Quoted 21 lines

This has not been converted to Generic Board, so should be removed. (See doc/README.generic-board for details.)

---

  arch/arm/mach-davinci/Kconfig        |    5 -
  board/ait/cam_enc_4xx/Kconfig        |   12 -
  board/ait/cam_enc_4xx/MAINTAINERS    |    6 -
  board/ait/cam_enc_4xx/Makefile       |   10 -
  board/ait/cam_enc_4xx/cam_enc_4xx.c  | 1106
----------------------------------
  board/ait/cam_enc_4xx/config.mk      |   20 -
  board/ait/cam_enc_4xx/u-boot-spl.lds |   57 --
  board/ait/cam_enc_4xx/ublimage.cfg   |   31 -
  configs/cam_enc_4xx_defconfig        |   10 -
  doc/README.scrapyard                 |    1 +
  include/configs/cam_enc_4xx.h        |  504 ----------------
  11 files changed, 1 insertion(+), 1761 deletions(-)
Quoted 9 lines

delete mode 100644 board/ait/cam_enc_4xx/Kconfig delete mode 100644 board/ait/cam_enc_4xx/MAINTAINERS delete mode 100644 board/ait/cam_enc_4xx/Makefile delete mode 100644 board/ait/cam_enc_4xx/cam_enc_4xx.c delete mode 100644 board/ait/cam_enc_4xx/config.mk delete mode 100644 board/ait/cam_enc_4xx/u-boot-spl.lds delete mode 100644 board/ait/cam_enc_4xx/ublimage.cfg delete mode 100644 configs/cam_enc_4xx_defconfig delete mode 100644 include/configs/cam_enc_4xx.h

Thanks!

Just one nitpick ...

[...]

Quoted 11 lines
doc/README.scrapyard +0 -0
index f029a0f..63f86fc 100644
@@ -12,6 +12,7 @@ The list should be sorted in reverse chronological

order.

Board Arch CPU Commit Removed Last
known maintainer/contact

Quoted 6 lines
Quoted 3 lines

=================================================================================================
+CAM_ENC_4xx arm arm926ejs - - Heiko
Schocher <[email protected]>

Why do you use upper case for the board name?

I copied this name from the entry in arch/arm/mach-davinci/Kconfig, but I do not remember where it came from.

Which name do you think is the best?

cam_enc_4xx?

Signature · 2 lines
Best Regards
Masahiro Yamada
#3 lore raw

PATCH 1/1 ARM: davinci: remove support for CAM ENC 4xx

In reply to Masahiro Yamada
Quoted 21 lines · Masahiro Yamada

This has not been converted to Generic Board, so should be removed. (See doc/README.generic-board for details.)

---

 arch/arm/mach-davinci/Kconfig        |    5 -
 board/ait/cam_enc_4xx/Kconfig        |   12 -
 board/ait/cam_enc_4xx/MAINTAINERS    |    6 -
 board/ait/cam_enc_4xx/Makefile       |   10 -
 board/ait/cam_enc_4xx/cam_enc_4xx.c  | 1106
---------------------------------- board/ait/cam_enc_4xx/config.mk      | 
 20 -
 board/ait/cam_enc_4xx/u-boot-spl.lds |   57 --
 board/ait/cam_enc_4xx/ublimage.cfg   |   31 -
 configs/cam_enc_4xx_defconfig        |   10 -
 doc/README.scrapyard                 |    1 +
 include/configs/cam_enc_4xx.h        |  504 ----------------
 11 files changed, 1 insertion(+), 1761 deletions(-)
 delete mode 100644 board/ait/cam_enc_4xx/Kconfig
Quoted 8 lines
 delete mode 100644 board/ait/cam_enc_4xx/MAINTAINERS
 delete mode 100644 board/ait/cam_enc_4xx/Makefile
 delete mode 100644 board/ait/cam_enc_4xx/cam_enc_4xx.c
 delete mode 100644 board/ait/cam_enc_4xx/config.mk
 delete mode 100644 board/ait/cam_enc_4xx/u-boot-spl.lds
 delete mode 100644 board/ait/cam_enc_4xx/ublimage.cfg
 delete mode 100644 configs/cam_enc_4xx_defconfig
 delete mode 100644 include/configs/cam_enc_4xx.h

Hi,

FYI, next time you might want to do git format-patch -D to keep the patch smaller :)

Best regards,
Marek Vasut

#4 lore raw

PATCH 1/1 ARM: davinci: remove support for CAM ENC 4xx

Hi Marek,

CCing Simon,

2015-08-18 10:56 GMT+09:00 Marek Vasut <[email protected]>:

Quoted 31 lines · Masahiro Yamada
Quoted 21 lines

This has not been converted to Generic Board, so should be removed. (See doc/README.generic-board for details.)

---

 arch/arm/mach-davinci/Kconfig        |    5 -
 board/ait/cam_enc_4xx/Kconfig        |   12 -
 board/ait/cam_enc_4xx/MAINTAINERS    |    6 -
 board/ait/cam_enc_4xx/Makefile       |   10 -
 board/ait/cam_enc_4xx/cam_enc_4xx.c  | 1106
---------------------------------- board/ait/cam_enc_4xx/config.mk      |
 20 -
 board/ait/cam_enc_4xx/u-boot-spl.lds |   57 --
 board/ait/cam_enc_4xx/ublimage.cfg   |   31 -
 configs/cam_enc_4xx_defconfig        |   10 -
 doc/README.scrapyard                 |    1 +
 include/configs/cam_enc_4xx.h        |  504 ----------------
 11 files changed, 1 insertion(+), 1761 deletions(-)
 delete mode 100644 board/ait/cam_enc_4xx/Kconfig
Quoted 8 lines
 delete mode 100644 board/ait/cam_enc_4xx/MAINTAINERS
 delete mode 100644 board/ait/cam_enc_4xx/Makefile
 delete mode 100644 board/ait/cam_enc_4xx/cam_enc_4xx.c
 delete mode 100644 board/ait/cam_enc_4xx/config.mk
 delete mode 100644 board/ait/cam_enc_4xx/u-boot-spl.lds
 delete mode 100644 board/ait/cam_enc_4xx/ublimage.cfg
 delete mode 100644 configs/cam_enc_4xx_defconfig
 delete mode 100644 include/configs/cam_enc_4xx.h
Quoted 6 lines

Hi,

FYI, next time you might want to do git format-patch -D to keep the patch smaller :)

I use Patman to send patches.

Patman generates smaller patches for file move (with format-patch -M), but does not for file removal.

Simon,
Do you think Patman should do it?

Signature · 2 lines
Best Regards
Masahiro Yamada
#5 lore raw

PATCH 1/1 ARM: davinci: remove support for CAM ENC 4xx

Hi Masahiro,

Quoted 45 lines · Masahiro Yamada

Hi Marek,

CCing Simon,

2015-08-18 10:56 GMT+09:00 Marek Vasut <[email protected]>:

Quoted 31 lines · Masahiro Yamada
Quoted 21 lines

This has not been converted to Generic Board, so should be removed. (See doc/README.generic-board for details.)

---

 arch/arm/mach-davinci/Kconfig        |    5 -
 board/ait/cam_enc_4xx/Kconfig        |   12 -
 board/ait/cam_enc_4xx/MAINTAINERS    |    6 -
 board/ait/cam_enc_4xx/Makefile       |   10 -
 board/ait/cam_enc_4xx/cam_enc_4xx.c  | 1106
---------------------------------- board/ait/cam_enc_4xx/config.mk      |
 20 -
 board/ait/cam_enc_4xx/u-boot-spl.lds |   57 --
 board/ait/cam_enc_4xx/ublimage.cfg   |   31 -
 configs/cam_enc_4xx_defconfig        |   10 -
 doc/README.scrapyard                 |    1 +
 include/configs/cam_enc_4xx.h        |  504 ----------------
 11 files changed, 1 insertion(+), 1761 deletions(-)
 delete mode 100644 board/ait/cam_enc_4xx/Kconfig
Quoted 8 lines
 delete mode 100644 board/ait/cam_enc_4xx/MAINTAINERS
 delete mode 100644 board/ait/cam_enc_4xx/Makefile
 delete mode 100644 board/ait/cam_enc_4xx/cam_enc_4xx.c
 delete mode 100644 board/ait/cam_enc_4xx/config.mk
 delete mode 100644 board/ait/cam_enc_4xx/u-boot-spl.lds
 delete mode 100644 board/ait/cam_enc_4xx/ublimage.cfg
 delete mode 100644 configs/cam_enc_4xx_defconfig
 delete mode 100644 include/configs/cam_enc_4xx.h
Quoted 6 lines

Hi,

FYI, next time you might want to do git format-patch -D to keep the patch smaller :)

Quoted 8 lines

I use Patman to send patches.

Patman generates smaller patches for file move (with format-patch -M), but does not for file removal.

Simon,
Do you think Patman should do it?

Yes, I think so.

Regards,
Simon

#6 lore raw

PATCH 1/1 ARM: davinci: remove support for CAM ENC 4xx

Simon,

2015-08-18 11:19 GMT+09:00 Simon Glass <[email protected]>:

Quoted 11 lines
Quoted 11 lines
Quoted 7 lines

Hi,

FYI, next time you might want to do git format-patch -D to keep the patch smaller :)

I use Patman to send patches.

Quoted 9 lines
Quoted 6 lines

Patman generates smaller patches for file move (with format-patch -M), but does not for file removal.

Simon,
Do you think Patman should do it?

Yes, I think so.

OK, I've sent a patch.

http://patchwork.ozlabs.org/patch/508155/

Signature · 2 lines
Best Regards
Masahiro Yamada