Skip to contentSkip to conversation

ARM: multi_v7_defconfig: Enable DWC2 USB driver and USB ethernet gadget

PATCH Superseded Marek Szyprowski 3 participants 4 messages Aug 18, 2015 – Aug 19, 2015

Subsystems (2)
Arm (32-bit) Arm Samsung Exynos
lore
Share & tools
lore

Marek Szyprowski

author
#0 lore raw

PATCH 1/1 ARM: multi_v7_defconfig: Enable DWC2 USB driver and USB ethernet gadget

DWC2 (s3c-hsotg) hardware module is available on many Exynos based boards, so enable DWC2 driver as well as the most common USB Ethernet gadget.

Signed-off-by Marek Szyprowski <[email protected]>
---
 arch/arm/configs/multi_v7_defconfig | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/configs/multi_v7_defconfig +2 -0
index b2facab..d15f719 100644
@@ -506,6 +506,7 @@ CONFIG_USB_R8A66597_HCD=m
 CONFIG_USB_RENESAS_USBHS=m
 CONFIG_USB_STORAGE=y
 CONFIG_USB_DWC3=y
+CONFIG_USB_DWC2=y
 CONFIG_USB_CHIPIDEA=y
 CONFIG_USB_CHIPIDEA_HOST=y
 CONFIG_AB8500_USB=y

@@ -517,6 +518,7 @@ CONFIG_USB_MXS_PHY=y
 CONFIG_USB_RCAR_PHY=m
 CONFIG_USB_GADGET=y
 CONFIG_USB_RENESAS_USBHS_UDC=m
+CONFIG_USB_ETH=y
 CONFIG_MMC=y
 CONFIG_MMC_BLOCK_MINORS=16
 CONFIG_MMC_ARMMMCI=y
Signature · 1 line
1.9.2
#1 lore raw

PATCH 1/1 ARM: multi_v7_defconfig: Enable DWC2 USB driver and USB ethernet gadget

Hello Marek,

Quoted 22 lines · Marek Szyprowski

DWC2 (s3c-hsotg) hardware module is available on many Exynos based boards, so enable DWC2 driver as well as the most common USB Ethernet gadget.

Signed-off-by Marek Szyprowski <[email protected]>
---
 arch/arm/configs/multi_v7_defconfig | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/configs/multi_v7_defconfig +1 -0
index b2facab..d15f719 100644
@@ -506,6 +506,7 @@ CONFIG_USB_R8A66597_HCD=m
 CONFIG_USB_RENESAS_USBHS=m
 CONFIG_USB_STORAGE=y
 CONFIG_USB_DWC3=y
+CONFIG_USB_DWC2=y
 CONFIG_USB_CHIPIDEA=y
 CONFIG_USB_CHIPIDEA_HOST=y
 CONFIG_AB8500_USB=y

arch/arm/configs/multi_v7_defconfig CONFIG_USB_MXS_PHY=y · line 524

Quoted 7 lines
arch/arm/configs/multi_v7_defconfig +1 -0
@@ -517,6 +518,7 @@ CONFIG_USB_MXS_PHY=y
 CONFIG_USB_RCAR_PHY=m
 CONFIG_USB_GADGET=y
 CONFIG_USB_RENESAS_USBHS_UDC=m
+CONFIG_USB_ETH=y
 CONFIG_MMC=y
 CONFIG_MMC_BLOCK_MINORS=16
 CONFIG_MMC_ARMMMCI=y

Both are tristate Kconfig symbols and the current multi_v7 policy is to build as much as possible as a module.

Other than that the patch looks good to me. So if you change that:

Reviewed-by Javier Martinez Canillas <[email protected]>

Best regards,

Signature · 3 lines
Javier Martinez Canillas
Open Source Group
Samsung Research America
author
#2 lore raw

PATCH v2 1/1 ARM: multi_v7_defconfig: Enable DWC2 USB driver and USB ethernet gadget

DWC2 (s3c-hsotg) hardware module is available on many Exynos based boards, so enable DWC2 driver as well as the most common USB Ethernet gadget.

Signed-off-by Marek Szyprowski <[email protected]>
Reviewed-by Javier Martinez Canillas <[email protected]>

---
Changes since v1: build DWC2 and USB gadget as modules

---
 arch/arm/configs/multi_v7_defconfig | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/configs/multi_v7_defconfig +2 -0
index b2facab..d15f719 100644
@@ -506,6 +506,7 @@ CONFIG_USB_R8A66597_HCD=m
 CONFIG_USB_RENESAS_USBHS=m
 CONFIG_USB_STORAGE=y
 CONFIG_USB_DWC3=y
+CONFIG_USB_DWC2=m
 CONFIG_USB_CHIPIDEA=y
 CONFIG_USB_CHIPIDEA_HOST=y
 CONFIG_AB8500_USB=y

@@ -517,6 +518,7 @@ CONFIG_USB_MXS_PHY=y
 CONFIG_USB_RCAR_PHY=m
 CONFIG_USB_GADGET=y
 CONFIG_USB_RENESAS_USBHS_UDC=m
+CONFIG_USB_ETH=m
 CONFIG_MMC=y
 CONFIG_MMC_BLOCK_MINORS=16
 CONFIG_MMC_ARMMMCI=y
Signature · 1 line
1.9.2
#3 lore raw

PATCH v2 1/1 ARM: multi_v7_defconfig: Enable DWC2 USB driver and USB ethernet gadget

Quoted 10 lines · Marek Szyprowski

DWC2 (s3c-hsotg) hardware module is available on many Exynos based boards, so enable DWC2 driver as well as the most common USB Ethernet gadget.

Signed-off-by Marek Szyprowski <[email protected]>
Reviewed-by Javier Martinez Canillas <[email protected]>

---
Changes since v1: build DWC2 and USB gadget as modules

---
 arch/arm/configs/multi_v7_defconfig | 2 ++
 1 file changed, 2 insertions(+)

Thanks Marek for the patch.

Reviewed-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof