Skip to contentSkip to conversation

Add VIN and ADV7180 device tree support for R8A7794/SILK board

PATCH New Sergei Shtylyov 2 participants 9 messages Aug 19, 2015 – Oct 9, 2015

Subsystems (2)
Device tree bindings SuperH
lore
Share & tools
lore

Sergei Shtylyov

author
#0 lore raw

cover Add VIN and ADV7180 device tree support for R8A7794/SILK board

Hello.

Here's the set of 2 patches against Simon Horman's 'renesas.git' repo's
'renesas-devel-20150819-v4.2-rc7' tag. Here we add the VIN and ADV7180 video decoder device tree support on the R8A7794/SILK board. The patchset requires previously posted SILK SDHI1 support patch in order to apply and R8A7794/SILK I2C1 support in order to apply and build.

[1/2] ARM: shmobile: r8a7794: add VIN DT support [2/2] ARM: shmobile: silk: add VIN0/ADV7180 DT support

MBR, Sergei

author
#1 lore raw

PATCH 1/2 ARM: shmobile: r8a7794: add VIN DT support

Define the generic R8A7794 part of the VIN[01] device nodes. Add aliases for the VIN[01] device nodes.

Signed-off-by Sergei Shtylyov <[email protected]>
---
 arch/arm/boot/dts/r8a7794.dtsi |   20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
arch/arm/boot/dts/r8a7794.dtsi +20 -0
Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
===================================================================
@@ -27,6 +27,8 @@
 		i2c4 = &i2c4;
 		i2c5 = &i2c5;
 		spi0 = &qspi;
+		vin0 = &vin0;
+		vin1 = &vin1;
 	};
 
 	cpus {

@@ -628,6 +630,24 @@
 		status = "disabled";
 	};
 
+	vin0: video at e6ef0000 {
+		compatible = "renesas,vin-r8a7794";
+		reg = <0 0xe6ef0000 0 0x1000>;
+		interrupts = <0 188 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp8_clks R8A7794_CLK_VIN0>;
+		power-domains = <&cpg_clocks>;
+		status = "disabled";
+	};
+
+	vin1: video at e6ef1000 {
+		compatible = "renesas,vin-r8a7794";
+		reg = <0 0xe6ef1000 0 0x1000>;
+		interrupts = <0 189 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp8_clks R8A7794_CLK_VIN1>;
+		power-domains = <&cpg_clocks>;
+		status = "disabled";
+	};
+
 	clocks {
 		#address-cells = <2>;
 		#size-cells = <2>;
author
#2 lore raw

PATCH 2/2 ARM: shmobile: silk: add VIN0/ADV7180 DT support

In reply to Sergei Shtylyov

Define the SILK board dependent part of the VIN0 device node. Add the device node for Analog Devices ADV7180 video decoder to I2C1 bus. Add the necessary subnodes to interconnect VIN0 and ADV7180 devices.

Based on the Henninger VIN0/ADV8170 device tree patch by myself.

Signed-off-by Sergei Shtylyov <[email protected]>
---
 arch/arm/boot/dts/r8a7794-silk.dts |   35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)
arch/arm/boot/dts/r8a7794-silk.dts +35 -0
Index: renesas/arch/arm/boot/dts/r8a7794-silk.dts
===================================================================
@@ -104,6 +104,11 @@
 		renesas,groups = "qspi_ctrl", "qspi_data4";
 		renesas,function = "qspi";
 	};
+
+	vin0_pins: vin0 {
+		renesas,groups = "vin0_data8", "vin0_clk";
+		renesas,function = "vin0";
+	};
 };
 
 &scif2 {

@@ -135,6 +140,19 @@
 
 	status = "okay";
 	clock-frequency = <400000>;
+
+	composite-in at 20 {
+		compatible = "adi,adv7180";
+		reg = <0x20>;
+		remote = <&vin0>;
+
+		port {
+			adv7180: endpoint {
+				bus-width = <8>;
+				remote-endpoint = <&vin0ep>;
+			};
+		};
+	};
 };
 
 &mmcif0 {

@@ -193,3 +211,20 @@
 		};
 	};
 };
+
+/* composite video input */
+&vin0 {
+	status = "okay";
+	pinctrl-0 = <&vin0_pins>;
+	pinctrl-names = "default";
+
+	port {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		vin0ep: endpoint {
+			remote-endpoint = <&adv7180>;
+			bus-width = <8>;
+		};
+	};
+};
#3 lore raw

cover Add VIN and ADV7180 device tree support for R8A7794/SILK board

In reply to Sergei Shtylyov
Quoted 10 lines · Sergei Shtylyov

Hello.

Here's the set of 2 patches against Simon Horman's 'renesas.git' repo's
'renesas-devel-20150819-v4.2-rc7' tag. Here we add the VIN and ADV7180 video decoder device tree support on the R8A7794/SILK board. The patchset requires previously posted SILK SDHI1 support patch in order to apply and R8A7794/SILK I2C1 support in order to apply and build.

[1/2] ARM: shmobile: r8a7794: add VIN DT support [2/2] ARM: shmobile: silk: add VIN0/ADV7180 DT support

Thanks, I have queued these up for v4.4.

author
#4 lore raw

cover Add VIN and ADV7180 device tree support for R8A7794/SILK board

Quoted 10 lines · Simon Horman
Quoted 8 lines

Here's the set of 2 patches against Simon Horman's 'renesas.git' repo's
'renesas-devel-20150819-v4.2-rc7' tag. Here we add the VIN and ADV7180 video decoder device tree support on the R8A7794/SILK board. The patchset requires previously posted SILK SDHI1 support patch in order to apply and R8A7794/SILK I2C1 support in order to apply and build.

[1/2] ARM: shmobile: r8a7794: add VIN DT support [2/2] ARM: shmobile: silk: add VIN0/ADV7180 DT support

Thanks, I have queued these up for v4.4.

Perhaps a bit too early: the PFC VIN patch hasn't been merged yet. Sorry
for not specifying the PFC dependency...

MBR, Sergei

author
#5 lore raw

cover Add VIN and ADV7180 device tree support for R8A7794/SILK board

Quoted 6 lines · Sergei Shtylyov
Quoted 6 lines
Quoted 6 lines

Here's the set of 2 patches against Simon Horman's 'renesas.git' repo's
'renesas-devel-20150819-v4.2-rc7' tag. Here we add the VIN and ADV7180 video decoder device tree support on the R8A7794/SILK board. The patchset requires previously posted SILK SDHI1 support patch in order to apply and R8A7794/SILK I2C1 support in order to apply and build.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

[1/2] ARM: shmobile: r8a7794: add VIN DT support [2/2] ARM: shmobile: silk: add VIN0/ADV7180 DT support

Thanks, I have queued these up for v4.4.

Perhaps a bit too early: the PFC VIN patch hasn't been merged yet. Sorry
for not specifying the PFC dependency...

OTOH, the frames get captured somehow even without the PFC patch, so might
as well leave these patches applied. Your choice...

MBR, Sergei

#6 lore raw

cover Add VIN and ADV7180 device tree support for R8A7794/SILK board

Quoted 11 lines · Sergei Shtylyov
Quoted 9 lines · Sergei Shtylyov
Quoted 9 lines
Quoted 8 lines

Here's the set of 2 patches against Simon Horman's 'renesas.git' repo's
'renesas-devel-20150819-v4.2-rc7' tag. Here we add the VIN and ADV7180 video decoder device tree support on the R8A7794/SILK board. The patchset requires previously posted SILK SDHI1 support patch in order to apply and R8A7794/SILK I2C1 support in order to apply and build.

[1/2] ARM: shmobile: r8a7794: add VIN DT support [2/2] ARM: shmobile: silk: add VIN0/ADV7180 DT support

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Thanks, I have queued these up for v4.4.

Perhaps a bit too early: the PFC VIN patch hasn't been merged yet. Sorry
for not specifying the PFC dependency...

OTOH, the frames get captured somehow even without the PFC patch, so
might as well leave these patches applied. Your choice...

Thanks. I will defer these patches for now.

author
#7 lore raw

PATCH 1/1 ARM: shmobile: porter: add VIN0/ADV7180 DT support

In reply to Sergei Shtylyov

Define the Porter board dependent part of the VIN0 device node. Add the device node for Analog Devices ADV7180 video decoder to I2C2 bus. Add the necessary subnodes to interconnect VIN0 and ADV7180 devices.

This patch is analogous to the commit 8d62f4f75320 ("ARM: shmobile:
henninger: add VIN0/ADV7180 DT support") as there are no differences between the boards in this respect.

Signed-off-by Sergei Shtylyov <[email protected]>

---
This patch is against 'renesas-devel-20151008-v4.3-rc4' tag of Simon Horman's 'renesas.git' repo plus the Porter I2C2 support patch just posted.

 arch/arm/boot/dts/r8a7791-porter.dts |   35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)
arch/arm/boot/dts/r8a7791-porter.dts +35 -0
Index: renesas/arch/arm/boot/dts/r8a7791-porter.dts
===================================================================
@@ -114,6 +114,11 @@
 		renesas,groups = "i2c2";
 		renesas,function = "i2c2";
 	};
+
+	vin0_pins: vin0 {
+		renesas,groups = "vin0_data8", "vin0_clk";
+		renesas,function = "vin0";
+	};
 };
 
 &scif0 {

@@ -166,8 +171,38 @@
 
 	status = "okay";
 	clock-frequency = <400000>;
+
+	composite-in at 20 {
+		compatible = "adi,adv7180";
+		reg = <0x20>;
+		remote = <&vin0>;
+
+		port {
+			adv7180: endpoint {
+				bus-width = <8>;
+				remote-endpoint = <&vin0ep>;
+			};
+		};
+	};
 };
 
 &sata0 {
 	status = "okay";
 };
+
+/* composite video input */
+&vin0 {
+	status = "ok";
+	pinctrl-0 = <&vin0_pins>;
+	pinctrl-names = "default";
+
+	port {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		vin0ep: endpoint {
+			remote-endpoint = <&adv7180>;
+			bus-width = <8>;
+		};
+	};
+};
#8 lore raw

PATCH 1/1 ARM: shmobile: porter: add VIN0/ADV7180 DT support

Quoted 9 lines · Sergei Shtylyov

Define the Porter board dependent part of the VIN0 device node. Add the device node for Analog Devices ADV7180 video decoder to I2C2 bus. Add the necessary subnodes to interconnect VIN0 and ADV7180 devices.

This patch is analogous to the commit 8d62f4f75320 ("ARM: shmobile:
henninger: add VIN0/ADV7180 DT support") as there are no differences between the boards in this respect.

Signed-off-by Sergei Shtylyov <[email protected]>

Thanks Sergei,
I have queued this one up for v4.4 too.