efl bump to 1.14.2

RFC New vj 2 participants 13 messages Aug 21, 2015 – Oct 9, 2015

Share & tools

vj

author

2015-08-21 00:30 UTC #0 lore raw

cover efl bump to 1.14.2

Hello Romain,
I've tested you efl update
https://github.com/RomainNaour/buildroot/tree/efl-1.15.0-v1
It did not work, :(
But applying the two patches below works again! The first one was already commented in a previous e-mail. The second is related to a regression in efl-1.15.0. The testing I've done has been with the musl libc and with BR2_PACKAGE_EFL_RECOMMENDED_CONFIG unset. Basically the same config as in the previous e-mail.

A minor issue: check the spelling of recommanded.

Regards,
Vicente.

In-Reply-To=<[email protected]>

Tested-by vicencb <[email protected]>

package/efl/Config.in +2 -0

index 3de717f..8cc0f91 100644
@@ -11,6 +11,8 @@ config BR2_PACKAGE_EFL
     select BR2_PACKAGE_JPEG # Emile needs libjpeg
     select BR2_PACKAGE_LIBCURL # eina_module, runtime dependency
     select BR2_PACKAGE_LUA # Evas lua 5.1 or 5.2
+    select BR2_PACKAGE_UTIL_LINUX
+    select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
     select BR2_PACKAGE_LIBXKBCOMMON if BR2_PACKAGE_WAYLAND
     help
       Enlightenment Foundation Libraries

package/efl/efl.mk +5 -0

index 2d29375..d785efc 100644
@@ -15,6 +15,11 @@ EFL_INSTALL_STAGING = YES
 EFL_DEPENDENCIES = host-pkgconf host-efl dbus freetype jpeg libcurl lua udev \
     zlib
 
+# In 1.15.0 there is a regression with missing symbols,
+# at least when trying to load the fb module.
+# Making all symbols visible by default fixes the problem.
+EFL_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -fvisibility=default"
+
 # Configure options:
 # --disable-cxx-bindings: disable C++11 bindings.
 # --enable-lua-old: disable Elua and remove luajit dependency.

Romain Naour

2015-08-21 09:51 UTC #1 lore raw

cover efl bump to 1.14.2

Hi Vicente,

Le 21/08/2015 02:30, vj a ?crit :

Quoted 6 lines

Hello Romain,
I've tested you efl update
https://github.com/RomainNaour/buildroot/tree/efl-1.15.0-v1
It did not work, :(
But applying the two patches below works again! The first one was already commented in a previous e-mail.

Yes, sorry I haven't looked at your issue yet.

libmount seems to be optional and can be disabled with --disable-libmount:
https://github.com/RomainNaour/buildroot/blob/efl-1.15.0-v1/package/efl/efl.mk#L35

But since it's not recommended to disable it, I'll apply your patch :)

Quoted 1 line

The second is related to a regression in efl-1.15.0.

Can you report your issue to the efl mailing list ?

Quoted 5 lines

The testing I've done has been with the musl libc and with BR2_PACKAGE_EFL_RECOMMENDED_CONFIG unset. Basically the same config as in the previous e-mail.
A minor issue: check the spelling of recommanded.

Ha indeed recommanded is used in Config.in prompt
(my French was turned on sorry ;-) )

Thanks for testing!

Best regards,
Romain

Quoted 43 lines

Regards,
Vicente.

In-Reply-To=<[email protected]>

Tested-by vicencb <[email protected]>

package/efl/Config.in +2 -0

index 3de717f..8cc0f91 100644
@@ -11,6 +11,8 @@ config BR2_PACKAGE_EFL
     select BR2_PACKAGE_JPEG # Emile needs libjpeg
     select BR2_PACKAGE_LIBCURL # eina_module, runtime dependency
     select BR2_PACKAGE_LUA # Evas lua 5.1 or 5.2
+    select BR2_PACKAGE_UTIL_LINUX
+    select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
     select BR2_PACKAGE_LIBXKBCOMMON if BR2_PACKAGE_WAYLAND
     help
       Enlightenment Foundation Libraries

package/efl/efl.mk +5 -0

index 2d29375..d785efc 100644
@@ -15,6 +15,11 @@ EFL_INSTALL_STAGING = YES
 EFL_DEPENDENCIES = host-pkgconf host-efl dbus freetype jpeg libcurl lua udev \
     zlib
 
+# In 1.15.0 there is a regression with missing symbols,
+# at least when trying to load the fb module.
+# Making all symbols visible by default fixes the problem.
+EFL_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -fvisibility=default"
+
 # Configure options:
 # --disable-cxx-bindings: disable C++11 bindings.
 # --enable-lua-old: disable Elua and remove luajit dependency.

Romain Naour

2015-08-21 10:18 UTC #2 lore raw

cover efl bump to 1.14.2

Hi Vicente,

Quoted 1 line

Quoted 1 line
Tested-by vicencb <[email protected]>

Can you use your real name here.

Thanks!

Best regards,
Romain

vj

author

2015-08-21 17:56 UTC #3 lore raw

cover efl bump to 1.14.2

In reply to Romain Naour

Hello Romain,

Quoted 10 lines · Romain Naour

Hi Vicente,
Le 21/08/2015 02:30, vj a ?crit :
Quoted 6 lines
Hello Romain,
I've tested you efl update
https://github.com/RomainNaour/buildroot/tree/efl-1.15.0-v1
It did not work, :(
But applying the two patches below works again! The first one was already commented in a previous e-mail.

Quoted 4 lines

Yes, sorry I haven't looked at your issue yet.
libmount seems to be optional and can be disabled with --disable-libmount:
https://github.com/RomainNaour/buildroot/blob/efl-1.15.0-v1/package/efl/efl.mk#L35

Without that dependency it failed with 1.14.2.
When I saw the dependency was not there in 1.15.0, I just added it again without checking.
Just now I've tried it again without that patch and it's fine, so, you can forget it.
Sorry for the hassle.

Quoted 6 lines

But since it's not recommended to disable it, I'll apply your patch :)
Quoted 1 line
The second is related to a regression in efl-1.15.0.
Can you report your issue to the efl mailing list ?

I know it would be better to have it fixed upstream, but have no time for that now.
If you would like to, feel free to report it.
To debug it, it helps enabling the WRN and DGB macros in eina_module.c.

Quoted 11 lines

Quoted 6 lines
The testing I've done has been with the musl libc and with BR2_PACKAGE_EFL_RECOMMENDED_CONFIG unset. Basically the same config as in the previous e-mail.
A minor issue: check the spelling of recommanded.
Ha indeed recommanded is used in Config.in prompt
(my French was turned on sorry ;-) )
Thanks for testing!

Thanks for adding musl and maintaining efl!

Quoted 10 lines

Best regards,
Romain
Quoted 7 lines
Regards,
Vicente.
--
In-Reply-To=<[email protected]>

Tested-by Vicente Bergas <[email protected]>

Quoted 36 lines

Quoted 35 lines

package/efl/Config.in +2 -0

index 3de717f..8cc0f91 100644
@@ -11,6 +11,8 @@ config BR2_PACKAGE_EFL
     select BR2_PACKAGE_JPEG # Emile needs libjpeg
     select BR2_PACKAGE_LIBCURL # eina_module, runtime dependency
     select BR2_PACKAGE_LUA # Evas lua 5.1 or 5.2
+    select BR2_PACKAGE_UTIL_LINUX
+    select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
     select BR2_PACKAGE_LIBXKBCOMMON if BR2_PACKAGE_WAYLAND
     help
       Enlightenment Foundation Libraries

package/efl/efl.mk +5 -0

index 2d29375..d785efc 100644
@@ -15,6 +15,11 @@ EFL_INSTALL_STAGING = YES
 EFL_DEPENDENCIES = host-pkgconf host-efl dbus freetype jpeg libcurl lua udev \
     zlib
 
+# In 1.15.0 there is a regression with missing symbols,
+# at least when trying to load the fb module.
+# Making all symbols visible by default fixes the problem.
+EFL_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -fvisibility=default"
+
 # Configure options:
 # --disable-cxx-bindings: disable C++11 bindings.
 # --enable-lua-old: disable Elua and remove luajit dependency.

Romain Naour

2015-08-24 21:42 UTC #4 lore raw

cover efl bump to 1.14.2

Hi Vicente

Le 21/08/2015 19:56, vj a ?crit :

Quoted 18 lines

Hello Romain,
Quoted 10 lines · Romain Naour
Hi Vicente,
Le 21/08/2015 02:30, vj a ?crit :
Quoted 6 lines
Hello Romain,
I've tested you efl update
https://github.com/RomainNaour/buildroot/tree/efl-1.15.0-v1
It did not work, :(
But applying the two patches below works again! The first one was already commented in a previous e-mail.
Quoted 4 lines
Yes, sorry I haven't looked at your issue yet.
libmount seems to be optional and can be disabled with --disable-libmount:
https://github.com/RomainNaour/buildroot/blob/efl-1.15.0-v1/package/efl/efl.mk#L35

Quoted 6 lines

Without that dependency it failed with 1.14.2.
When I saw the dependency was not there in 1.15.0, I just added it again without checking.
Just now I've tried it again without that patch and it's fine, so, you can forget it.
Sorry for the hassle.

It's ok ;-) I haven't heavily tested with a minimal config.
Maybe next time can you post the last ~100 build log lines, it not always easy to reproduce a build issue...

Quoted 4 lines

Quoted 4 lines
But since it's not recommended to disable it, I'll apply your patch :)

Quoted 8 lines

Quoted 3 lines
Quoted 1 line
The second is related to a regression in efl-1.15.0.
Can you report your issue to the efl mailing list ?
I know it would be better to have it fixed upstream, but have no time for that now.
If you would like to, feel free to report it.
To debug it, it helps enabling the WRN and DGB macros in eina_module.c.

Well, I can't really report an issue that I can't reproduce.

See, I reported the issue about SDL2 dependency and it's now fixed in the efl 1.15.1. So, I can drop the last patch and avoid to autoreconf the package.

Also, I'm probably not the good person to report an efl issue. Honestly, I don't know what to do with -fvisibility=default.
It would be better if you can send just an email to the enlightenment mailing list to report your issue.

Quoted 6 lines

Quoted 6 lines
Quoted 6 lines
The testing I've done has been with the musl libc and with BR2_PACKAGE_EFL_RECOMMENDED_CONFIG unset. Basically the same config as in the previous e-mail.

Quoted 8 lines

Quoted 6 lines
Quoted 1 line
A minor issue: check the spelling of recommanded.
Ha indeed recommanded is used in Config.in prompt
(my French was turned on sorry ;-) )
Thanks for testing!
Thanks for adding musl and maintaining efl!

You're welcome!

Best regards,
Romain

vj

author

2015-08-24 22:09 UTC #5 lore raw

cover efl bump to 1.14.2

Hello Romain,

Quoted 38 lines · Romain Naour

Hi Vicente
Le 21/08/2015 19:56, vj a ?crit :
Quoted 18 lines
Hello Romain,
Quoted 10 lines · Romain Naour
Hi Vicente,
Le 21/08/2015 02:30, vj a ?crit :
Quoted 6 lines
Hello Romain,
I've tested you efl update
https://github.com/RomainNaour/buildroot/tree/efl-1.15.0-v1
It did not work, :(
But applying the two patches below works again! The first one was already commented in a previous e-mail.
Quoted 4 lines
Yes, sorry I haven't looked at your issue yet.
libmount seems to be optional and can be disabled with --disable-libmount:
https://github.com/RomainNaour/buildroot/blob/efl-1.15.0-v1/package/efl/efl.mk#L35
Quoted 6 lines
Without that dependency it failed with 1.14.2.
When I saw the dependency was not there in 1.15.0, I just added it again without checking.
Just now I've tried it again without that patch and it's fine, so, you can forget it.
Sorry for the hassle.
It's ok ;-) I haven't heavily tested with a minimal config.
Maybe next time can you post the last ~100 build log lines, it not always easy to reproduce a build issue...
Quoted 6 lines
Quoted 6 lines
But since it's not recommended to disable it, I'll apply your patch :)
Quoted 1 line
The second is related to a regression in efl-1.15.0.

Quoted 8 lines

Quoted 6 lines
Quoted 1 line
Can you report your issue to the efl mailing list ?
I know it would be better to have it fixed upstream, but have no time for that now.
If you would like to, feel free to report it.
To debug it, it helps enabling the WRN and DGB macros in eina_module.c.
Well, I can't really report an issue that I can't reproduce.

Do you mean that the fb backend is working for you? Are you crosscompiling with upstream vanilla gcc>=4 for arm? It might be a compiler bug too.
I'm using musl gcc 4.9.3 build with buildroot itself. gcc 5 seems broken for arm crosscompilation.
Just for completeness, the compiler I'm using was build with:
buildroot.version=2ebbb7fe355c18a0be3d0fb8e50997142113c46b BR2_arm=y
BR2_cortex_a8=y
BR2_ARM_EABIHF=y
BR2_ARM_FPU_NEON=y BR2_HOST_DIR="/opt/arm-buildroot-linux-musleabihf" BR2_OPTIMIZE_3=y
BR2_TOOLCHAIN_BUILDROOT_MUSL=y BR2_BINUTILS_VERSION_2_25_X=y BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_GCC_ENABLE_LTO=y
BR2_GCC_ENABLE_GRAPHITE=y BR2_TARGET_OPTIMIZATION="-march=armv7-a -mtune=cortex-a8 -mcpu=cortex-a8 -mfpu=neon -mfloat-abi=hard"

Quoted 7 lines

See, I reported the issue about SDL2 dependency and it's now fixed in the efl 1.15.1. So, I can drop the last patch and avoid to autoreconf the package.
Also, I'm probably not the good person to report an efl issue. Honestly, I don't know what to do with -fvisibility=default.
It would be better if you can send just an email to the enlightenment mailing list to report your issue.

Is "enlightenment-devel at lists.sourceforge.net" the correct mailing list for an efl bug?

Quoted 11 lines

Quoted 11 lines
Quoted 11 lines
Quoted 7 lines
The testing I've done has been with the musl libc and with BR2_PACKAGE_EFL_RECOMMENDED_CONFIG unset. Basically the same config as in the previous e-mail.
A minor issue: check the spelling of recommanded.
Ha indeed recommanded is used in Config.in prompt
(my French was turned on sorry ;-) )

Quoted 8 lines

Quoted 3 lines
Quoted 1 line
Thanks for testing!
Thanks for adding musl and maintaining efl!
You're welcome!
Best regards,
Romain

Regards,
Vicente.

Romain Naour

2015-09-05 14:55 UTC #6 lore raw

cover efl bump to 1.14.2

Hello Vicente,

Sorry for the delay.

Le 25/08/2015 00:09, vj a ?crit :

Quoted 43 lines

Hello Romain,
Quoted 40 lines · Romain Naour
Hi Vicente
Le 21/08/2015 19:56, vj a ?crit :
Quoted 18 lines
Hello Romain,
Quoted 10 lines · Romain Naour
Hi Vicente,
Le 21/08/2015 02:30, vj a ?crit :
Quoted 6 lines
Hello Romain,
I've tested you efl update
https://github.com/RomainNaour/buildroot/tree/efl-1.15.0-v1
It did not work, :(
But applying the two patches below works again! The first one was already commented in a previous e-mail.
Quoted 4 lines
Yes, sorry I haven't looked at your issue yet.
libmount seems to be optional and can be disabled with --disable-libmount:
https://github.com/RomainNaour/buildroot/blob/efl-1.15.0-v1/package/efl/efl.mk#L35
Quoted 6 lines
Without that dependency it failed with 1.14.2.
When I saw the dependency was not there in 1.15.0, I just added it again without checking.
Just now I've tried it again without that patch and it's fine, so, you can forget it.
Sorry for the hassle.
It's ok ;-) I haven't heavily tested with a minimal config.
Maybe next time can you post the last ~100 build log lines, it not always easy to reproduce a build issue...
Quoted 8 lines
Quoted 7 lines
But since it's not recommended to disable it, I'll apply your patch :)
Quoted 1 line
The second is related to a regression in efl-1.15.0.
Can you report your issue to the efl mailing list ?

Quoted 8 lines

Quoted 6 lines
Quoted 4 lines
I know it would be better to have it fixed upstream, but have no time for that now.
If you would like to, feel free to report it.
To debug it, it helps enabling the WRN and DGB macros in eina_module.c.
Well, I can't really report an issue that I can't reproduce.
Do you mean that the fb backend is working for you?

I mean I don't have this issue because I don't use the fb backend during my test.

Quoted 1 line

Are you crosscompiling with upstream vanilla gcc>=4 for arm?

I'm using a toolchain for ARM build by buildroot with a uClibc-ng.

Quoted 10 lines

It might be a compiler bug too.
I'm using musl gcc 4.9.3 build with buildroot itself. gcc 5 seems broken for arm crosscompilation.
Just for completeness, the compiler I'm using was build with:
buildroot.version=2ebbb7fe355c18a0be3d0fb8e50997142113c46b BR2_arm=y
BR2_cortex_a8=y
BR2_ARM_EABIHF=y
BR2_ARM_FPU_NEON=y BR2_HOST_DIR="/opt/arm-buildroot-linux-musleabihf"

Quoted 8 lines

BR2_OPTIMIZE_3=y
BR2_TOOLCHAIN_BUILDROOT_MUSL=y BR2_BINUTILS_VERSION_2_25_X=y BR2_TOOLCHAIN_BUILDROOT_CXX=y BR2_GCC_ENABLE_LTO=y
BR2_GCC_ENABLE_GRAPHITE=y BR2_TARGET_OPTIMIZATION="-march=armv7-a -mtune=cortex-a8 -mcpu=cortex-a8 -mfpu=neon -mfloat-abi=hard"

Theses flags are handled directly by your target configuration in "Target options" menu. You don't need to define them in BR2_TARGET_OPTIMIZATION.

Quoted 11 lines

Quoted 8 lines
See, I reported the issue about SDL2 dependency and it's now fixed in the efl 1.15.1. So, I can drop the last patch and avoid to autoreconf the package.
Also, I'm probably not the good person to report an efl issue. Honestly, I don't know what to do with -fvisibility=default.
It would be better if you can send just an email to the enlightenment mailing list to report your issue.
Is "enlightenment-devel at lists.sourceforge.net" the correct mailing list for an efl bug?

Yes it is.

Best regards,
Romain

Quoted 24 lines

Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 8 lines
The testing I've done has been with the musl libc and with BR2_PACKAGE_EFL_RECOMMENDED_CONFIG unset. Basically the same config as in the previous e-mail.
A minor issue: check the spelling of recommanded.
Ha indeed recommanded is used in Config.in prompt
(my French was turned on sorry ;-) )
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Thanks for testing!
Thanks for adding musl and maintaining efl!
You're welcome!
Best regards,
Romain
Regards,
Vicente.

vj

author

2015-09-27 00:37 UTC #7 lore raw

cover efl bump to 1.14.2

Hello Romain,
this weekend I had some time to spend on this, sorry for the delay.

I've posted the EFL issue:
http://sourceforge.net/p/enlightenment/mailman/message/34493376

And tested your efl-1.15.1-v1 branch from
git://github.com/RomainNaour/buildroot.git
Aside from the EFL workaround (-fvisibility=default) the only remaining issue is that when audio is disabled it fails to build because of bae9cf8354208bdad7780e0d11e5b4c8cf1b1f3e.
I think it should be safe to just revert it because multisense is already enabled by default and (as an audio-related feature) it only makes sense when audio is also enabled.

Regards,
Vicente.

Tested-by Vicente Bergas <[email protected]>

Quoted 126 lines · Romain Naour

Hello Vicente,
Sorry for the delay.
Le 25/08/2015 00:09, vj a ?crit :
Quoted 43 lines
Hello Romain,
Quoted 40 lines · Romain Naour
Hi Vicente
Le 21/08/2015 19:56, vj a ?crit :
Quoted 18 lines
Hello Romain,
Quoted 10 lines · Romain Naour
Hi Vicente,
Le 21/08/2015 02:30, vj a ?crit :
Quoted 6 lines
Hello Romain,
I've tested you efl update
https://github.com/RomainNaour/buildroot/tree/efl-1.15.0-v1
It did not work, :(
But applying the two patches below works again! The first one was already commented in a previous e-mail.
Quoted 4 lines
Yes, sorry I haven't looked at your issue yet.
libmount seems to be optional and can be disabled with --disable-libmount:
https://github.com/RomainNaour/buildroot/blob/efl-1.15.0-v1/package/efl/efl.mk#L35
Quoted 6 lines
Without that dependency it failed with 1.14.2.
When I saw the dependency was not there in 1.15.0, I just added it again without checking.
Just now I've tried it again without that patch and it's fine, so, you can forget it.
Sorry for the hassle.
It's ok ;-) I haven't heavily tested with a minimal config.
Maybe next time can you post the last ~100 build log lines, it not always easy to reproduce a build issue...
Quoted 8 lines
Quoted 7 lines
But since it's not recommended to disable it, I'll apply your patch :)
Quoted 1 line
The second is related to a regression in efl-1.15.0.
Can you report your issue to the efl mailing list ?
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
I know it would be better to have it fixed upstream, but have no time for that now.
If you would like to, feel free to report it.
To debug it, it helps enabling the WRN and DGB macros in eina_module.c.
Well, I can't really report an issue that I can't reproduce.
Do you mean that the fb backend is working for you?
I mean I don't have this issue because I don't use the fb backend during my test.
Quoted 1 line
Are you crosscompiling with upstream vanilla gcc>=4 for arm?
I'm using a toolchain for ARM build by buildroot with a uClibc-ng.
Quoted 10 lines
It might be a compiler bug too.
I'm using musl gcc 4.9.3 build with buildroot itself. gcc 5 seems broken for arm crosscompilation.
Just for completeness, the compiler I'm using was build with:
buildroot.version=2ebbb7fe355c18a0be3d0fb8e50997142113c46b BR2_arm=y
BR2_cortex_a8=y
BR2_ARM_EABIHF=y
BR2_ARM_FPU_NEON=y BR2_HOST_DIR="/opt/arm-buildroot-linux-musleabihf"
Quoted 8 lines
BR2_OPTIMIZE_3=y
BR2_TOOLCHAIN_BUILDROOT_MUSL=y BR2_BINUTILS_VERSION_2_25_X=y BR2_TOOLCHAIN_BUILDROOT_CXX=y BR2_GCC_ENABLE_LTO=y
BR2_GCC_ENABLE_GRAPHITE=y BR2_TARGET_OPTIMIZATION="-march=armv7-a -mtune=cortex-a8 -mcpu=cortex-a8 -mfpu=neon -mfloat-abi=hard"
Theses flags are handled directly by your target configuration in "Target options" menu. You don't need to define them in BR2_TARGET_OPTIMIZATION.
Quoted 11 lines
Quoted 8 lines
See, I reported the issue about SDL2 dependency and it's now fixed in the efl 1.15.1. So, I can drop the last patch and avoid to autoreconf the package.
Also, I'm probably not the good person to report an efl issue. Honestly, I don't know what to do with -fvisibility=default.
It would be better if you can send just an email to the enlightenment mailing list to report your issue.
Is "enlightenment-devel at lists.sourceforge.net" the correct mailing list for an efl bug?
Yes it is.
Best regards,
Romain
Quoted 24 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 8 lines
The testing I've done has been with the musl libc and with BR2_PACKAGE_EFL_RECOMMENDED_CONFIG unset. Basically the same config as in the previous e-mail.
A minor issue: check the spelling of recommanded.
Ha indeed recommanded is used in Config.in prompt
(my French was turned on sorry ;-) )
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Thanks for testing!
Thanks for adding musl and maintaining efl!
You're welcome!
Best regards,
Romain
Regards,
Vicente.

Romain Naour

2015-09-28 21:00 UTC #8 lore raw

cover efl bump to 1.14.2

Hi Vicente,

Le 27/09/2015 02:37, vj a ?crit :

Quoted 2 lines

Hello Romain,
this weekend I had some time to spend on this, sorry for the delay.

That's ok, I guess you're working on your free time :)

Quoted 3 lines

I've posted the EFL issue:
http://sourceforge.net/p/enlightenment/mailman/message/34493376

Glad to see you had some help on your error on framebuffer support. If you send me a git formated patch that fixes your issue, be sure it'll be part of the next efl series. (I hope, in the meantime, a patch will be applied upstream and backported to 1.15 stable branch before the 1.15.2 release).

Quoted 9 lines

And tested your efl-1.15.1-v1 branch from
git://github.com/RomainNaour/buildroot.git
Aside from the EFL workaround (-fvisibility=default) the only remaining issue is that when audio is disabled it fails to build because of bae9cf8354208bdad7780e0d11e5b4c8cf1b1f3e.
I think it should be safe to just revert it because multisense is already enabled by default and (as an audio-related feature) it only makes sense when audio is also enabled.

Thanks for the testing and the feedback!
The last patches from efl-1.15.1-v1 branch are WIP and won't be included yet in the next Buildroot series. I'll take a closer look to multisense stuff.

Quoted 6 lines

Regards,
Vicente.
Tested-by Vicente Bergas <[email protected]>

I already added your tested-by tag in the commit that bump efl for the target.
https://github.com/RomainNaour/buildroot/commit/04b24bc4e9b9c21209cbdb1110d0ae41991f838d

Also, tags are not taken into account by patchwork when you reply to a cover letter. You can send several tags on a specific patch on the series by replying to the email.

Best regards,
Romain

Vicente Bergas

author

2015-10-05 19:41 UTC #9 lore raw

[Buildroot] efl: fix framebuffer support

Hello Romain,

Quoted 12 lines

Hi Vicente,
Le 27/09/2015 02:37, vj a =C3=A9crit :
Quoted 2 lines
Hello Romain,
this weekend I had some time to spend on this, sorry for the delay.
That's ok, I guess you're working on your free time :)
Quoted 3 lines
=20
I've posted the EFL issue:
http://sourceforge.net/p/enlightenment/mailman/message/34493376

Quoted 5 lines

Glad to see you had some help on your error on framebuffer support. If you send me a git formated patch that fixes your issue, be sure it'll = be part
of the next efl series. (I hope, in the meantime, a patch will be applied upstream and backported to 1.15 stable branch before the 1.15.2 release).

It seems that the issue was not posted soon enough to make it for 1.15.2, so, here is the patch required for it to work.

Quoted 11 lines

Quoted 10 lines
=20
And tested your efl-1.15.1-v1 branch from
git://github.com/RomainNaour/buildroot.git
Aside from the EFL workaround (-fvisibility=3Ddefault) the only remaining issue is that when audio is disabled it fails to build because of bae9cf8354208bdad7780e0d11e5b4c8cf1b1f3e.
I think it should be safe to just revert it because multisense is already enabled by default and (as an audio-related feature) it only makes sense when audio is also enabled.

Quoted 4 lines

Thanks for the testing and the feedback!
The last patches from efl-1.15.1-v1 branch are WIP and won't be included = yet in
the next Buildroot series. I'll take a closer look to multisense stuff.

I've spotted something extra:
package/efl/efl.mk:312: *** EFL_SITE (http://download.enlightenment.org/rel/libs/efl/) cannot have a trailing slash. Stop.
Affected packages are:
econnman efl elemines empc enlightenment libcanberra libelementary libemotion-generic-players libetrophy libevas-generic-loaders python-efl rage terminology x11r7 This fixes it:
sed -i 's@$_SITE = .*$/$@\1@' $(grep -rl '_SITE = .*/$')

Regards,
Vicente.

Quoted 21 lines

Quoted 7 lines
=20
Regards,
Vicente.
=20
Tested-by Vicente Bergas <[email protected]>
=20
I already added your tested-by tag in the commit that bump efl for the ta= rget.
https://github.com/RomainNaour/buildroot/commit/04b24bc4e9b9c21209cbdb111=
0d0ae41991f838d
Also, tags are not taken into account by patchwork when you reply to a co= ver
letter. You can send several tags on a specific patch on the series by re= plying
to the email.
Best regards,
Romain

Vicente Bergas

author

2015-10-05 19:41 UTC #10 lore raw

[Buildroot] efl: fix framebuffer support

Signed-off-by Vicente Bergas <[email protected]>

---
 ...ecore_fb_private.h-define-EAPI-before-use.patch | 42 ++++++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 package/efl/0001-ecore_fb_private.h-define-EAPI-before-use.patch

package/efl/0001-ecore_fb_private.h-define-EAPI-before-use.patch new file +42 -0

new file mode 100644
index 0000000..6303930
@@ -0,0 +1,42 @@
+ecore_fb_private.h: define EAPI before use
+
+---
+ src/lib/ecore_fb/ecore_fb_private.h | 17 +++++++++++++++++
+ 1 file changed, 17 insertions(+)
+
+diff --git a/src/lib/ecore_fb/ecore_fb_private.h b/src/lib/ecore_fb/ecore_fb_private.h
+index f7dc0c6..f54c8d2 100644
+--- a/src/lib/ecore_fb/ecore_fb_private.h
++++ b/src/lib/ecore_fb/ecore_fb_private.h
+@@ -33,6 +33,20 @@
+ 
+ #include <Ecore_Fb.h>
+ 
++#ifdef EAPI
++# undef EAPI
++#endif
++
++#ifdef __GNUC__
++# if __GNUC__ >= 4
++#  define EAPI __attribute__ ((visibility("default")))
++# else
++#  define EAPI
++# endif
++#else
++# define EAPI
++#endif
++
+ /* ecore_fb_li.c */
+ struct _Ecore_Fb_Input_Device
+ {
+@@ -92,4 +106,7 @@ void ecore_fb_vt_shutdown(void);
+ #define TS_GET_CAL 0x8014660a
+ #endif
+   
++#undef EAPI
++#define EAPI
++
+ #endif
+-- 
+2.6.0
+

Signature · 1 line

2.6.0

Romain Naour

2015-10-09 21:32 UTC #11 lore raw

[Buildroot] efl: fix framebuffer support

Hi Vicente,

Le 05/10/2015 21:41, Vicente Bergas a ?crit :

Quoted 12 lines

Signed-off-by Vicente Bergas <[email protected]>
---
 ...ecore_fb_private.h-define-EAPI-before-use.patch | 42 ++++++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 package/efl/0001-ecore_fb_private.h-define-EAPI-before-use.patch
package/efl/0001-ecore_fb_private.h-define-EAPI-before-use.patch new file +0 -0
new file mode 100644
index 0000000..6303930

package/efl/0001-ecore_fb_private.h-define-EAPI-before-use.patch line 2

Quoted 2 lines

package/efl/0001-ecore_fb_private.h-define-EAPI-before-use.patch new file +2 -0
@@ -0,0 +1,42 @@
+ecore_fb_private.h: define EAPI before use
+

Your patch needs probably a commit log and your SoB line, see:

http://buildroot.uclibc.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches

Don't forget to add a link to the enlightenment mailing list where the initial patch has been posted.
(http://sourceforge.net/p/enlightenment/mailman/message/34492801)

Also, it would be great if you can provide a git formatted patch in order to ease the patch maintenance. (not mandatory though).

For now, I'll fixes that locally.

Best regards,
Romain

Quoted 41 lines

package/efl/0001-ecore_fb_private.h-define-EAPI-before-use.patch new file +40 -0

+---
+ src/lib/ecore_fb/ecore_fb_private.h | 17 +++++++++++++++++
+ 1 file changed, 17 insertions(+)
+
+diff --git a/src/lib/ecore_fb/ecore_fb_private.h b/src/lib/ecore_fb/ecore_fb_private.h
+index f7dc0c6..f54c8d2 100644
+--- a/src/lib/ecore_fb/ecore_fb_private.h
++++ b/src/lib/ecore_fb/ecore_fb_private.h
+@@ -33,6 +33,20 @@
+ 
+ #include <Ecore_Fb.h>
+ 
++#ifdef EAPI
++# undef EAPI
++#endif
++
++#ifdef __GNUC__
++# if __GNUC__ >= 4
++#  define EAPI __attribute__ ((visibility("default")))
++# else
++#  define EAPI
++# endif
++#else
++# define EAPI
++#endif
++
+ /* ecore_fb_li.c */
+ struct _Ecore_Fb_Input_Device
+ {
+@@ -92,4 +106,7 @@ void ecore_fb_vt_shutdown(void);
+ #define TS_GET_CAL 0x8014660a
+ #endif
+   
++#undef EAPI
++#define EAPI
++
+ #endif
+-- 
+2.6.0
+

Romain Naour

2015-10-09 21:04 UTC #12 lore raw

[Buildroot] efl: fix framebuffer support

In reply to Vicente Bergas

Hi Vicente,

Le 05/10/2015 21:41, Vicente Bergas a ?crit :

Quoted 14 lines

Hello Romain,
Quoted 12 lines
Hi Vicente,
Le 27/09/2015 02:37, vj a =C3=A9crit :
Quoted 2 lines
Hello Romain,
this weekend I had some time to spend on this, sorry for the delay.
That's ok, I guess you're working on your free time :)
Quoted 3 lines
=20
I've posted the EFL issue:
http://sourceforge.net/p/enlightenment/mailman/message/34493376

Quoted 8 lines

Quoted 5 lines
Glad to see you had some help on your error on framebuffer support. If you send me a git formated patch that fixes your issue, be sure it'll = be part
of the next efl series. (I hope, in the meantime, a patch will be applied upstream and backported to 1.15 stable branch before the 1.15.2 release).
It seems that the issue was not posted soon enough to make it for 1.15.2, so, here is the patch required for it to work.

Ok no problem, I'll add you patch in the next series.

Quoted 17 lines

Quoted 12 lines
Quoted 11 lines
=20
And tested your efl-1.15.1-v1 branch from
git://github.com/RomainNaour/buildroot.git
Aside from the EFL workaround (-fvisibility=3Ddefault) the only remaining issue is that when audio is disabled it fails to build because of bae9cf8354208bdad7780e0d11e5b4c8cf1b1f3e.
I think it should be safe to just revert it because multisense is already enabled by default and (as an audio-related feature) it only makes sense when audio is also enabled.
Quoted 4 lines
Thanks for the testing and the feedback!
The last patches from efl-1.15.1-v1 branch are WIP and won't be included = yet in
the next Buildroot series. I'll take a closer look to multisense stuff.

Quoted 6 lines

I've spotted something extra:
package/efl/efl.mk:312: *** EFL_SITE (http://download.enlightenment.org/rel/libs/efl/) cannot have a trailing slash. Stop.
Affected packages are:
econnman efl elemines empc enlightenment libcanberra libelementary libemotion-generic-players libetrophy libevas-generic-loaders python-efl rage terminology x11r7 This fixes it:
sed -i 's@$_SITE = .*$/$@\1@' $(grep -rl '_SITE = .*/$')

Thanks for noticing it. Will fix.

Best regards,
Romain

Quoted 4 lines

Regards,
Vicente.