ARM: NSP: add minimal Northstar Plus device tree
Subsystems (3)
PATCH 2/5 ARM: NSP: add minimal Northstar Plus device tree
Add a very minimalistic set of Northstar Plus Device Tree files which describes the SoC and the BCM958625 implementation. The perpherials described are:
ARM Cortex A9 CPU
2 8250 UARTs
ARM GIC
PL310 L2 Cache
ARM A9 Global timer
--- arch/arm/boot/dts/Makefile | 2 + arch/arm/boot/dts/bcm-nsp.dtsi | 105 +++++++++++++++++++++++++++++++++++++++ arch/arm/boot/dts/bcm958625k.dts | 57 +++++++++++++++++++++ 3 files changed, 164 insertions(+) create mode 100644 arch/arm/boot/dts/bcm-nsp.dtsi create mode 100644 arch/arm/boot/dts/bcm958625k.dts
arch/arm/boot/dts/Makefile +2 -0
@@ -82,6 +82,8 @@ dtb-$(CONFIG_ARCH_BCM_CYGNUS) += \ dtb-$(CONFIG_ARCH_BCM_MOBILE) += \ bcm28155-ap.dtb \ bcm21664-garnet.dtb +dtb-$(CONFIG_ARCH_BCM_NSP) += \ + bcm958625k.dtb dtb-$(CONFIG_ARCH_BERLIN) += \ berlin2-sony-nsz-gs7.dtb \ berlin2cd-google-chromecast.dtb \
arch/arm/boot/dts/bcm-nsp.dtsi new file +105 -0
105 lines not on this page · raw message
arch/arm/boot/dts/bcm958625k.dts new file +57 -0
57 lines not on this page · raw message
Signature · 1 line
1.9.1
PATCH 2/5 ARM: NSP: add minimal Northstar Plus device tree
Hi,
I'm not sure what the strategy behind your cc:ing on this patch set is. I only got a couple of them in my inbox, and this one wasn't one of them. :)
Quoted 10 lines · Jon Mason
Add a very minimalistic set of Northstar Plus Device Tree files which describes the SoC and the BCM958625 implementation. The perpherials described are:
ARM Cortex A9 CPU
2 8250 UARTs
ARM GIC
PL310 L2 Cache
ARM A9 Global timer
Quoted 4 lines
Signed-off-by Jon Mason <[email protected]>Signed-off-by Kapil Hali <[email protected]>Reviewed-by Ray Jui <[email protected]>Reviewed-by Scott Branden <[email protected]>
Seeing reviewed-by already attached to a v1 of a patchset has limited value for someone on the outside.
Reviewed-by is one of those tags that has a value that's mostly dependent on who it comes from. By not actually seeing the review and the feedback provided (and revisions made), less data is provided to tell if it's a valuable review or not.
Also, if you're posting the code you should probably have your name below Kapil's, since you're the one signing off the origin of the code. See Documentation/SubmittingPatches.txt for details on what S-o-b actually means.
Quoted 24 lines
arch/arm/boot/dts/bcm-nsp.dtsi new file +21
-0@@ -0,0 +1,105 @@ +/* + * BSD LICENSE + * + * Copyright(c) 2015 Broadcom Corporation. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in + * the documentation and/or other materials provided with the + * distribution. + * * Neither the name of Broadcom Corporation nor the names of its + * contributors may be used to endorse or promote products derived + * from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
arch/arm/boot/dts/bcm-nsp.dtsi line 31
Quoted 10 lines
arch/arm/boot/dts/bcm-nsp.dtsi new file +10
-0+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */
I'm not sure we've seen BSD-only submissions before. I'll let DT maintainers (or Ian) speak up in case this would cause problems.
Quoted 118 lines
arch/arm/boot/dts/bcm-nsp.dtsi new file +74
-0+ +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/interrupt-controller/irq.h> + +#include "skeleton.dtsi" + +/ { + compatible = "brcm,nsp"; + model = "Broadcom Northstar Plus SoC"; + interrupt-parent = <&gic>; + + cpus { + #address-cells = <1>; + #size-cells = <0>; + + cpu at 0 { + device_type = "cpu"; + compatible = "arm,cortex-a9"; + next-level-cache = <&L2>; + reg = <0x0>; + }; + }; + + clocks { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + periph_clk: periph_clk { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <500000000>; + }; + }; + + uart0: serial at 18000300 { + compatible = "ns16550a"; + reg = <0x18000300 0x100>; + interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>; + clock-frequency = <62499840>; + status = "disabled"; + }; + + uart1: serial at 18000400 { + compatible = "ns16550a"; + reg = <0x18000400 0x100>; + interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>; + clock-frequency = <62499840>; + status = "disabled"; + }; + + gic: interrupt-controller at 19021000 { + compatible = "arm,cortex-a9-gic"; + #interrupt-cells = <3>; + #address-cells = <0>; + interrupt-controller; + reg = <0x19021000 0x1000>, + <0x19020100 0x100>; + }; + + L2: l2-cache { + compatible = "arm,pl310-cache"; + reg = <0x19022000 0x1000>; + cache-unified; + cache-level = <2>; + }; + + timer at 19020200 { + compatible = "arm,cortex-a9-global-timer"; + reg = <0x19020200 0x100>; + interrupts = <GIC_PPI 11 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&periph_clk>; + }; +};arch/arm/boot/dts/bcm958625k.dts new file +38
-0@@ -0,0 +1,57 @@ +/* + * BSD LICENSE + * + * Copyright(c) 2015 Broadcom Corporation. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in + * the documentation and/or other materials provided with the + * distribution. + * * Neither the name of Broadcom Corporation nor the names of its + * contributors may be used to endorse or promote products derived + * from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +/dts-v1/; + +#include "bcm-nsp.dtsi" + +/ { + model = "NorthStar Plus SVK (BCM958625K)";
arch/arm/boot/dts/bcm958625k.dts line 48
Quoted 10 lines
arch/arm/boot/dts/bcm958625k.dts new file +10
-0+ compatible = "brcm,bcm58625", "brcm,nsp"; + + aliases { + serial0 = &uart0; + serial1 = &uart1; + }; + + chosen { + stdout-path = "serial0:115200n8"; + };
No way to mount a root filesystem yet? How much work remains for that to be possible, and what's the plan for that?
arch/arm/boot/dts/bcm958625k.dts line 56
Quoted 8 lines
arch/arm/boot/dts/bcm958625k.dts new file +8
-0+ + uart0: serial at 18000300 { + status = "okay"; + }; + + uart1: serial at 18000400 { + status = "okay"; + };
I recommend using labels here instead so you don't have to mirror the DT layout to get the updated property right.
I.e.
&uart1 {
status = "okay";
};-Olof
PATCH 2/5 ARM: NSP: add minimal Northstar Plus device tree
Quoted 5 lines · Olof Johansson
Hi,
I'm not sure what the strategy behind your cc:ing on this patch set is. I only got a couple of them in my inbox, and this one wasn't one of them. :)
I sent them to the people listed as maintainers in get_maintainer.pl. It didn't seem to include you in all of them, but I thought the mailing list would be enough of a catch all. My apologies. I'll CC everyone listed as a maintainer on all of the patches in the future.
Quoted 25 lines · Jon Mason
Quoted 10 lines
Add a very minimalistic set of Northstar Plus Device Tree files which describes the SoC and the BCM958625 implementation. The perpherials described are:
ARM Cortex A9 CPU
2 8250 UARTs
ARM GIC
PL310 L2 Cache
ARM A9 Global timerQuoted 4 lines
Signed-off-by Jon Mason <[email protected]>Signed-off-by Kapil Hali <[email protected]>Reviewed-by Ray Jui <[email protected]>Reviewed-by Scott Branden <[email protected]>Seeing reviewed-by already attached to a v1 of a patchset has limited value for someone on the outside.
Reviewed-by is one of those tags that has a value that's mostly dependent on who it comes from. By not actually seeing the review and the feedback provided (and revisions made), less data is provided to tell if it's a valuable review or not.
Quoted 4 lines
Also, if you're posting the code you should probably have your name below Kapil's, since you're the one signing off the origin of the code. See
Documentation/SubmittingPatches.txtfor details on what S-o-b actually means.
We worked on it together, but I'll be happy to reorder as you suggest.
Quoted 31 lines
Quoted 31 lines
arch/arm/boot/dts/bcm-nsp.dtsi new file +26
-0@@ -0,0 +1,105 @@ +/* + * BSD LICENSE + * + * Copyright(c) 2015 Broadcom Corporation. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in + * the documentation and/or other materials provided with the + * distribution. + * * Neither the name of Broadcom Corporation nor the names of its + * contributors may be used to endorse or promote products derived + * from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
Quoted 8 lines
arch/arm/boot/dts/bcm-nsp.dtsi line 31
Quoted 5 lines
arch/arm/boot/dts/bcm-nsp.dtsi new file +5
-0+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */I'm not sure we've seen BSD-only submissions before. I'll let DT maintainers (or Ian) speak up in case this would cause problems.
I was following the precedent in arch/arm/boot/dts/bcm-cygnus.dtsi. If this is preferred to be GPL v2, then I will happily comply.
Quoted 125 lines
Quoted 125 lines
arch/arm/boot/dts/bcm-nsp.dtsi new file +74
-0+ +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/interrupt-controller/irq.h> + +#include "skeleton.dtsi" + +/ { + compatible = "brcm,nsp"; + model = "Broadcom Northstar Plus SoC"; + interrupt-parent = <&gic>; + + cpus { + #address-cells = <1>; + #size-cells = <0>; + + cpu at 0 { + device_type = "cpu"; + compatible = "arm,cortex-a9"; + next-level-cache = <&L2>; + reg = <0x0>; + }; + }; + + clocks { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + periph_clk: periph_clk { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <500000000>; + }; + }; + + uart0: serial at 18000300 { + compatible = "ns16550a"; + reg = <0x18000300 0x100>; + interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>; + clock-frequency = <62499840>; + status = "disabled"; + }; + + uart1: serial at 18000400 { + compatible = "ns16550a"; + reg = <0x18000400 0x100>; + interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>; + clock-frequency = <62499840>; + status = "disabled"; + }; + + gic: interrupt-controller at 19021000 { + compatible = "arm,cortex-a9-gic"; + #interrupt-cells = <3>; + #address-cells = <0>; + interrupt-controller; + reg = <0x19021000 0x1000>, + <0x19020100 0x100>; + }; + + L2: l2-cache { + compatible = "arm,pl310-cache"; + reg = <0x19022000 0x1000>; + cache-unified; + cache-level = <2>; + }; + + timer at 19020200 { + compatible = "arm,cortex-a9-global-timer"; + reg = <0x19020200 0x100>; + interrupts = <GIC_PPI 11 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&periph_clk>; + }; +};arch/arm/boot/dts/bcm958625k.dts new file +43
-0@@ -0,0 +1,57 @@ +/* + * BSD LICENSE + * + * Copyright(c) 2015 Broadcom Corporation. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in + * the documentation and/or other materials provided with the + * distribution. + * * Neither the name of Broadcom Corporation nor the names of its + * contributors may be used to endorse or promote products derived + * from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +/dts-v1/; + +#include "bcm-nsp.dtsi" + +/ { + model = "NorthStar Plus SVK (BCM958625K)"; + compatible = "brcm,bcm58625", "brcm,nsp"; + + aliases { + serial0 = &uart0; + serial1 = &uart1;
Quoted 8 lines
arch/arm/boot/dts/bcm958625k.dts line 48
Quoted 5 lines
arch/arm/boot/dts/bcm958625k.dts new file +5
-0+ }; + + chosen { + stdout-path = "serial0:115200n8"; + };No way to mount a root filesystem yet? How much work remains for that to be possible, and what's the plan for that?
It mounts rootfs. I am adding the rootfs to the kernel and device tree blob via the u-boot mkimage command. It boots all the way to shell without issue.
Quoted 12 lines
arch/arm/boot/dts/bcm958625k.dts line 56
Quoted 9 lines
arch/arm/boot/dts/bcm958625k.dts new file +8
-0+ + uart0: serial at 18000300 { + status = "okay"; + }; + + uart1: serial at 18000400 { + status = "okay"; + };I recommend using labels here instead so you don't have to mirror the DT layout to get the updated property right.
Agreed.
Thanks,
Jon
Quoted 10 lines
I.e.
&uart1 { status = "okay"; };-Olof
PATCH 2/5 ARM: NSP: add minimal Northstar Plus device tree
Quoted 11 lines · Jon Mason
Quoted 5 lines · Olof Johansson
Hi,
I'm not sure what the strategy behind your cc:ing on this patch set is. I only got a couple of them in my inbox, and this one wasn't one of them. :)
I sent them to the people listed as maintainers in get_maintainer.pl. It didn't seem to include you in all of them, but I thought the mailing list would be enough of a catch all. My apologies. I'll CC everyone listed as a maintainer on all of the patches in the future.
No worries. Just pointing it out since you asked me to look at the patches and, well, I hadn't received them all. :)
Quoted 71 lines
Quoted 24 lines · Jon Mason
Quoted 10 lines
Add a very minimalistic set of Northstar Plus Device Tree files which describes the SoC and the BCM958625 implementation. The perpherials described are:
ARM Cortex A9 CPU
2 8250 UARTs
ARM GIC
PL310 L2 Cache
ARM A9 Global timerQuoted 4 lines
Signed-off-by Jon Mason <[email protected]>Signed-off-by Kapil Hali <[email protected]>Reviewed-by Ray Jui <[email protected]>Reviewed-by Scott Branden <[email protected]>Seeing reviewed-by already attached to a v1 of a patchset has limited value for someone on the outside.
Reviewed-by is one of those tags that has a value that's mostly dependent on who it comes from. By not actually seeing the review and the feedback provided (and revisions made), less data is provided to tell if it's a valuable review or not.
Quoted 4 lines
Also, if you're posting the code you should probably have your name below Kapil's, since you're the one signing off the origin of the code. See
Documentation/SubmittingPatches.txtfor details on what S-o-b actually means.We worked on it together, but I'll be happy to reorder as you suggest.
Quoted 31 lines
Quoted 31 lines
arch/arm/boot/dts/bcm-nsp.dtsi new file +26
-0@@ -0,0 +1,105 @@ +/* + * BSD LICENSE + * + * Copyright(c) 2015 Broadcom Corporation. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in + * the documentation and/or other materials provided with the + * distribution. + * * Neither the name of Broadcom Corporation nor the names of its + * contributors may be used to endorse or promote products derived + * from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,Quoted 8 lines
arch/arm/boot/dts/bcm-nsp.dtsi line 31
Quoted 5 lines
arch/arm/boot/dts/bcm-nsp.dtsi new file +5
-0+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */I'm not sure we've seen BSD-only submissions before. I'll let DT maintainers (or Ian) speak up in case this would cause problems.
Quoted 2 lines
I was following the precedent in
arch/arm/boot/dts/bcm-cygnus.dtsi. If this is preferred to be GPL v2, then I will happily comply.
No, we'd rather have BSD-only than GPL-only, so keeping it as it is should be OK.
Quoted 10 lines
Quoted 6 lines
arch/arm/boot/dts/bcm-nsp.dtsi line 34
Quoted 3 lines
arch/arm/boot/dts/bcm-nsp.dtsi new file +3
-0+ chosen { + stdout-path = "serial0:115200n8"; + };No way to mount a root filesystem yet? How much work remains for that to be possible, and what's the plan for that?
It mounts rootfs. I am adding the rootfs to the kernel and device tree blob via the u-boot mkimage command. It boots all the way to shell without issue.
Sure, any system with memory can use ramdisk for root, that's not what I meant.
Still, based on post from Scott it sounds like NAND support isn't far away.
-Olof
Scott Branden
maintainerPATCH 2/5 ARM: NSP: add minimal Northstar Plus device tree
In reply to Olof JohanssonHi Olof,
Comments inline.
Quoted 22 lines · Olof Johansson
Hi,
I'm not sure what the strategy behind your cc:ing on this patch set is. I only got a couple of them in my inbox, and this one wasn't one of them. :)
Quoted 10 lines · Jon Mason
Add a very minimalistic set of Northstar Plus Device Tree files which describes the SoC and the BCM958625 implementation. The perpherials described are:
ARM Cortex A9 CPU
2 8250 UARTs
ARM GIC
PL310 L2 Cache
ARM A9 Global timerQuoted 4 lines
Signed-off-by Jon Mason <[email protected]>Signed-off-by Kapil Hali <[email protected]>Reviewed-by Ray Jui <[email protected]>Reviewed-by Scott Branden <[email protected]>
Quoted 8 lines
Seeing reviewed-by already attached to a v1 of a patchset has limited value for someone on the outside.
Reviewed-by is one of those tags that has a value that's mostly dependent on who it comes from. By not actually seeing the review and the feedback provided (and revisions made), less data is provided to tell if it's a valuable review or not.
should we start using Ack'd instead then for things that were reviewed internally?
Quoted 36 lines
Also, if you're posting the code you should probably have your name below Kapil's, since you're the one signing off the origin of the code. See
Documentation/SubmittingPatches.txtfor details on what S-o-b actually means.Quoted 29 lines
arch/arm/boot/dts/bcm-nsp.dtsi new file +26
-0@@ -0,0 +1,105 @@ +/* + * BSD LICENSE + * + * Copyright(c) 2015 Broadcom Corporation. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in + * the documentation and/or other materials provided with the + * distribution. + * * Neither the name of Broadcom Corporation nor the names of its + * contributors may be used to endorse or promote products derived + * from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
Quoted 9 lines
arch/arm/boot/dts/bcm-nsp.dtsi line 31
Quoted 5 lines
arch/arm/boot/dts/bcm-nsp.dtsi new file +5
-0+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */I'm not sure we've seen BSD-only submissions before. I'll let DT maintainers (or Ian) speak up in case this would cause problems.
Arnd is the one who require new DT content to be BSD licensed. We're just following his orders:
http://lkml.iu.edu/hypermail/linux/kernel/1411.1/01109.html
Quoted 124 lines
Quoted 124 lines
arch/arm/boot/dts/bcm-nsp.dtsi new file +74
-0+ +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/interrupt-controller/irq.h> + +#include "skeleton.dtsi" + +/ { + compatible = "brcm,nsp"; + model = "Broadcom Northstar Plus SoC"; + interrupt-parent = <&gic>; + + cpus { + #address-cells = <1>; + #size-cells = <0>; + + cpu at 0 { + device_type = "cpu"; + compatible = "arm,cortex-a9"; + next-level-cache = <&L2>; + reg = <0x0>; + }; + }; + + clocks { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + periph_clk: periph_clk { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <500000000>; + }; + }; + + uart0: serial at 18000300 { + compatible = "ns16550a"; + reg = <0x18000300 0x100>; + interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>; + clock-frequency = <62499840>; + status = "disabled"; + }; + + uart1: serial at 18000400 { + compatible = "ns16550a"; + reg = <0x18000400 0x100>; + interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>; + clock-frequency = <62499840>; + status = "disabled"; + }; + + gic: interrupt-controller at 19021000 { + compatible = "arm,cortex-a9-gic"; + #interrupt-cells = <3>; + #address-cells = <0>; + interrupt-controller; + reg = <0x19021000 0x1000>, + <0x19020100 0x100>; + }; + + L2: l2-cache { + compatible = "arm,pl310-cache"; + reg = <0x19022000 0x1000>; + cache-unified; + cache-level = <2>; + }; + + timer at 19020200 { + compatible = "arm,cortex-a9-global-timer"; + reg = <0x19020200 0x100>; + interrupts = <GIC_PPI 11 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&periph_clk>; + }; +};arch/arm/boot/dts/bcm958625k.dts new file +43
-0@@ -0,0 +1,57 @@ +/* + * BSD LICENSE + * + * Copyright(c) 2015 Broadcom Corporation. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in + * the documentation and/or other materials provided with the + * distribution. + * * Neither the name of Broadcom Corporation nor the names of its + * contributors may be used to endorse or promote products derived + * from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +/dts-v1/; + +#include "bcm-nsp.dtsi" + +/ { + model = "NorthStar Plus SVK (BCM958625K)"; + compatible = "brcm,bcm58625", "brcm,nsp"; + + aliases { + serial0 = &uart0; + serial1 = &uart1;
Quoted 9 lines
arch/arm/boot/dts/bcm958625k.dts line 48
Quoted 5 lines
arch/arm/boot/dts/bcm958625k.dts new file +5
-0+ }; + + chosen { + stdout-path = "serial0:115200n8"; + };No way to mount a root filesystem yet? How much work remains for that to be possible, and what's the plan for that?
This is the bare bones DTS. I'm sure Jon will activate NAND once tested
- it "should" work with the same driver that Cygnus and STB chips use.
Quoted 14 lines
arch/arm/boot/dts/bcm958625k.dts line 56
Quoted 8 lines
arch/arm/boot/dts/bcm958625k.dts new file +8
-0+ + uart0: serial at 18000300 { + status = "okay"; + }; + + uart1: serial at 18000400 { + status = "okay"; + };I recommend using labels here instead so you don't have to mirror the DT layout to get the updated property right.
I.e.
Quoted 8 lines
&uart1 { status = "okay"; };-Olof
Regards,
Scott
PATCH 2/5 ARM: NSP: add minimal Northstar Plus device tree
Hi,
Quoted 35 lines · Scott Branden
Hi Olof,
Comments inline.
Quoted 30 lines · Olof Johansson
Hi,
I'm not sure what the strategy behind your cc:ing on this patch set is. I only got a couple of them in my inbox, and this one wasn't one of them. :)
Quoted 11 lines · Jon Mason
Add a very minimalistic set of Northstar Plus Device Tree files which describes the SoC and the BCM958625 implementation. The perpherials described are:
ARM Cortex A9 CPU
2 8250 UARTs
ARM GIC
PL310 L2 Cache
ARM A9 Global timerQuoted 4 lines
Signed-off-by Jon Mason <[email protected]>Signed-off-by Kapil Hali <[email protected]>Reviewed-by Ray Jui <[email protected]>Reviewed-by Scott Branden <[email protected]>Seeing reviewed-by already attached to a v1 of a patchset has limited value for someone on the outside.
Quoted 7 lines
Quoted 4 lines
Reviewed-by is one of those tags that has a value that's mostly dependent on who it comes from. By not actually seeing the review and the feedback provided (and revisions made), less data is provided to tell if it's a valuable review or not.
should we start using Ack'd instead then for things that were reviewed internally?
Best of all is to do more work in public, including sending the acks on the list.
If you look around, it's relatively unusual that people post pre-acked or pre-reviewed patches, even corporate contributors.
Quoted 52 lines
Quoted 42 lines
Also, if you're posting the code you should probably have your name below Kapil's, since you're the one signing off the origin of the code. See
Documentation/SubmittingPatches.txtfor details on what S-o-b actually means.Quoted 36 lines
arch/arm/boot/dts/bcm-nsp.dtsi new file +12
-0@@ -0,0 +1,105 @@ +/* + * BSD LICENSE + * + * Copyright(c) 2015 Broadcom Corporation. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the abovecopyright
+ * notice, this list of conditions and the following disclaimer in + * the documentation and/or other materials provided with the + * distribution.+ * * Neither the name of Broadcom Corporation nor the names of its
+ * contributors may be used to endorse or promote products derived
+ * from this software without specific prior written permission.
+ *+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESSFOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORTQuoted 9 lines
Quoted 4 lines
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */I'm not sure we've seen BSD-only submissions before. I'll let DT maintainers (or Ian) speak up in case this would cause problems.
Quoted 4 lines
Arnd is the one who require new DT content to be BSD licensed. We're just following his orders:
Yeah, we've been asking for (at least) dual GPL/BSD. This was the first time I noticed BSD-only which is why I brought it up.
I suspect it is not an issue in reality.
Quoted 140 lines
Quoted 131 lines
Quoted 131 lines
arch/arm/boot/dts/bcm-nsp.dtsi new file +74
-0+ +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/interrupt-controller/irq.h> + +#include "skeleton.dtsi" + +/ { + compatible = "brcm,nsp"; + model = "Broadcom Northstar Plus SoC"; + interrupt-parent = <&gic>; + + cpus { + #address-cells = <1>; + #size-cells = <0>; + + cpu at 0 { + device_type = "cpu"; + compatible = "arm,cortex-a9"; + next-level-cache = <&L2>; + reg = <0x0>; + }; + }; + + clocks { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + periph_clk: periph_clk { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <500000000>; + }; + }; + + uart0: serial at 18000300 { + compatible = "ns16550a"; + reg = <0x18000300 0x100>; + interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>; + clock-frequency = <62499840>; + status = "disabled"; + }; + + uart1: serial at 18000400 { + compatible = "ns16550a"; + reg = <0x18000400 0x100>; + interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>; + clock-frequency = <62499840>; + status = "disabled"; + }; + + gic: interrupt-controller at 19021000 { + compatible = "arm,cortex-a9-gic"; + #interrupt-cells = <3>; + #address-cells = <0>; + interrupt-controller; + reg = <0x19021000 0x1000>, + <0x19020100 0x100>; + }; + + L2: l2-cache { + compatible = "arm,pl310-cache"; + reg = <0x19022000 0x1000>; + cache-unified; + cache-level = <2>; + }; + + timer at 19020200 { + compatible = "arm,cortex-a9-global-timer"; + reg = <0x19020200 0x100>; + interrupts = <GIC_PPI 11 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&periph_clk>; + }; +};arch/arm/boot/dts/bcm958625k.dts new file +12
-0@@ -0,0 +1,57 @@ +/* + * BSD LICENSE + * + * Copyright(c) 2015 Broadcom Corporation. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the abovecopyright
+ * notice, this list of conditions and the following disclaimer in + * the documentation and/or other materials provided with the + * distribution.+ * * Neither the name of Broadcom Corporation nor the names of its
+ * contributors may be used to endorse or promote products derived
+ * from this software without specific prior written permission.
+ *+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESSFOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */arch/arm/boot/dts/bcm958625k.dts new file +13
-0+ +/dts-v1/; + +#include "bcm-nsp.dtsi" + +/ { + model = "NorthStar Plus SVK (BCM958625K)"; + compatible = "brcm,bcm58625", "brcm,nsp"; + + aliases { + serial0 = &uart0; + serial1 = &uart1; + };Quoted 9 lines
arch/arm/boot/dts/bcm958625k.dts line 48
Quoted 4 lines
arch/arm/boot/dts/bcm958625k.dts new file +4
-0+ + chosen { + stdout-path = "serial0:115200n8"; + };No way to mount a root filesystem yet? How much work remains for that to be possible, and what's the plan for that?
Quoted 2 lines
This is the bare bones DTS. I'm sure Jon will activate NAND once tested - it "should" work with the same driver that Cygnus and STB chips use.
Ok, good. I've found there to be a slight drawback in upstreaming a system dtb before there's basic device support since it can't be used to determine whether a board is expected to have basic functionality or not.
As long as it's in progress there's no big reason to hold off though.
-Olof