Skip to contentSkip to conversation

doc: drm: Fix mis-spelling of i915_guc_submission includes

PATCH Applied Graham Whaley 3 participants 3 messages Aug 24, 2015 – Aug 27, 2015 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 doc: drm: Fix mis-spelling of i915_guc_submission includes

In commit
d1675198e: drm/i915: Integrate GuC-based command submission

the drm.tmpl include lines reference the intel_guc_submission.c but the patch adds the file i915_guc_submission.c. drm.tmpl fails to build with:
docproc: .//drivers/gpu/drm/i915/intel_guc_submission.c:
No such file or directory

Change the file reference to the actual file.

---
This looks/feels like the right fix to me, but I am not intimate enough with the APIs to verify for sure - some confirmation would be good.

 Documentation/DocBook/drm.tmpl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/DocBook/drm.tmpl +2 -2
index a01fca9..66bc646 100644
@@ -4160,8 +4160,8 @@ int num_ioctls;</synopsis>
       </sect2>
       <sect2>
         <title>GuC Client</title>
-!Pdrivers/gpu/drm/i915/intel_guc_submission.c GuC-based command submissison
-!Idrivers/gpu/drm/i915/intel_guc_submission.c
+!Pdrivers/gpu/drm/i915/i915_guc_submission.c GuC-based command submissison
+!Idrivers/gpu/drm/i915/i915_guc_submission.c
       </sect2>
     </sect1>
 
Signature · 6 lines
2.4.3

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 11 lines · Graham Whaley

In commit
d1675198e: drm/i915: Integrate GuC-based command submission

the drm.tmpl include lines reference the intel_guc_submission.c but the patch adds the file i915_guc_submission.c. drm.tmpl fails to build with:
docproc: .//drivers/gpu/drm/i915/intel_guc_submission.c:
No such file or directory

Change the file reference to the actual file.

Applied to drm-intel-next-queued, thanks.
-Daniel

Quoted 29 lines

---
This looks/feels like the right fix to me, but I am not intimate enough with the APIs to verify for sure - some confirmation would be good.

 Documentation/DocBook/drm.tmpl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/DocBook/drm.tmpl +2 -2
index a01fca9..66bc646 100644
@@ -4160,8 +4160,8 @@ int num_ioctls;</synopsis>
       </sect2>
       <sect2>
         <title>GuC Client</title>
-!Pdrivers/gpu/drm/i915/intel_guc_submission.c GuC-based command submissison
-!Idrivers/gpu/drm/i915/intel_guc_submission.c
+!Pdrivers/gpu/drm/i915/i915_guc_submission.c GuC-based command submissison
+!Idrivers/gpu/drm/i915/i915_guc_submission.c
       </sect2>
     </sect1>
 
Signature · 6 lines
2.4.3

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#2 lore raw
In reply to Graham Whaley
Quoted 23 lines · Graham Whaley

In commit
d1675198e: drm/i915: Integrate GuC-based command submission

the drm.tmpl include lines reference the intel_guc_submission.c but the patch adds the file i915_guc_submission.c. drm.tmpl fails to build with:
docproc: .//drivers/gpu/drm/i915/intel_guc_submission.c:
No such file or directory

Change the file reference to the actual file.

---
This looks/feels like the right fix to me, but I am not intimate enough with the APIs to verify for sure - some confirmation would be good.

  Documentation/DocBook/drm.tmpl | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/DocBook/drm.tmpl +0 -0
index a01fca9..66bc646 100644

Documentation/DocBook/drm.tmpl int num_ioctls;</synopsis> · line 4166

Quoted 9 lines
Documentation/DocBook/drm.tmpl +2 -2
@@ -4160,8 +4160,8 @@ int num_ioctls;</synopsis>
        </sect2>
        <sect2>
          <title>GuC Client</title>
-!Pdrivers/gpu/drm/i915/intel_guc_submission.c GuC-based command submissison
-!Idrivers/gpu/drm/i915/intel_guc_submission.c
+!Pdrivers/gpu/drm/i915/i915_guc_submission.c GuC-based command submissison
+!Idrivers/gpu/drm/i915/i915_guc_submission.c
        </sect2>
      </sect1>

Yes, that file got renamed late in development, and obviously the drm.tmpl entry wasn't updated to match.

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx