Skip to contentSkip to conversation

ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4

PATCH Superseded Anand Moon 3 participants 5 messages Sep 3, 2015

Subsystems (2)

v6 of 7 Superseded Latest is v7 →

lore
Share & tools
lore

Anand Moon

author
#0 lore raw

PATCH v6 1/1 ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4

Enable config option NEW_LEDS, LEDS_CLASS, LEDS_GPIO, LEDS_PWM, LEDS_TRIGGERS, LEDS_TRIGGER_TIMER, LEDS_TRIGGER_HEARTBEAT for Odroid-XU3/XU4 board.

---
Changes from last version
dropped following option.
CONFIG_LEDS_CLASS_FLASH
CONFIG_TRIGGER_ONESHOT
CONFIG_TRIGGER_GPIO
fixed the From address

---
 arch/arm/configs/exynos_defconfig | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/configs/exynos_defconfig +7 -0
index 9504e77..aaf7aa4 100644
@@ -163,6 +163,13 @@ CONFIG_MMC_SDHCI_S3C_DMA=y
 CONFIG_MMC_DW=y
 CONFIG_MMC_DW_IDMAC=y
 CONFIG_MMC_DW_EXYNOS=y
+CONFIG_NEW_LEDS=y
+CONFIG_LEDS_CLASS=y
+CONFIG_LEDS_GPIO=y
+CONFIG_LEDS_PWM=y
+CONFIG_LEDS_TRIGGERS=y
+CONFIG_LEDS_TRIGGER_TIMER=y
+CONFIG_LEDS_TRIGGER_HEARTBEAT=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_MAX77686=y
 CONFIG_RTC_DRV_MAX77802=y
Signature · 1 line
2.1.4
Reviewed-by on v6 1/1
#1 lore raw
Quoted 13 lines · Anand Moon

Enable config option NEW_LEDS, LEDS_CLASS, LEDS_GPIO, LEDS_PWM, LEDS_TRIGGERS, LEDS_TRIGGER_TIMER, LEDS_TRIGGER_HEARTBEAT for Odroid-XU3/XU4 board.

---
Changes from last version
dropped following option.
CONFIG_LEDS_CLASS_FLASH
CONFIG_TRIGGER_ONESHOT
CONFIG_TRIGGER_GPIO
fixed the From address

Quoted 3 lines
---
 arch/arm/configs/exynos_defconfig | 7 +++++++
 1 file changed, 7 insertions(+)

BTW, Javier's email is different. All you previous mails bounced. I cc-ed here the proper one.

Best regards,
Krzysztof

Quoted 20 lines
arch/arm/configs/exynos_defconfig +7 -0
index 9504e77..aaf7aa4 100644
@@ -163,6 +163,13 @@ CONFIG_MMC_SDHCI_S3C_DMA=y
 CONFIG_MMC_DW=y
 CONFIG_MMC_DW_IDMAC=y
 CONFIG_MMC_DW_EXYNOS=y
+CONFIG_NEW_LEDS=y
+CONFIG_LEDS_CLASS=y
+CONFIG_LEDS_GPIO=y
+CONFIG_LEDS_PWM=y
+CONFIG_LEDS_TRIGGERS=y
+CONFIG_LEDS_TRIGGER_TIMER=y
+CONFIG_LEDS_TRIGGER_HEARTBEAT=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_MAX77686=y
 CONFIG_RTC_DRV_MAX77802=y
Reviewed-by on v6 1/1
#2 lore raw
In reply to Anand Moon

Hello Anand,

Quoted 7 lines · Anand Moon

Enable config option NEW_LEDS, LEDS_CLASS, LEDS_GPIO, LEDS_PWM, LEDS_TRIGGERS, LEDS_TRIGGER_TIMER, LEDS_TRIGGER_HEARTBEAT for Odroid-XU3/XU4 board.

---

I think Krzysztof already mentioned but a commit message shouln't describe what the change is (one can look to the patch for that) but why the change is needed.

So I would had expect something along these lines:

Many Exynos boards (i.e: the Exynos5422 Odroid XU3/XU4) have GPIO and PWM based LEDs, so enable the needed Kconfig options to have support for these. Also, some boards use the heartbeat LED trigger so enable support for this as well.

Quoted 15 lines

Changes from last version
dropped following option.
CONFIG_LEDS_CLASS_FLASH
CONFIG_TRIGGER_ONESHOT
CONFIG_TRIGGER_GPIO
fixed the From address

---
 arch/arm/configs/exynos_defconfig | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/configs/exynos_defconfig +0 -0
index 9504e77..aaf7aa4 100644

arch/arm/configs/exynos_defconfig CONFIG_MMC_SDHCI_S3C_DMA=y · line 171

Quoted 9 lines
arch/arm/configs/exynos_defconfig +6 -0
@@ -163,6 +163,13 @@ CONFIG_MMC_SDHCI_S3C_DMA=y
 CONFIG_MMC_DW=y
 CONFIG_MMC_DW_IDMAC=y
 CONFIG_MMC_DW_EXYNOS=y
+CONFIG_NEW_LEDS=y
+CONFIG_LEDS_CLASS=y
+CONFIG_LEDS_GPIO=y
+CONFIG_LEDS_PWM=y
+CONFIG_LEDS_TRIGGERS=y
+CONFIG_LEDS_TRIGGER_TIMER=y

I don't see an Exynos board using the timer trigger. Do you need it for some user-space application that uses the sysfs interface? I'm OK with enabling it but again this should be mentioned in the commit message.

arch/arm/configs/exynos_defconfig CONFIG_MMC_SDHCI_S3C_DMA=y · line 175

Quoted 5 lines
arch/arm/configs/exynos_defconfig +1 -0
+CONFIG_LEDS_TRIGGER_HEARTBEAT=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_MAX77686=y
 CONFIG_RTC_DRV_MAX77802=y

The change looks good to me though so with a better commit message:

Best regards,

Signature · 3 lines
Javier Martinez Canillas
Open Source Group
Samsung Research America
author
#3 lore raw

Hi Javier,

Quoted 43 lines · Javier Martinez Canillas

Hello Anand,

Quoted 7 lines · Anand Moon

Enable config option NEW_LEDS, LEDS_CLASS, LEDS_GPIO, LEDS_PWM, LEDS_TRIGGERS, LEDS_TRIGGER_TIMER, LEDS_TRIGGER_HEARTBEAT for Odroid-XU3/XU4 board.

---

I think Krzysztof already mentioned but a commit message shouln't describe what the change is (one can look to the patch for that) but why the change is needed.

So I would had expect something along these lines:

Many Exynos boards (i.e: the Exynos5422 Odroid XU3/XU4) have GPIO and PWM based LEDs, so enable the needed Kconfig options to have support for these. Also, some boards use the heartbeat LED trigger so enable support for this as well.

Quoted 21 lines

Changes from last version
dropped following option.
CONFIG_LEDS_CLASS_FLASH
CONFIG_TRIGGER_ONESHOT
CONFIG_TRIGGER_GPIO
fixed the From address

---
 arch/arm/configs/exynos_defconfig | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/configs/exynos_defconfig +3 -0
index 9504e77..aaf7aa4 100644
@@ -163,6 +163,13 @@ CONFIG_MMC_SDHCI_S3C_DMA=y
 CONFIG_MMC_DW=y
 CONFIG_MMC_DW_IDMAC=y
 CONFIG_MMC_DW_EXYNOS=y
+CONFIG_NEW_LEDS=y
+CONFIG_LEDS_CLASS=y
+CONFIG_LEDS_GPIO=y
Quoted 15 lines

arch/arm/configs/exynos_defconfig CONFIG_MMC_SDHCI_S3C_DMA=y · line 171

Quoted 3 lines
arch/arm/configs/exynos_defconfig +3 -0
+CONFIG_LEDS_PWM=y
+CONFIG_LEDS_TRIGGERS=y
+CONFIG_LEDS_TRIGGER_TIMER=y

I don't see an Exynos board using the timer trigger. Do you need it for some user-space application that uses the sysfs interface? I'm OK with enabling it but again this should be mentioned in the commit message.

Quoted 5 lines
arch/arm/configs/exynos_defconfig +1 -0
+CONFIG_LEDS_TRIGGER_HEARTBEAT=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_MAX77686=y
 CONFIG_RTC_DRV_MAX77802=y

Earlier design of the LED for Odroid XU3 was using gpio-leds Now It was change to using both pwm-leds and gpio-leds.

Earlier I kept them as loadable module and now build-in.

Should I resend this again. Or some body will update the commit message.

-Anand Moon

Quoted 9 lines

The change looks good to me though so with a better commit message:

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America

#4 lore raw

Hello Anand,

Quoted 56 lines · Anand Moon

Hi Javier,

Quoted 52 lines · Javier Martinez Canillas

Hello Anand,

Quoted 7 lines · Anand Moon

Enable config option NEW_LEDS, LEDS_CLASS, LEDS_GPIO, LEDS_PWM, LEDS_TRIGGERS, LEDS_TRIGGER_TIMER, LEDS_TRIGGER_HEARTBEAT for Odroid-XU3/XU4 board.

---

I think Krzysztof already mentioned but a commit message shouln't describe what the change is (one can look to the patch for that) but why the change is needed.

So I would had expect something along these lines:

Many Exynos boards (i.e: the Exynos5422 Odroid XU3/XU4) have GPIO and PWM based LEDs, so enable the needed Kconfig options to have support for these. Also, some boards use the heartbeat LED trigger so enable support for this as well.

Quoted 15 lines

Changes from last version
dropped following option.
CONFIG_LEDS_CLASS_FLASH
CONFIG_TRIGGER_ONESHOT
CONFIG_TRIGGER_GPIO
fixed the From address

---
 arch/arm/configs/exynos_defconfig | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/configs/exynos_defconfig +0 -0
index 9504e77..aaf7aa4 100644

arch/arm/configs/exynos_defconfig CONFIG_MMC_SDHCI_S3C_DMA=y · line 171

Quoted 9 lines
arch/arm/configs/exynos_defconfig +6 -0
@@ -163,6 +163,13 @@ CONFIG_MMC_SDHCI_S3C_DMA=y
 CONFIG_MMC_DW=y
 CONFIG_MMC_DW_IDMAC=y
 CONFIG_MMC_DW_EXYNOS=y
+CONFIG_NEW_LEDS=y
+CONFIG_LEDS_CLASS=y
+CONFIG_LEDS_GPIO=y
+CONFIG_LEDS_PWM=y
+CONFIG_LEDS_TRIGGERS=y
+CONFIG_LEDS_TRIGGER_TIMER=y

I don't see an Exynos board using the timer trigger. Do you need it for some user-space application that uses the sysfs interface? I'm OK with enabling it but again this should be mentioned in the commit message.

You haven't answered this question.

Quoted 10 lines
Quoted 6 lines

arch/arm/configs/exynos_defconfig CONFIG_MMC_SDHCI_S3C_DMA=y · line 175

Quoted 5 lines
arch/arm/configs/exynos_defconfig +1 -0
+CONFIG_LEDS_TRIGGER_HEARTBEAT=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_MAX77686=y
 CONFIG_RTC_DRV_MAX77802=y

Earlier design of the LED for Odroid XU3 was using gpio-leds Now It was change to using both pwm-leds and gpio-leds.

I know that Odroid XU3 have both LEDs connected to GPIO and PWM lines but that should be mentioned in the commit message.

Quoted 2 lines

Earlier I kept them as loadable module and now build-in.

Yes, because exynos_defconfig as everything as built-in to make it easier for developers to test by only copying the kernel image and not the modules.

Quoted 2 lines

Should I resend this again. Or some body will update the commit message.

If a patch has a typo, an extra blank line or something very easy to fix then it may be possible that the maintainer will do the fix when applying but changing the commit message I think is too much so in this case is better to resend IMHO.

Quoted 2 lines

-Anand Moon

Best regards,

Signature · 3 lines
Javier Martinez Canillas
Open Source Group
Samsung Research America