Skip to contentSkip to conversation

pkg-generic: fix <pkg>-legal-info target

PATCH New Baruch Siach 3 participants 6 messages Sep 2, 2015 – Sep 4, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pkg-generic: fix <pkg>-legal-info target

When making the <pkg>-legal-info target before the main legal-info target, the following error shows:

/bin/sh: /home/baruch/git/buildroot/output/legal-info/licenses.txt: No such file or directory package/freescale-imx/imx-vpu/imx-vpu.mk:39: recipe for target 'imx-vpu-legal-info' failed
make: *** [imx-vpu-legal-info] Error 1

Make <pkg>-legal-info depend on legal-info-prepare to ensure that $(LEGAL_INFO_DIR) exists when generating licenses.txt.

---
 package/pkg-generic.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-generic.mk +1 -1
index 6a7d97efdf02..24b473b13ff2 100644
@@ -715,7 +715,7 @@ endif
 endif
 
 # legal-info: produce legally relevant info.
-$(1)-legal-info:
+$(1)-legal-info: legal-info-prepare
 # Packages without a source are assumed to be part of Buildroot, skip them.
 	$$(foreach hook,$$($(2)_PRE_LEGAL_INFO_HOOKS),$$(call $$(hook))$$(sep))
 ifneq ($$(call qstrip,$$($(2)_SOURCE)),)
Signature · 1 line
2.5.0
#1 lore raw

PATCH 1/1 pkg-generic: fix <pkg>-legal-info target

Dear Baruch,

Quoted 21 lines · Baruch Siach

When making the <pkg>-legal-info target before the main legal-info target, the following error shows:

/bin/sh: /home/baruch/git/buildroot/output/legal-info/licenses.txt: No such file or directory package/freescale-imx/imx-vpu/imx-vpu.mk:39: recipe for target 'imx-vpu-legal-info' failed
make: *** [imx-vpu-legal-info] Error 1

Make <pkg>-legal-info depend on legal-info-prepare to ensure that $(LEGAL_INFO_DIR) exists when generating licenses.txt.

---
  package/pkg-generic.mk | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-generic.mk +0 -0
index 6a7d97efdf02..24b473b13ff2 100644

package/pkg-generic.mk endif · line 718

Quoted 5 lines
package/pkg-generic.mk +1 -1
@@ -715,7 +715,7 @@ endif
  endif
 
  # legal-info: produce legally relevant info.
-$(1)-legal-info:
+$(1)-legal-info: legal-info-prepare

Very weird, I can reproduce the bug, but only for packages under package/freescale/, like imx-vpu. I tested a dozen other packages, and they all work fine. My test command is:

   git clean -xdf && make defconfig && \
     make BR2_DL_DIR=~/src ${PKG}-legal-info

Any idea of why these packages are special?

Signature · 1 line
Luca
#2 lore raw

PATCH 1/1 pkg-generic: fix <pkg>-legal-info target

Hi Luca,

Quoted 32 lines · Luca Ceresoli
Quoted 21 lines · Baruch Siach

When making the <pkg>-legal-info target before the main legal-info target, the following error shows:

/bin/sh: /home/baruch/git/buildroot/output/legal-info/licenses.txt: No such file or directory package/freescale-imx/imx-vpu/imx-vpu.mk:39: recipe for target 'imx-vpu-legal-info' failed
make: *** [imx-vpu-legal-info] Error 1

Make <pkg>-legal-info depend on legal-info-prepare to ensure that $(LEGAL_INFO_DIR) exists when generating licenses.txt.

---
 package/pkg-generic.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-generic.mk +0 -0
index 6a7d97efdf02..24b473b13ff2 100644

package/pkg-generic.mk endif · line 718

Quoted 5 lines
package/pkg-generic.mk +1 -1
@@ -715,7 +715,7 @@ endif
 endif
 
 # legal-info: produce legally relevant info.
-$(1)-legal-info:
+$(1)-legal-info: legal-info-prepare

Very weird, I can reproduce the bug, but only for packages under package/freescale/, like imx-vpu. I tested a dozen other packages, and they all work fine. My test command is:

Quoted 4 lines
  git clean -xdf && make defconfig && \
    make BR2_DL_DIR=~/src ${PKG}-legal-info

Any idea of why these packages are special?

Which target creates the legal-info/ directory in the successful (non freescale) case?

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#3 lore raw

PATCH 1/1 pkg-generic: fix <pkg>-legal-info target

Dear Baruch,

Quoted 35 lines · Baruch Siach

Hi Luca,

Quoted 32 lines · Luca Ceresoli
Quoted 21 lines · Baruch Siach

When making the <pkg>-legal-info target before the main legal-info target, the following error shows:

/bin/sh: /home/baruch/git/buildroot/output/legal-info/licenses.txt: No such file or directory package/freescale-imx/imx-vpu/imx-vpu.mk:39: recipe for target 'imx-vpu-legal-info' failed
make: *** [imx-vpu-legal-info] Error 1

Make <pkg>-legal-info depend on legal-info-prepare to ensure that $(LEGAL_INFO_DIR) exists when generating licenses.txt.

---
  package/pkg-generic.mk | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-generic.mk +0 -0
index 6a7d97efdf02..24b473b13ff2 100644

package/pkg-generic.mk endif · line 718

Quoted 5 lines
package/pkg-generic.mk +1 -1
@@ -715,7 +715,7 @@ endif
  endif
 
  # legal-info: produce legally relevant info.
-$(1)-legal-info:
+$(1)-legal-info: legal-info-prepare

Very weird, I can reproduce the bug, but only for packages under package/freescale/, like imx-vpu. I tested a dozen other packages, and they all work fine. My test command is:

Quoted 6 lines
Quoted 4 lines
   git clean -xdf && make defconfig && \
     make BR2_DL_DIR=~/src ${PKG}-legal-info

Any idea of why these packages are special?

Which target creates the legal-info/ directory in the successful (non freescale) case?

Aah, yes, now I got it! Freescale packages have <PKG>_REDISTRIBUTE = NO. This makes a difference in package/pkg-generic.mk, around line 710:

ifeq ($$($(2)_REDISTRIBUTE),YES)
...
$(1)-legal-info: $(1)-source $$(REDIST_SOURCES_DIR_$$(call UPPERCASE,$(4)))
...
endif

Which creates output/legal-info/sources/, thus output/legal-info/ is there as well and licenses.txt can be written, but not for no-redistribute packages.

But let's see the issue from a more general point of view.

Note that calling <PKG>-legal-info is not really working in general, since it does not understand whether it has already been run. E.g. calling 'make busybox-legal-info; make busybox-legal-info' produces, with your patch:

$ cat output/legal-info/manifest.csv
"PACKAGE","VERSION","LICENSE","LICENSE FILES","SOURCE ARCHIVE","SOURCE SITE"
"busybox","1.23.2","GPLv2","LICENSE","busybox-1.23.2.tar.bz2","http://www.busybox.net/downloads"
"PACKAGE","VERSION","LICENSE","LICENSE FILES","SOURCE ARCHIVE","SOURCE SITE"
"busybox","1.23.2","GPLv2","LICENSE","busybox-1.23.2.tar.bz2","http://www.busybox.net/downloads"

and without it:

$ cat output/legal-info/manifest.csv
"busybox","1.23.2","GPLv2","LICENSE","busybox-1.23.2.tar.bz2","http://www.busybox.net/downloads"
"busybox","1.23.2","GPLv2","LICENSE","busybox-1.23.2.tar.bz2","http://www.busybox.net/downloads"

Both results are "wrong", in that they produce duplicates.

If we really want to support this use case, a .stamp_legal_info would be needed.

The only use case that works now is the full 'make legal-info', which "executes" legal-info-clean, then legal-info-prepare, then <PKG>-legal-info (via <PKG>-all-legal-info) for all packages, exactly in that order.

This raises a couple of questions.

First, why do we have <pkg>-legal-info in 'make help' at all?

Arnout, you wrote that line in the help text, after a discussion IIRC. Do you remember a good reason _not_ to remove it?

Second, is Baruch's patch (or any variation) to be committed?

A first sight I think it should, since 'make <PKG>-legal-info' might be useful for testing a package legal info. But I'm not sure the duplicate results make things clearer or the foggier for the package recipe developer.

The alternative is to leave the code as is, and clearly state <PKG>-legal-info cannot be called.

However, if we want a patch, I think we should simply depend on $(LEGAL_INFO_DIR), not on legal-info-prepare. The latter is too much, and produces more duplicated lines.

Signature · 1 line
Luca
#4 lore raw

PATCH 1/1 pkg-generic: fix <pkg>-legal-info target

Quoted 4 lines · Luca Ceresoli

First, why do we have <pkg>-legal-info in 'make help' at all?

Arnout, you wrote that line in the help text, after a discussion IIRC. Do you remember a good reason _not_ to remove it?

I mostly took over what Thomas had put in
http://patchwork.ozlabs.org/patch/433692

So no, I see no reason to document <pkg>-legal-info.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle      arnout dot vandecappelle at essensium dot com
Senior Embedded Software Architect . . . . . . +32-478-010353 (mobile)
Essensium, Mind division . . . . . . . . . . . . . . http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium . . . . . BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#5 lore raw

PATCH 1/1 pkg-generic: fix <pkg>-legal-info target

Dear Arnout,

Quoted 5 lines · Arnout Vandecappelle
Quoted 2 lines · Luca Ceresoli

First, why do we have <pkg>-legal-info in 'make help' at all?

Quoted 7 lines
Quoted 2 lines

Arnout, you wrote that line in the help text, after a discussion IIRC. Do you remember a good reason _not_ to remove it?

I mostly took over what Thomas had put in
http://patchwork.ozlabs.org/patch/433692

So no, I see no reason to document <pkg>-legal-info.

Fine, I just sent a patch to remove that line.

Signature · 1 line
Luca