ocfs2_direct_IO_write misses ocfs2_is_overwrite error code
PATCH v2 1/1 ocfs2_direct_IO_write misses ocfs2_is_overwrite error code
If ocfs2_is_overwrite failed, ocfs2_direct_IO_write may still return success to the caller. changelog:
Using mlog_errno(ret) looks better than mlog_errno(is_overwrite)
Signed-off-by Norton.Zhu <[email protected]>
--- aops.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
aops.c +2 -1
@@ -846,7 +846,8 @@ static ssize_t ocfs2_direct_IO_write(struct kiocb *iocb, is_overwrite =ocfs2_is_overwrite (osb, inode, offset);if (is_overwrite <0 ) { -mlog_errno (is_overwrite); + ret = is_overwrite; +mlog_errno (ret);ocfs2_inode_unlock (inode,1 ); goto clean_orphan; }
Signature · 1 line
1.8.4.3
PATCH v2 1/1 ocfs2_direct_IO_write misses ocfs2_is_overwrite error code
Quoted 5 lines · Norton.Zhu
If
ocfs2_is_overwritefailed,ocfs2_direct_IO_writemay still return success to the caller. changelog:
Usingmlog_errno(ret)looks better thanmlog_errno(is_overwrite)Signed-off-by Norton.Zhu <[email protected]>
Reviewed-by Joseph Qi <[email protected]>
Quoted 19 lines
--- aops.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)aops.c +2
-1@@ -846,7 +846,8 @@ static ssize_t ocfs2_direct_IO_write(struct kiocb *iocb, is_overwrite =ocfs2_is_overwrite (osb, inode, offset);if (is_overwrite <0 ) { -mlog_errno (is_overwrite); + ret = is_overwrite; +mlog_errno (ret);ocfs2_inode_unlock (inode,1 ); goto clean_orphan; }